Commit 5eeba88
authored
fix(TMCU-538): update error state icon to new no-connection illustration (#27070)
## **Description**
Replaces the flat `IconName.WifiOff` design system icon in the shared
`ErrorState` component with themed PNG illustrations matching Vinay's
new "No connection" design. Uses `useAssetFromTheme` to switch between
light and dark variants, following the same pattern as
`CollectiblesEmptyState`.
This change affects all 4 homepage sections that render error states:
Tokens, Predictions, Perpetuals, and DeFi.
## **Changelog**
CHANGELOG entry: Updated the error state icon on the homepage to a new
no-connection illustration
## **Related issues**
Fixes: https://consensyssoftware.atlassian.net/browse/TMCU-538
## **Manual testing steps**
```gherkin
Feature: Updated error state icon on homepage sections
Scenario: user sees error state in light mode
Given user is on the homepage in light mode
And a section fails to load (e.g., Tokens, Predictions)
When the error state is displayed
Then the new no-connection illustration is shown (light variant)
And the Retry button is visible below the illustration
Scenario: user sees error state in dark mode
Given user is on the homepage in dark mode
And a section fails to load
When the error state is displayed
Then the new no-connection illustration is shown (dark variant)
```
## **Screenshots/Recordings**
Verified on device in both light and dark modes.
### **Before**
Flat `WifiOff` icon from the design system.
<img width="300"
src="https://github.com/user-attachments/assets/49379087-1929-43a2-9dee-3a7566df73a7"
/>
### **After**
New themed no-connection illustration (72x72) with light/dark variants.
<img width="300"
src="https://github.com/user-attachments/assets/e5b51582-2e93-4f44-a45f-49f36451571c"
/>w
## **Pre-merge author checklist**
- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I've included tests if applicable
- [x] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
## **Pre-merge reviewer checklist**
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Low Risk**
> Low risk UI-only change that swaps a design-system icon for themed PNG
assets in the shared homepage `ErrorState` component. Main risk is
limited to missing/incorrect asset bundling or sizing regressions across
sections that reuse this component.
>
> **Overview**
> Updates the shared homepage `ErrorState` UI to render a themed
no-connection PNG illustration (light/dark via `useAssetFromTheme`)
instead of the design-system `WifiOff` icon.
>
> Adds `react-native` `Image` rendering with Tailwind-based sizing
(72x72) and removes the unused icon imports, affecting all homepage
sections that reuse `ErrorState`.
>
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
d58c424. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->1 parent fe55bb5 commit 5eeba88
3 files changed
Lines changed: 13 additions & 9 deletions
File tree
- app
- components/Views/Homepage/components/ErrorState
- images
Lines changed: 13 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
| 2 | + | |
2 | 3 | | |
3 | 4 | | |
4 | 5 | | |
5 | | - | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | 6 | | |
10 | 7 | | |
11 | 8 | | |
12 | 9 | | |
13 | 10 | | |
14 | 11 | | |
15 | 12 | | |
| 13 | + | |
| 14 | + | |
16 | 15 | | |
| 16 | + | |
| 17 | + | |
17 | 18 | | |
18 | 19 | | |
19 | 20 | | |
| |||
24 | 25 | | |
25 | 26 | | |
26 | 27 | | |
27 | | - | |
| 28 | + | |
28 | 29 | | |
29 | 30 | | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
30 | 34 | | |
31 | 35 | | |
32 | 36 | | |
| |||
42 | 46 | | |
43 | 47 | | |
44 | 48 | | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
49 | 53 | | |
50 | 54 | | |
51 | 55 | | |
| |||
Loading
Loading
0 commit comments