Commit 5f18700
authored
test: remove toMatchSnapshot and removed snapshot files inaccounts tests (#28551)
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->
## **Description**
Refactors several React Native tests to stop using toMatchSnapshot and
instead assert key UI elements are present via getByTestId/getByText and
toBeOnTheScreen().
Deletes the corresponding Jest snapshot files for
BackupAndSyncFeaturesToggles, BackupAndSyncToggle,
ConfirmTurnOnBackupAndSyncModal, BackupAndSyncSettings, and
MultichainAccountsConnectedList, and updates assertions to use stable
IDs/translated strings (e.g., BACKUP_AND_SYNC_TOGGLE_TEST_IDS and
strings(...)).
## **Changelog**
<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`
If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`
(This helps the Release Engineer do their job more quickly and
accurately)
-->
CHANGELOG entry:
## **Related issues**
Fixes:
## **Manual testing steps**
```gherkin
Feature: my feature name
Scenario: user [verb for user action]
Given [describe expected initial app state]
When user [verb for user action]
Then [describe expected outcome]
```
## **Screenshots/Recordings**
<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->
### **Before**
<!-- [screenshots/recordings] -->
### **After**
<!-- [screenshots/recordings] -->
## **Pre-merge author checklist**
- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I've included tests if applicable
- [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
## **Pre-merge reviewer checklist**
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Low Risk**
> Test-only changes that remove brittle `toMatchSnapshot` coverage in
favor of targeted assertions; low risk aside from potentially missing
some structural regression detection previously covered by snapshots.
>
> **Overview**
> Refactors several React Native tests to **stop using
`toMatchSnapshot`** and instead assert key UI elements are present via
`getByTestId`/`getByText` and `toBeOnTheScreen()`.
>
> Deletes the corresponding Jest snapshot files for
`BackupAndSyncFeaturesToggles`, `BackupAndSyncToggle`,
`ConfirmTurnOnBackupAndSyncModal`, `BackupAndSyncSettings`, and
`MultichainAccountsConnectedList`, and updates assertions to use stable
IDs/translated strings (e.g., `BACKUP_AND_SYNC_TOGGLE_TEST_IDS` and
`strings(...)`).
>
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
28a4755. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->1 parent 3cc9298 commit 5f18700
10 files changed
Lines changed: 30 additions & 1686 deletions
File tree
- app/components
- UI/Identity
- BackupAndSyncFeaturesToggles
- __snapshots__
- BackupAndSyncToggle
- __snapshots__
- ConfirmTurnOnBackupAndSyncModal
- __snapshots__
- Views
- MultichainAccounts/MultichainAccountsConnectedList
- __snapshots__
- Settings/Identity
- __snapshots__
Lines changed: 10 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
70 | | - | |
71 | | - | |
72 | | - | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
73 | 80 | | |
74 | | - | |
75 | 81 | | |
76 | 82 | | |
77 | 83 | | |
| |||
Lines changed: 0 additions & 192 deletions
This file was deleted.
Lines changed: 7 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| 6 | + | |
6 | 7 | | |
7 | 8 | | |
8 | 9 | | |
| |||
92 | 93 | | |
93 | 94 | | |
94 | 95 | | |
95 | | - | |
96 | | - | |
| 96 | + | |
| 97 | + | |
97 | 98 | | |
98 | 99 | | |
99 | 100 | | |
100 | 101 | | |
101 | 102 | | |
102 | 103 | | |
103 | 104 | | |
104 | | - | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
105 | 109 | | |
106 | 110 | | |
107 | 111 | | |
| |||
Lines changed: 0 additions & 89 deletions
This file was deleted.
Lines changed: 8 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
10 | 11 | | |
11 | 12 | | |
12 | 13 | | |
| |||
69 | 70 | | |
70 | 71 | | |
71 | 72 | | |
72 | | - | |
73 | | - | |
| 73 | + | |
| 74 | + | |
74 | 75 | | |
75 | 76 | | |
76 | 77 | | |
77 | 78 | | |
78 | | - | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
79 | 84 | | |
80 | 85 | | |
81 | 86 | | |
| |||
0 commit comments