feat: deeplinks config social ai (#29383)

Bigshmow · zone-live · web-flow · commit 62ed9c6e7825 · 2026-04-28T17:59:53.000Z
## **Description** * Added social-trader-position as a supported deeplink action. * Added handleSocialTraderPositionUrl to parse required positionId. * Wired universal links so https://link.metamask.io/social-trader-position?positionId=... dispatches to that handler. * Navigates to TraderPositionView with { positionId }. * Missing/blank positionId falls back to wallet home. * Updated TraderPositionView route params to allow position-id-only entry and disabled Buy until hydrated position data exists. * Added analytics route mapping, without adding any signed-link behavior.  ## **Changelog**  CHANGELOG entry: null ## **Related issues** Fixes: ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist**  - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. #### Performance checks (if applicable) - [ ] I've tested on Android - Ideally on a mid-range device; emulator is acceptable - [ ] I've tested with a power user scenario - Use these [power-user SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93) to import wallets with many accounts and tokens - [ ] I've instrumented key operations with Sentry traces for production performance metrics - See [`trace()`](/app/util/trace.ts) for usage and [`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274) for an example For performance guidelines and tooling, see the [Performance Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers). ## **Pre-merge reviewer checklist**  - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.  --- > [!NOTE] > **Medium Risk** > Adds a new universal-link action and handler that parses query params and navigates into Social Leaderboard, touching deeplink routing/analytics and navigation param typing where regressions could break link handling. > > **Overview** > Enables a new universal link route `social-trader-position` that parses `positionId`/`traderId` query params and navigates to `Routes.SOCIAL_LEADERBOARD.POSITION`, with a guarded fallback to `Routes.SOCIAL_LEADERBOARD.VIEW` on missing/blank params or navigation errors. > > Wires the new action through deeplink configuration (`ACTIONS`, prefixes, supported-actions lists), `handleUniversalLink` dispatch, and deep-link analytics route mapping/extraction, and updates `TraderPositionView` typing/data plumbing to support deep-link entry where `tokenSymbol` may be absent (defaulting symbol to `''`). Adds focused unit tests for the new handler and universal-link dispatch, plus adjusts `TraderPositionView` tests for optional route params and positionId-driven fetch states. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit e2ec83f. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup>  --------- Co-authored-by: António Regadas <antonio.regadas@consensys.net>
diff --git a/app/components/Views/SocialLeaderboard/TraderPositionView/TraderPositionView.test.tsx b/app/components/Views/SocialLeaderboard/TraderPositionView/TraderPositionView.test.tsx
@@ -12,9 +12,10 @@ const mockHandleFetch = handleFetch as jest.MockedFunction<typeof handleFetch>;
 const mockPriceChart = jest.fn();
 
 interface MockRouteParams {
+  positionId?: string;
   traderId: string;
-  traderName: string;
-  tokenSymbol: string;
+  traderName?: string;
+  tokenSymbol?: string;
   position?: Position;
 }
 
diff --git a/app/components/Views/SocialLeaderboard/TraderPositionView/useTraderPositionData.ts b/app/components/Views/SocialLeaderboard/TraderPositionView/useTraderPositionData.ts
@@ -106,7 +106,7 @@ export { TIME_PERIODS };
 
 export function useTraderPositionData(
   positionParam: Position | undefined,
-  tokenSymbol: string,
+  tokenSymbol?: string,
 ): TraderPositionData {
   const [activeTimePeriod, setActiveTimePeriod] = useState<TimePeriod>('1D');
 
@@ -268,7 +268,7 @@ export function useTraderPositionData(
 
   // ── Position card ──────────────────────────────────────────────────────
 
-  const symbol = positionParam?.tokenSymbol ?? tokenSymbol;
+  const symbol = positionParam?.tokenSymbol ?? tokenSymbol ?? '';
   const isClosed =
     positionParam != null &&
     positionParam.positionAmount === 0 &&
diff --git a/app/constants/deeplinks.ts b/app/constants/deeplinks.ts
@@ -46,6 +46,7 @@ export enum ACTIONS {
   PREDICT = 'predict',
   ONBOARDING = 'onboarding',
   TRENDING = 'trending',
+  SOCIAL_TRADER_POSITION = 'social-trader-position',
   EARN_MUSD = 'earn-musd',
   NFT = 'nft',
 }
@@ -80,6 +81,7 @@ export const PREFIXES = {
   [ACTIONS.CARD_HOME]: '',
   [ACTIONS.CARD_KYC_NOTIFICATION]: '',
   [ACTIONS.TRENDING]: '',
+  [ACTIONS.SOCIAL_TRADER_POSITION]: '',
   [ACTIONS.EARN_MUSD]: '',
   [ACTIONS.NFT]: '',
   METAMASK: 'metamask://',
diff --git a/app/core/DeeplinkManager/handlers/legacy/__tests__/handleSocialTraderPositionUrl.test.ts b/app/core/DeeplinkManager/handlers/legacy/__tests__/handleSocialTraderPositionUrl.test.ts
@@ -0,0 +1,116 @@
+import NavigationService from '../../../../NavigationService';
+import Routes from '../../../../../constants/navigation/Routes';
+import DevLogger from '../../../../SDKConnect/utils/DevLogger';
+import { handleSocialTraderPositionUrl } from '../handleSocialTraderPositionUrl';
+
+jest.mock('../../../../NavigationService', () => ({
+  navigation: {
+    navigate: jest.fn(),
+  },
+}));
+
+jest.mock('../../../../SDKConnect/utils/DevLogger', () => ({
+  log: jest.fn(),
+}));
+
+describe('handleSocialTraderPositionUrl', () => {
+  const mockNavigate = NavigationService.navigation.navigate as jest.Mock;
+
+  beforeEach(() => {
+    jest.clearAllMocks();
+  });
+
+  it('navigates to TraderPositionView with positionId', () => {
+    handleSocialTraderPositionUrl({
+      actionPath:
+        '?positionId=92d9001b-8b64-4b13-9c1b-ba9292a6099a&traderId=trader-1&deduplication_id=dedup-1&notification_event=follow_newtrade_buy',
+    });
+
+    expect(mockNavigate).toHaveBeenCalledWith(
+      Routes.SOCIAL_LEADERBOARD.POSITION,
+      {
+        positionId: '92d9001b-8b64-4b13-9c1b-ba9292a6099a',
+        traderId: 'trader-1',
+      },
+    );
+  });
+
+  it('navigates with only positionId and traderId route params', () => {
+    handleSocialTraderPositionUrl({
+      actionPath: '?positionId=position-1&traderId=trader-1',
+    });
+
+    expect(mockNavigate).toHaveBeenCalledWith(
+      Routes.SOCIAL_LEADERBOARD.POSITION,
+      {
+        positionId: 'position-1',
+        traderId: 'trader-1',
+      },
+    );
+  });
+
+  it('decodes encoded positionId and traderId values', () => {
+    handleSocialTraderPositionUrl({
+      actionPath:
+        '?positionId=position%20id%2Fwith%20reserved%3Fchars&traderId=trader%20id%2Fwith%20reserved%3Fchars&deduplication_id=dedup%20id%2Fwith%20reserved%3Fchars&notification_event=follow%20newtrade%2Fbuy',
+    });
+
+    expect(mockNavigate).toHaveBeenCalledWith(
+      Routes.SOCIAL_LEADERBOARD.POSITION,
+      {
+        positionId: 'position id/with reserved?chars',
+        traderId: 'trader id/with reserved?chars',
+      },
+    );
+    expect(DevLogger.log).toHaveBeenCalledWith(
+      '[handleSocialTraderPositionUrl] Parsed navigation parameters:',
+      {
+        positionId: 'position id/with reserved?chars',
+        traderId: 'trader id/with reserved?chars',
+        deduplicationId: 'dedup id/with reserved?chars',
+        notificationEvent: 'follow newtrade/buy',
+      },
+    );
+  });
+
+  it('falls back to social leaderboard when traderId is missing', () => {
+    handleSocialTraderPositionUrl({
+      actionPath: '?positionId=92d9001b-8b64-4b13-9c1b-ba9292a6099a',
+    });
+
+    expect(mockNavigate).toHaveBeenCalledWith(Routes.SOCIAL_LEADERBOARD.VIEW);
+  });
+
+  it('falls back to social leaderboard when positionId is missing', () => {
+    handleSocialTraderPositionUrl({ actionPath: '' });
+
+    expect(mockNavigate).toHaveBeenCalledWith(Routes.SOCIAL_LEADERBOARD.VIEW);
+    expect(DevLogger.log).toHaveBeenCalledWith(
+      '[handleSocialTraderPositionUrl] Missing positionId or traderId, falling back to social leaderboard',
+    );
+  });
+
+  it('falls back to social leaderboard when positionId is blank', () => {
+    handleSocialTraderPositionUrl({
+      actionPath: '?positionId=%20%20&traderId=trader-1',
+    });
+
+    expect(mockNavigate).toHaveBeenCalledWith(Routes.SOCIAL_LEADERBOARD.VIEW);
+  });
+
+  it('falls back to social leaderboard on navigation errors', () => {
+    mockNavigate.mockImplementationOnce(() => {
+      throw new Error('Navigation error');
+    });
+
+    handleSocialTraderPositionUrl({
+      actionPath:
+        '?positionId=92d9001b-8b64-4b13-9c1b-ba9292a6099a&traderId=trader-1',
+    });
+
+    expect(mockNavigate).toHaveBeenCalledTimes(2);
+    expect(mockNavigate).toHaveBeenLastCalledWith(
+      Routes.SOCIAL_LEADERBOARD.VIEW,
+    );
+  });
+});
diff --git a/app/core/DeeplinkManager/handlers/legacy/__tests__/handleUniversalLink.test.ts b/app/core/DeeplinkManager/handlers/legacy/__tests__/handleUniversalLink.test.ts
@@ -16,6 +16,7 @@ import handleBrowserUrl from '../handleBrowserUrl';
 import { DeepLinkModalLinkType } from '../../../../../components/UI/DeepLinkModal';
 import handleMetaMaskDeeplink from '../handleMetaMaskDeeplink';
 import { SHIELD_WEBSITE_URL } from '../../../../../constants/shield';
+import { handleSocialTraderPositionUrl } from '../handleSocialTraderPositionUrl';
 // eslint-disable-next-line import-x/no-namespace
 import * as signatureUtils from '../../../utils/verifySignature';
 
@@ -40,6 +41,7 @@ jest.mock('../handleRewardsUrl');
 jest.mock('../handlePredictUrl');
 jest.mock('../handleFastOnboarding');
 jest.mock('../handleTrendingUrl');
+jest.mock('../handleSocialTraderPositionUrl');
 jest.mock('../../../../redux', () => ({
   __esModule: true,
   default: {
@@ -829,6 +831,36 @@ describe('handleUniversalLink', () => {
     });
   });
 
+  describe('ACTIONS.SOCIAL_TRADER_POSITION', () => {
+    it('calls _handleSocialTraderPosition when action is SOCIAL_TRADER_POSITION', async () => {
+      const positionUrl = `${PROTOCOLS.HTTPS}://${AppConstants.MM_UNIVERSAL_LINK_HOST}/${ACTIONS.SOCIAL_TRADER_POSITION}?positionId=position-1&traderId=trader-1&deduplication_id=dedup-1&notification_event=follow_newtrade_buy`;
+      const positionUrlObj = {
+        ...urlObj,
+        hostname: AppConstants.MM_UNIVERSAL_LINK_HOST,
+        href: positionUrl,
+        pathname: `/${ACTIONS.SOCIAL_TRADER_POSITION}`,
+        search:
+          '?positionId=position-1&traderId=trader-1&deduplication_id=dedup-1&notification_event=follow_newtrade_buy',
+      };
+
+      await handleUniversalLink({
+        instance,
+        handled,
+        urlObj: positionUrlObj,
+        browserCallBack: mockBrowserCallBack,
+        url: positionUrl,
+        source: 'test-source',
+      });
+
+      expect(mockHandleDeepLinkModalDisplay).not.toHaveBeenCalled();
+      expect(handleSocialTraderPositionUrl).toHaveBeenCalledWith({
+        actionPath:
+          '?positionId=position-1&traderId=trader-1&deduplication_id=dedup-1&notification_event=follow_newtrade_buy',
+      });
+      expect(handled).toHaveBeenCalled();
+    });
+  });
+
   describe('ACTIONS.WC', () => {
     const testCases = [
       {
diff --git a/app/core/DeeplinkManager/handlers/legacy/handleSocialTraderPositionUrl.ts b/app/core/DeeplinkManager/handlers/legacy/handleSocialTraderPositionUrl.ts
@@ -0,0 +1,76 @@
+import NavigationService from '../../../NavigationService';
+import Routes from '../../../../constants/navigation/Routes';
+import DevLogger from '../../../SDKConnect/utils/DevLogger';
+
+interface HandleSocialTraderPositionUrlParams {
+  actionPath: string;
+}
+
+interface SocialTraderPositionNavigationParams {
+  positionId?: string;
+  traderId?: string;
+  deduplicationId?: string;
+  notificationEvent?: string;
+}
+
+const parseSocialTraderPositionNavigationParams = (
+  actionPath: string,
+): SocialTraderPositionNavigationParams => {
+  const urlParams = new URLSearchParams(
+    actionPath.includes('?') ? actionPath.split('?')[1] : '',
+  );
+
+  return {
+    positionId: urlParams.get('positionId')?.trim() || undefined,
+    traderId: urlParams.get('traderId')?.trim() || undefined,
+    deduplicationId: urlParams.get('deduplication_id')?.trim() || undefined,
+    notificationEvent: urlParams.get('notification_event')?.trim() || undefined,
+  };
+};
+
+const navigateToFallback = () => {
+  NavigationService.navigation.navigate(Routes.SOCIAL_LEADERBOARD.VIEW);
+};
+
+/**
+ * Handles notification-approved TraderPosition deeplinks.
+ *
+ * Supported URL format:
+ * - https://link.metamask.io/social-trader-position?positionId=<positionId>&traderId=<traderId>&deduplication_id=<deduplicationId>&notification_event=<notificationEvent>
+ */
+export const handleSocialTraderPositionUrl = ({
+  actionPath,
+}: HandleSocialTraderPositionUrlParams) => {
+  DevLogger.log(
+    '[handleSocialTraderPositionUrl] Starting deeplink handling with path:',
+    actionPath,
+  );
+
+  try {
+    const { positionId, traderId, deduplicationId, notificationEvent } =
+      parseSocialTraderPositionNavigationParams(actionPath);
+    DevLogger.log(
+      '[handleSocialTraderPositionUrl] Parsed navigation parameters:',
+      { positionId, traderId, deduplicationId, notificationEvent },
+    );
+
+    if (!positionId || !traderId) {
+      DevLogger.log(
+        '[handleSocialTraderPositionUrl] Missing positionId or traderId, falling back to social leaderboard',
+      );
+      navigateToFallback();
+      return;
+    }
+
+    NavigationService.navigation.navigate(Routes.SOCIAL_LEADERBOARD.POSITION, {
+      positionId,
+      traderId,
+    });
+  } catch (error) {
+    DevLogger.log(
+      '[handleSocialTraderPositionUrl] Failed to handle deeplink:',
+      error,
+    );
+    navigateToFallback();
+  }
+};
diff --git a/app/core/DeeplinkManager/handlers/legacy/handleUniversalLink.ts b/app/core/DeeplinkManager/handlers/legacy/handleUniversalLink.ts
@@ -30,6 +30,7 @@ import { handleCardOnboarding } from './handleCardOnboarding';
 import { handleCardHome } from './handleCardHome';
 import { handleCardKycNotification } from './handleCardKycNotification';
 import { handleTrendingUrl } from './handleTrendingUrl';
+import { handleSocialTraderPositionUrl } from './handleSocialTraderPositionUrl';
 import { handleEarnMusd } from './handleEarnMusd';
 import { handleAssetUrl } from './handleAssetUrl';
 import { handleNftUrl } from './handleNftUrl';
@@ -84,6 +85,7 @@ const SUPPORTED_ACTIONS = {
   CARD_HOME: ACTIONS.CARD_HOME,
   CARD_KYC_NOTIFICATION: ACTIONS.CARD_KYC_NOTIFICATION,
   TRENDING: ACTIONS.TRENDING,
+  SOCIAL_TRADER_POSITION: ACTIONS.SOCIAL_TRADER_POSITION,
   SHIELD: ACTIONS.SHIELD,
   EARN_MUSD: ACTIONS.EARN_MUSD,
   NFT: ACTIONS.NFT,
@@ -116,6 +118,7 @@ const WHITELISTED_ACTIONS: SUPPORTED_ACTIONS[] = [
   SUPPORTED_ACTIONS.SELL,
   SUPPORTED_ACTIONS.SELL_CRYPTO,
   SUPPORTED_ACTIONS.TRENDING,
+  SUPPORTED_ACTIONS.SOCIAL_TRADER_POSITION,
   SUPPORTED_ACTIONS.SHIELD,
   SUPPORTED_ACTIONS.EARN_MUSD,
 ];
@@ -633,6 +636,12 @@ async function handleUniversalLink({
       });
       break;
     }
+    case SUPPORTED_ACTIONS.SOCIAL_TRADER_POSITION: {
+      handleSocialTraderPositionUrl({
+        actionPath: actionBasedRampPath,
+      });
+      break;
+    }
     case SUPPORTED_ACTIONS.EARN_MUSD: {
       handleEarnMusd();
       break;
diff --git a/app/core/DeeplinkManager/types/deepLink.types.ts b/app/core/DeeplinkManager/types/deepLink.types.ts
@@ -132,6 +132,7 @@ export const SUPPORTED_ACTIONS = [
   ACTIONS.ONBOARDING,
   ACTIONS.PREDICT,
   ACTIONS.TRENDING,
+  ACTIONS.SOCIAL_TRADER_POSITION,
   ACTIONS.CARD_ONBOARDING,
   ACTIONS.CARD_HOME,
   ACTIONS.SHIELD,
diff --git a/app/core/DeeplinkManager/types/deepLinkAnalytics.types.ts b/app/core/DeeplinkManager/types/deepLinkAnalytics.types.ts
@@ -51,6 +51,7 @@ export enum DeepLinkRoute {
   PREDICT = 'predict',
   SHIELD = 'shield',
   TRENDING = 'trending',
+  SOCIAL_TRADER_POSITION = 'social-trader-position',
   CARD_ONBOARDING = 'card-onboarding',
   CARD_HOME = 'card-home',
   NFT = 'nft',
diff --git a/app/core/DeeplinkManager/util/deeplinks/deepLinkAnalytics.test.ts b/app/core/DeeplinkManager/util/deeplinks/deepLinkAnalytics.test.ts
@@ -455,6 +455,7 @@ describe('deepLinkAnalytics', () => {
       [ACTIONS.DAPP, DeepLinkRoute.DAPP],
       [ACTIONS.WC, DeepLinkRoute.WC],
       [ACTIONS.CREATE_ACCOUNT, DeepLinkRoute.CREATE_ACCOUNT],
+      [ACTIONS.SOCIAL_TRADER_POSITION, DeepLinkRoute.SOCIAL_TRADER_POSITION],
     ] as const)(
       'maps action %s to its corresponding route',
       (action, expectedRoute) => {
@@ -519,6 +520,13 @@ describe('deepLinkAnalytics', () => {
       expect(result).toBe(DeepLinkRoute.SHIELD);
     });
 
+    it('extract social trader position route', () => {
+      const result = extractRouteFromUrl(
+        'https://link.metamask.io/social-trader-position?positionId=position-1',
+      );
+      expect(result).toBe(DeepLinkRoute.SOCIAL_TRADER_POSITION);
+    });
+
     it('extract home route for empty path', () => {
       const result = extractRouteFromUrl('https://link.metamask.io/');
       expect(result).toBe(DeepLinkRoute.HOME);
diff --git a/app/core/DeeplinkManager/util/deeplinks/deepLinkAnalytics.ts b/app/core/DeeplinkManager/util/deeplinks/deepLinkAnalytics.ts
@@ -463,6 +463,7 @@ const routeExtractors: Record<
   [DeepLinkRoute.PREDICT]: extractPredictProperties,
   [DeepLinkRoute.SHIELD]: extractShieldProperties,
   [DeepLinkRoute.TRENDING]: extractTrendingProperties,
+  [DeepLinkRoute.SOCIAL_TRADER_POSITION]: extractInvalidProperties,
   [DeepLinkRoute.CARD_ONBOARDING]: extractCardOnboardingProperties,
   [DeepLinkRoute.CARD_HOME]: extractCardHomeProperties,
   [DeepLinkRoute.NFT]: extractNftProperties,
@@ -593,6 +594,8 @@ export const mapSupportedActionToRoute = (
       return DeepLinkRoute.SHIELD;
     case ACTIONS.TRENDING:
       return DeepLinkRoute.TRENDING;
+    case ACTIONS.SOCIAL_TRADER_POSITION:
+      return DeepLinkRoute.SOCIAL_TRADER_POSITION;
     case ACTIONS.CARD_ONBOARDING:
       return DeepLinkRoute.CARD_ONBOARDING;
     case ACTIONS.CARD_HOME:
@@ -647,6 +650,8 @@ export const extractRouteFromUrl = (url: string): DeepLinkRoute => {
         return DeepLinkRoute.SHIELD;
       case 'trending':
         return DeepLinkRoute.TRENDING;
+      case 'social-trader-position':
+        return DeepLinkRoute.SOCIAL_TRADER_POSITION;
       case 'card-onboarding':
         return DeepLinkRoute.CARD_ONBOARDING;
       case 'card-home':
diff --git a/app/core/NavigationService/types.ts b/app/core/NavigationService/types.ts
