Skip to content

Commit 6311304

Browse files
chore(runway): cherry-pick fix: titles on explore search cp-7.77.0 (#30026)
- fix: titles on explore search cp-7.77.0 (#29985) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until this PR meets the canonical Definition of Ready For Review in `docs/readme/ready-for-review.md`. In short: the template must be materially complete (not just section titles present), all status checks must be currently passing, and the only expected follow-up commits must be reviewer-driven. --> ## **Description** Update these titles: - "Trending" -> "Crypto" - "Popular" -> "Sites" In the explore search screen <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: update titles on explore search ## **Related issues** Fixes: https://consensyssoftware.atlassian.net/browse/ASSETS-3190 ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** <!-- Every checklist item must be consciously assessed before marking this PR as "Ready for review". A checked box means you deliberately considered that responsibility, not that you literally performed every action listed. Unchecked boxes are ambiguous: they are not an implicit "N/A" and they are not a silent "skip". See `docs/readme/ready-for-review.md` for the full checklist semantics. --> - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I've included tests if applicable - [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. #### Performance checks (if applicable) - [ ] I've tested on Android - Ideally on a mid-range device; emulator is acceptable - [ ] I've tested with a power user scenario - Use these [power-user SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93) to import wallets with many accounts and tokens - [ ] I've instrumented key operations with Sentry traces for production performance metrics - See [`trace()`](/app/util/trace.ts) for usage and [`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274) for an example For performance guidelines and tooling, see the [Performance Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers). ## **Pre-merge reviewer checklist** <!-- Reviewer checklist items follow the same semantics as the author checklist: an unchecked box is ambiguous, a checked box means the reviewer consciously assessed that responsibility. See `docs/readme/ready-for-review.md`. --> - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk UI copy/i18n change limited to Explore search section headers; no business logic or data handling changes. > > **Overview** > Updates Explore omni-search section headers to use clearer labels. > > Specifically renames the tokens section title from `trending.trending_tokens` ("Trending") to a new `trending.crypto` ("Crypto") string, and changes the sites section title from `sites.popular` to `trending.sites` ("Sites"). > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 5048cf2. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> [2c65619](2c65619) Co-authored-by: Juanmi <95381763+juanmigdr@users.noreply.github.com>
1 parent dbf4184 commit 6311304

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

app/components/Views/TrendingView/search/useExploreSearch.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ export const useExploreSearch = (query: string): ExploreSearchResult => {
7676
const sections: SearchFeedSection[] = [
7777
{
7878
feedId: 'tokens',
79-
title: strings('trending.trending_tokens'),
79+
title: strings('trending.crypto'),
8080
items: trim(tokens.data),
8181
isLoading: isDebouncing || tokens.isLoading,
8282
},
@@ -106,7 +106,7 @@ export const useExploreSearch = (query: string): ExploreSearchResult => {
106106
},
107107
{
108108
feedId: 'sites',
109-
title: strings('sites.popular'),
109+
title: strings('trending.sites'),
110110
items: trim(sites.data),
111111
isLoading: isDebouncing || sites.isLoading,
112112
},

locales/languages/en.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8820,6 +8820,7 @@
88208820
"crypto_movers": "Crypto movers",
88218821
"perps_movers": "Perps movers",
88228822
"trending_tokens": "Trending",
8823+
"crypto": "Crypto",
88238824
"stocks": "Stocks",
88248825
"price_change": "Price change",
88258826
"all_networks": "All networks",

0 commit comments

Comments
 (0)