chore: Remove permissions settings feature flag (#29685)

## **Description**

Removes `MM_PERMISSIONS_SETTINGS_V1_ENABLED` now that it only gates the
SDK Connections Management view. The row is now always shown and
continues to navigate to the existing SDK sessions manager.

## **Changelog**

CHANGELOG entry: Added back access to SDK connections management.

## **Related issues**

Fixes: WAPI-1468

## **Manual testing steps**

Feature: Account menu permissions entry

 Scenario: user opens the SDK connection manager from the account menu
 Given the user is in MetaMask Mobile

 When user opens the account menu
 Then the Permissions row is visible

 When user taps Permissions
 Then the SDK connections manager opens

## **Screenshots/Recordings**

N/A

### **Before**

N/A

### **After**


https://github.com/user-attachments/assets/e89156fd-b9f2-4a55-b3b5-22576f3cf53f


## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I've included tests if applicable
- [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Low risk: removes a now-unused env flag and makes the Accounts menu
Permissions row unconditional, with only minor UI/test/CI config
updates.
> 
> **Overview**
> **Removes the `MM_PERMISSIONS_SETTINGS_V1_ENABLED` feature flag** and
its wiring across the app/config.
> 
> The Accounts menu now **always renders the Permissions row** (no
gating), and related unit tests/CI env examples are updated to drop the
flag.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
d1ca060. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Author: adonesky1

.js.env.example

@@ -100,9 +100,6 @@ export MM_SAMPLE_FEATURE_COUNTER_ENABLED="true"
 # The endpoint used to submit errors and tracing data to Sentry for dev environment.
 # export MM_SENTRY_DSN_DEV=
 
-# Permissions Settings feature flag specific to UI changes
-export MM_PERMISSIONS_SETTINGS_V1_ENABLED=""
-
 # Earn Variables
 ## Stablecoin Lending
 export MM_STABLECOIN_LENDING_UI_ENABLED="true"

app/components/Views/AccountsMenu/AccountsMenu.test.tsx

@@ -96,11 +96,6 @@ jest.mock('../../../../locales/i18n', () => ({
   strings: jest.fn((key: string) => key),
 }));
 
-jest.mock('../../../util/networks', () => ({
-  ...jest.requireActual('../../../util/networks'),
-  isPermissionsSettingsV1Enabled: true,
-}));
-
 jest.mock('../../UI/Ramp/hooks/useRampsUnifiedV1Enabled', () => ({
   __esModule: true,
   default: jest.fn(() => false),

app/components/Views/AccountsMenu/AccountsMenu.tsx

@@ -25,7 +25,6 @@ import Routes from '../../../constants/navigation/Routes';
 import { strings } from '../../../../locales/i18n';
 import { useAnalytics } from '../../hooks/useAnalytics/useAnalytics';
 import { AccountsMenuSelectorsIDs } from './AccountsMenu.testIds';
-import { isPermissionsSettingsV1Enabled } from '../../../util/networks';
 import useRampsUnifiedV1Enabled from '../../UI/Ramp/hooks/useRampsUnifiedV1Enabled';
 import useRampsUnifiedV2Enabled from '../../UI/Ramp/hooks/useRampsUnifiedV2Enabled';
 import AppConstants from '../../../core/AppConstants';
@@ -441,17 +440,15 @@ const AccountsMenu = () => {
         />
 
         {/* Permissions Row */}
-        {isPermissionsSettingsV1Enabled && (
-          <ActionListItem
-            startAccessory={
-              <Icon name={IconName.SecurityTick} size={IconSize.Lg} />
-            }
-            label={strings('accounts_menu.permissions')}
-            endAccessory={arrowRightIcon}
-            onPress={onPressPermissions}
-            testID={AccountsMenuSelectorsIDs.PERMISSIONS}
-          />
-        )}
+        <ActionListItem
+          startAccessory={
+            <Icon name={IconName.SecurityTick} size={IconSize.Lg} />
+          }
+          label={strings('accounts_menu.permissions')}
+          endAccessory={arrowRightIcon}
+          onPress={onPressPermissions}
+          testID={AccountsMenuSelectorsIDs.PERMISSIONS}
+        />
 
         {/* Networks Row */}
         <ActionListItem

app/components/Views/Settings/index.test.tsx

@@ -52,11 +52,6 @@ jest.mock('@react-navigation/native', () => {
   };
 });
 
-jest.mock('../../../util/networks', () => ({
-  ...jest.requireActual('../../../util/networks'),
-  isPermissionsSettingsV1Enabled: true,
-}));
-
 jest.mock('../../../util/notifications/constants/config', () => ({
   isNotificationsFeatureEnabled: jest.fn(() => true),
 }));

app/util/networks/index.js

@@ -802,9 +802,6 @@ export const getBlockExplorerTxUrl = (
 export const getIsNetworkOnboarded = (chainId, networkOnboardedState) =>
   networkOnboardedState[chainId];
 
-export const isPermissionsSettingsV1Enabled =
-  process.env.MM_PERMISSIONS_SETTINGS_V1_ENABLED === 'true';
-
 // The whitelisted network names for the given chain IDs to prevent showing warnings on Network Settings.
 export const WHILELIST_NETWORK_NAME = {
   [ChainId.mainnet]: 'Mainnet',

bitrise.yml

@@ -3493,9 +3493,6 @@ app:
     - opts:
         is_expand: false
       MM_NETWORK_UI_REDESIGN_ENABLED: false
-    - opts:
-        is_expand: false
-      MM_PERMISSIONS_SETTINGS_V1_ENABLED: false
     - opts:
         is_expand: false
       MM_SECURITY_ALERTS_API_ENABLED: true

builds.yml

@@ -40,7 +40,6 @@ _public_envs: &public_envs # Servers (production)
   IS_TEST: 'false'
   SEEDLESS_ONBOARDING_ENABLED: 'true'
   MM_NOTIFICATIONS_UI_ENABLED: 'true'
-  MM_PERMISSIONS_SETTINGS_V1_ENABLED: 'false'
   MM_PERPS_BLOCKED_REGIONS: 'US,CA-ON,GB,BE'
   MM_PERPS_HIP3_ALLOWLIST_MARKETS: ''
   MM_PERPS_HIP3_BLOCKLIST_MARKETS: ''