feat(analytics): align Remote Connection Request platform property with sig/txn events

Pairs with [segment-schema#545](Consensys/segment-schema#545),
which renames `sdk_platform` → `remote_request_platform` on the Remote
Connection Request Received/Failed events and tightens the type to the
5-value `PlatformType` enum shared between SDK v1 and v2.

Mobile-side changes:

- `SDKConnectV2/services/connection-registry.ts`: rename the property
  key on the three MWP `trackMwpEvent` call sites (the V2 emitter).
- `SDKConnect/ConnectionManagement/connectToChannel.ts`: extend the V1
  emitter to populate `remote_request_platform` from
  `originatorInfo.platform`. V1 previously did not populate this field
  at all. The value is coerced from an empty string to `undefined` so
  the property is dropped when `getPlatformType` can't resolve a
  platform (the remote SDK falls back to `platform: ''` in that case),
  avoiding an invalid-enum rejection on the Segment side.
- Updated tests to assert the new key and the empty-string coercion.

Both V1 and V2 derive their platform values from `PlatformType` in
`@metamask/sdk-communication-layer`, so no client-side mapping or enum
widening is required.

Author: adonesky1

app/core/SDKConnect/ConnectionManagement/connectToChannel.test.ts

@@ -282,11 +282,34 @@ describe('connectToChannel', () => {
           properties: expect.objectContaining({
             transport_type: 'socket_relay',
             remote_session_id: 'test-anon-id',
+            sdk_version: '1.0.0',
+            remote_request_platform: 'web',
           }),
         }),
       );
     });
 
+    it('should coerce an empty-string originatorInfo.platform to undefined so the property is dropped', async () => {
+      originatorInfo.anonId = 'test-anon-id';
+      originatorInfo.platform = '';
+      (checkPermissions as jest.Mock).mockResolvedValue(true);
+
+      await connectToChannel({
+        instance: mockInstance,
+        id,
+        trigger,
+        otherPublicKey,
+        origin,
+        validUntil,
+        originatorInfo,
+        initialConnection: true,
+      });
+
+      const trackedProperties = (analytics.trackEvent as jest.Mock).mock
+        .calls[0][0].properties;
+      expect(trackedProperties).not.toHaveProperty('remote_request_platform');
+    });
+
     // wallet_connection_user_approved / wallet_connection_user_rejected are
     // intentionally NOT tracked here — they are already covered by the
     // MetaMetrics CONNECT_REQUEST_COMPLETED / CONNECT_REQUEST_CANCELLED events

app/core/SDKConnect/ConnectionManagement/connectToChannel.ts

@@ -85,6 +85,13 @@ async function connectToChannel({
         .addProperties({
           transport_type: 'socket_relay',
           sdk_version: originatorInfo?.apiVersion,
+          // `originatorInfo.platform` is sourced from `PlatformType` in
+          // `@metamask/sdk-communication-layer`; aligns with the V2 emitter and
+          // the `remote_request_platform` enum in schema#545. Coerce empty
+          // strings (fallback when `getPlatformType` can't resolve) to
+          // undefined so the property is dropped rather than flagged as an
+          // invalid enum value.
+          remote_request_platform: originatorInfo?.platform || undefined,
           remote_session_id: anonId,
         })
         .build(),

app/core/SDKConnectV2/services/connection-registry.test.ts

@@ -441,7 +441,7 @@ describe('ConnectionRegistry', () => {
           remote_session_id: mockConnectionRequest.sessionRequest.id,
           transport_type: TransportType.MWP,
           sdk_version: '2.0.0',
-          sdk_platform: 'JavaScript',
+          remote_request_platform: 'JavaScript',
         }),
       );
     });

app/core/SDKConnectV2/services/connection-registry.ts

@@ -182,7 +182,7 @@ export class ConnectionRegistry {
         remote_session_id: conn.metadata?.analytics?.remote_session_id ?? id,
         transport_type: TransportType.MWP,
         sdk_version: conn.metadata?.sdk?.version,
-        sdk_platform: conn.metadata?.sdk?.platform,
+        remote_request_platform: conn.metadata?.sdk?.platform,
         found_in_store: true,
       });
       return;
@@ -257,7 +257,7 @@ export class ConnectionRegistry {
           connReq.sessionRequest.id,
         transport_type: TransportType.MWP,
         sdk_version: connReq.metadata.sdk.version,
-        sdk_platform: connReq.metadata.sdk.platform,
+        remote_request_platform: connReq.metadata.sdk.platform,
       });
 
       // Defense-in-depth: block connections whose self-reported dapp metadata
@@ -304,7 +304,7 @@ export class ConnectionRegistry {
           'unknown',
         transport_type: TransportType.MWP,
         sdk_version: connReq?.metadata?.sdk?.version,
-        sdk_platform: connReq?.metadata?.sdk?.platform,
+        remote_request_platform: connReq?.metadata?.sdk?.platform,
         failure_reason: error instanceof Error ? error.message : String(error),
       });