fix(social-ai): make back from notification-driven trader position behave naturally

When a TraderPositionView was opened from a notification, pressing back used
to slide TraderProfileView in from the right (a forward animation), because
handleBack fell back to navigation.replace.

Replace that fallback with a plain navigation.goBack() and stop trying to
synthesize a Profile underneath in the deeplink handler. Back now returns
to wherever the user was before opening the position:
- cold-start push:                Wallet Home
- in-app notification panel tap:  Notifications panel
- in-app row tap from Profile:    Profile (unchanged)

The trader's name in the position header remains the affordance for
navigating onward to the trader's Profile.

Also: assign the two social deeplink handlers to @MetaMask/social-ai in
CODEOWNERS.

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: xavier-brochard

.github/CODEOWNERS

@@ -217,6 +217,8 @@ app/core/Engine/messengers/social-controller-messenger*              @MetaMask/s
 app/core/Engine/messengers/social-service-messenger*                 @MetaMask/social-ai
 app/core/Engine/controllers/ai-digest-controller-init*               @MetaMask/social-ai
 app/core/Engine/messengers/ai-digest-controller-messenger*           @MetaMask/social-ai
+app/core/DeeplinkManager/handlers/legacy/handleSocialLeaderboardUrl.ts    @MetaMask/social-ai
+app/core/DeeplinkManager/handlers/legacy/handleSocialTraderPositionUrl.ts @MetaMask/social-ai
 app/selectors/featureFlagController/socialLeaderboard/               @MetaMask/social-ai
 app/selectors/featureFlagController/marketInsights/                  @MetaMask/social-ai
 app/selectors/featureFlagController/whatsHappening/                  @MetaMask/social-ai

app/components/Views/SocialLeaderboard/TraderPositionView/TraderPositionView.test.tsx

@@ -6,13 +6,10 @@ import TraderPositionView from './TraderPositionView';
 import { TraderPositionViewSelectorsIDs } from './TraderPositionView.testIds';
 import type { Position, Trade } from '@metamask/social-controllers';
 import { handleFetch } from '@metamask/controller-utils';
-import Routes from '../../../../constants/navigation/Routes';
 import ClipboardManager from '../../../../core/ClipboardManager';
 
 const mockGoBack = jest.fn();
 const mockNavigate = jest.fn();
-const mockReplace = jest.fn();
-const mockGetState = jest.fn();
 const mockGetAssetImageUrl = jest.fn();
 const mockHandleFetch = handleFetch as jest.MockedFunction<typeof handleFetch>;
 const mockPriceChart = jest.fn();
@@ -193,8 +190,6 @@ jest.mock('@react-navigation/native', () => {
     useNavigation: () => ({
       goBack: mockGoBack,
       navigate: mockNavigate,
-      replace: mockReplace,
-      getState: mockGetState,
     }),
     useRoute: () => ({
       params: mockRouteParams,
@@ -217,7 +212,6 @@ describe('TraderPositionView', () => {
     jest.clearAllMocks();
     mockRefetchPosition.mockResolvedValue(undefined);
     mockRefreshProfile.mockResolvedValue(undefined);
-    mockGetState.mockReturnValue({ routes: [{ name: 'Home' }], index: 0 });
     mockHandleFetch.mockResolvedValue({});
     global.fetch = jest.fn().mockResolvedValue({
       ok: true,
@@ -251,36 +245,7 @@ describe('TraderPositionView', () => {
     expect(screen.getByText('No trades for this interval')).toBeOnTheScreen();
   });
 
-  it('replaces the current screen with the trader profile when the back button is pressed and no profile is in the back stack (deeplink)', () => {
-    // default mockGetState has no profile route behind the position screen
-    renderWithProvider(<TraderPositionView />, { state: mockState });
-
-    fireEvent.press(
-      screen.getByTestId(TraderPositionViewSelectorsIDs.BACK_BUTTON),
-    );
-
-    expect(mockReplace).toHaveBeenCalledWith(
-      Routes.SOCIAL_LEADERBOARD.PROFILE,
-      {
-        traderId: 'trader-1',
-        traderName: 'dutchiono',
-      },
-    );
-    expect(mockNavigate).not.toHaveBeenCalled();
-    expect(mockGoBack).not.toHaveBeenCalled();
-  });
-
-  it('calls goBack when the back button is pressed and the trader profile is already in the stack', () => {
-    mockGetState.mockReturnValue({
-      routes: [
-        { name: 'Home' },
-        { name: Routes.SOCIAL_LEADERBOARD.VIEW },
-        { name: Routes.SOCIAL_LEADERBOARD.PROFILE },
-        { name: Routes.SOCIAL_LEADERBOARD.POSITION },
-      ],
-      index: 3,
-    });
-
+  it('calls goBack when the back button is pressed', () => {
     renderWithProvider(<TraderPositionView />, { state: mockState });
 
     fireEvent.press(
@@ -289,7 +254,6 @@ describe('TraderPositionView', () => {
 
     expect(mockGoBack).toHaveBeenCalledTimes(1);
     expect(mockNavigate).not.toHaveBeenCalled();
-    expect(mockReplace).not.toHaveBeenCalled();
   });
 
   it('renders the fallback when position is undefined and no positionId is provided', () => {

app/components/Views/SocialLeaderboard/TraderPositionView/TraderPositionView.tsx

@@ -23,7 +23,6 @@ import {
 } from '../../../../component-library/components/Toast';
 import { IconName as ComponentLibraryIconName } from '../../../../component-library/components/Icons/Icon';
 import ClipboardManager from '../../../../core/ClipboardManager';
-import Routes from '../../../../constants/navigation/Routes';
 import { TraderPositionViewSelectorsIDs } from './TraderPositionView.testIds';
 import { useTheme } from '../../../../util/theme';
 import QuickBuyBottomSheet from './components/QuickBuyBottomSheet';
@@ -114,22 +113,13 @@ const TraderPositionView = () => {
     }
   }, [refetchPosition, refreshProfile]);
 
+  // Plain goBack: returns to whatever the user was on before opening this
+  // screen — Profile (in-app row tap), Wallet Home (cold-start push), or the
+  // Notifications panel (in-app notification tap). The trader's name in the
+  // header is the affordance for navigating onward to Profile.
   const handleBack = useCallback(() => {
-    const state = navigation.getState();
-    const previousRoute = state?.routes[state.index - 1];
-
-    if (previousRoute?.name === Routes.SOCIAL_LEADERBOARD.PROFILE) {
-      // Normal flow: profile is already in the stack, goes back to it
-      navigation.goBack();
-    } else {
-      // Deeplink flow: position was opened directly. Replace position with
-      // profile so pressing back from profile doesn't return to position.
-      navigation.replace(Routes.SOCIAL_LEADERBOARD.PROFILE, {
-        traderId,
-        traderName,
-      });
-    }
-  }, [navigation, traderId, traderName]);
+    navigation.goBack();
+  }, [navigation]);
 
   const handleCopyTokenAddress = useCallback(async () => {
     if (!resolvedPosition?.tokenAddress) {

app/components/Views/SocialLeaderboard/TraderProfileView/TraderProfileView.tsx

@@ -1,44 +1,57 @@
-import React, { useCallback, useMemo, useRef, useState } from 'react';
-import { RefreshControl, TouchableOpacity } from 'react-native';
-import { ScrollView } from 'react-native-gesture-handler';
 import {
-  ImpactMoment,
-  playImpact,
-  playSelection,
-} from '../../../../util/haptics';
+  Box,
+  BoxAlignItems,
+  BoxFlexDirection,
+  BoxJustifyContent,
+  Button,
+  ButtonIcon,
+  ButtonIconSize,
+  ButtonVariant,
+  FontWeight,
+  IconName,
+  Text,
+  TextColor,
+  TextVariant,
+} from '@metamask/design-system-react-native';
+import { useTailwind } from '@metamask/design-system-twrnc-preset';
+import type { Position } from '@metamask/social-controllers';
 import {
   useNavigation,
   useRoute,
   type NavigationProp,
   type RouteProp,
 } from '@react-navigation/native';
-import type { RootStackParamList } from '../../../../core/NavigationService/types';
+import React, { useCallback, useMemo, useRef, useState } from 'react';
+import { RefreshControl, TouchableOpacity } from 'react-native';
+import { ScrollView } from 'react-native-gesture-handler';
 import { SafeAreaView } from 'react-native-safe-area-context';
-import { useTailwind } from '@metamask/design-system-twrnc-preset';
-import {
-  Box,
-  Text,
-  TextVariant,
-  TextColor,
-  FontWeight,
-  ButtonIcon,
-  ButtonIconSize,
-  IconName,
-  BoxFlexDirection,
-  BoxAlignItems,
-  BoxJustifyContent,
-  Button,
-  ButtonVariant,
-} from '@metamask/design-system-react-native';
 import { strings } from '../../../../../locales/i18n';
 import Routes from '../../../../constants/navigation/Routes';
+import type { RootStackParamList } from '../../../../core/NavigationService/types';
+import {
+  ImpactMoment,
+  playImpact,
+  playSelection,
+} from '../../../../util/haptics';
+import ErrorState from '../../Homepage/components/ErrorState/ErrorState';
+import { useNotificationPreferences } from '../NotificationPreferencesView/hooks';
 import { TraderProfileViewSelectorsIDs } from './TraderProfileView.testIds';
-import { useTraderProfile, useTraderPositions } from './hooks';
-import type { Position } from '@metamask/social-controllers';
-import ProfileHeader from './components/ProfileHeader';
-import StatsRow from './components/StatsRow';
 import PositionRow from './components/PositionRow';
+import ProfileHeader from './components/ProfileHeader';
+import {
+  PositionRowSkeleton,
+  ProfileHeaderSkeleton,
+  StatsRowSkeleton,
+} from './components/Skeletons';
 import SortButton from './components/SortButton';
+import StatsRow from './components/StatsRow';
+import TopTradersNotificationsSetupBottomSheet, {
+  type TopTradersNotificationsSetupBottomSheetRef,
+} from './components/TopTradersNotificationsSetupBottomSheet';
+import TraderNotificationsBottomSheet, {
+  type TraderNotificationsBottomSheetRef,
+} from './components/TraderNotificationsBottomSheet';
+import { useTraderPositions, useTraderProfile } from './hooks';
 import {
   CLOSED_SORT_CYCLE,
   OPEN_SORT_CYCLE,
@@ -47,19 +60,6 @@ import {
   type OpenSortKey,
   type SortKey,
 } from './utils/sortPositions';
-import {
-  ProfileHeaderSkeleton,
-  StatsRowSkeleton,
-  PositionRowSkeleton,
-} from './components/Skeletons';
-import ErrorState from '../../Homepage/components/ErrorState/ErrorState';
-import { useNotificationPreferences } from '../NotificationPreferencesView/hooks';
-import TraderNotificationsBottomSheet, {
-  type TraderNotificationsBottomSheetRef,
-} from './components/TraderNotificationsBottomSheet';
-import TopTradersNotificationsSetupBottomSheet, {
-  type TopTradersNotificationsSetupBottomSheetRef,
-} from './components/TopTradersNotificationsSetupBottomSheet';
 
 const POSITION_SKELETON_COUNT = 4;
 const POSITION_SKELETON_KEYS = Array.from(

app/core/DeeplinkManager/handlers/legacy/__tests__/handleSocialTraderPositionUrl.test.ts

@@ -39,6 +39,7 @@ describe('handleSocialTraderPositionUrl', () => {
         '?positionId=92d9001b-8b64-4b13-9c1b-ba9292a6099a&traderId=trader-1&deduplication_id=dedup-1&notification_event=follow_newtrade_buy',
     });
 
+    expect(mockNavigate).toHaveBeenCalledTimes(1);
     expect(mockNavigate).toHaveBeenCalledWith(
       Routes.SOCIAL_LEADERBOARD.POSITION,
       {
@@ -53,6 +54,7 @@ describe('handleSocialTraderPositionUrl', () => {
       actionPath: '?positionId=position-1&traderId=trader-1',
     });
 
+    expect(mockNavigate).toHaveBeenCalledTimes(1);
     expect(mockNavigate).toHaveBeenCalledWith(
       Routes.SOCIAL_LEADERBOARD.POSITION,
       {

app/core/DeeplinkManager/handlers/legacy/handleSocialTraderPositionUrl.ts

@@ -81,6 +81,12 @@ export const handleSocialTraderPositionUrl = ({
       );
     }
 
+    // Push Position on top of whatever the user was on. Back returns there:
+    // - cold-start push: returns to Wallet Home (the app's initial route).
+    // - in-app notification tap: returns to the Notifications panel.
+    // - row tap from Profile (in-app): returns to Profile.
+    // The trader's name in the position header is the affordance for
+    // navigating onward to the trader's Profile.
     NavigationService.navigation.navigate(Routes.SOCIAL_LEADERBOARD.POSITION, {
       positionId,
       traderId,