Commit 6e61412
authored
revert: swaps new slippage modal (#25394)
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->
## **Description**
Reverts #25124
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
AI agent: Be specific about what you changed and why. Include context
about the fix/feature, not generic descriptions.
-->
## **Changelog**
<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`
If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`
(This helps the Release Engineer do their job more quickly and
accurately)
AI agent: Use format `CHANGELOG entry: [fix/feat/chore]: [User-facing
description in past tense]`.
Examples: `fix: resolved token name display issue`, `feat: added dark
mode toggle`, `chore: updated dependencies`.
For non-user-facing changes, use `CHANGELOG entry: null`.
-->
CHANGELOG entry: null
## **Related issues**
<!--
AI agent: Replace with `Fixes: #[ISSUE_NUMBER]` using the actual issue
number you're implementing.
-->
Fixes: https://consensyssoftware.atlassian.net/browse/SWAPS-3428
## **Manual testing steps**
<!--
AI agent: Write specific, contextual Gherkin steps based on what you
actually implemented.
Do NOT use generic placeholders like "my feature name". Be concrete
about the feature, scenario, and steps.
-->
```gherkin
Ensure functionality matches signed-off acceptance criteria.
```
## **Screenshots/Recordings**
<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->
### **Before**
<!-- [screenshots/recordings] -->
### **After**
<!-- [screenshots/recordings] -->
## **Pre-merge author checklist**
<!--
AI agent: Check ALL boxes in this section (mark all as [x]).
-->
- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I've included tests if applicable
- [x] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
## **Pre-merge reviewer checklist**
<!--
AI agent: Leave ALL boxes unchecked ([ ]) - these are for reviewers to
check, not the author.
-->
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
> [!NOTE]
> **Medium Risk**
> Medium risk because it changes the Bridge slippage configuration UX
and navigation targets, removing the custom/default slippage modal flow
and associated validation/controls which could impact users’ ability to
set slippage correctly.
>
> **Overview**
> Reverts the newer Bridge slippage UI by deleting the `InputStepper`
component (and its snapshots/tests) and removing the
`DefaultSlippageModal`, `CustomSlippageModal`, and
`DefaultSlippageButtonGroup` implementations and tests.
>
> Updates `QuoteDetailsCard` to navigate to
`Routes.BRIDGE.MODALS.SLIPPAGE_MODAL` (dropping the previous
`DEFAULT_SLIPPAGE_MODAL` + `network` params), and adds new
`SlippageModal` styling/types plus a focused `SlippageModal.test.tsx` to
cover option selection and applying (dispatching `setSlippage`).
>
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
e691a98. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->1 parent 52d2ff9 commit 6e61412
50 files changed
Lines changed: 883 additions & 21698 deletions
File tree
- app
- components/UI/Bridge
- components
- InputStepper
- __snapshots__
- QuoteDetailsCard
- SlippageModal
- __snapshots__
- TokenInputArea
- hooks
- useGetSlippageOptions
- __snapshots__
- useShouldDisableCustomSlippageConfirm
- useSlippageConfig
- __snapshots__
- useSlippageStepperDescription
- __snapshots__
- utils
- core
- locales/languages
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
Lines changed: 0 additions & 326 deletions
This file was deleted.
Lines changed: 0 additions & 51 deletions
This file was deleted.
0 commit comments