Commit 73a4e87
authored
chore: update @metamask/transaction-pay-controller (#29302)
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until this PR meets the canonical
Definition of Ready For Review in `docs/readme/ready-for-review.md`.
In short: the template must be materially complete (not just section
titles
present), all status checks must be currently passing, and the only
expected
follow-up commits must be reviewer-driven.
-->
## **Description**
Update @metamask/transaction-pay-controller, to add change to
accountOverride property.
## **Changelog**
<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`
If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`
(This helps the Release Engineer do their job more quickly and
accurately)
-->
CHANGELOG entry:
## **Related issues**
Ref: https://consensyssoftware.atlassian.net/browse/CONF-1187
## **Manual testing steps**
```gherkin
Feature: my feature name
Scenario: user [verb for user action]
Given [describe expected initial app state]
When user [verb for user action]
Then [describe expected outcome]
```
## **Screenshots/Recordings**
NA
## **Pre-merge author checklist**
<!--
Every checklist item must be consciously assessed before marking this PR
as
"Ready for review". A checked box means you deliberately considered that
responsibility, not that you literally performed every action listed.
Unchecked boxes are ambiguous: they are not an implicit "N/A" and they
are not
a silent "skip". See `docs/readme/ready-for-review.md` for the full
checklist
semantics.
-->
- [X] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [X] I've completed the PR template to the best of my ability
- [X] I've included tests if applicable
- [X] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [X] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
#### Performance checks (if applicable)
- [ ] I've tested on Android
- Ideally on a mid-range device; emulator is acceptable
- [ ] I've tested with a power user scenario
- Use these [power-user
SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93)
to import wallets with many accounts and tokens
- [ ] I've instrumented key operations with Sentry traces for production
performance metrics
- See [`trace()`](/app/util/trace.ts) for usage and
[`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274)
for an example
For performance guidelines and tooling, see the [Performance
Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers).
## **Pre-merge reviewer checklist**
<!--
Reviewer checklist items follow the same semantics as the author
checklist: an
unchecked box is ambiguous, a checked box means the reviewer consciously
assessed that responsibility. See `docs/readme/ready-for-review.md`.
-->
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Medium Risk**
> Dependency bumps pull in newer `@metamask/*` controller and keyring
packages, which can subtly change transaction/payment and bridge
behavior at runtime. App code changes are minimal, but
lockfile/resolution shifts increase integration/regression risk.
>
> **Overview**
> Upgrades `@metamask/transaction-pay-controller` to `^19.3.0` and
updates the lockfile/resolutions to align on newer `@metamask/*`
packages (notably `@metamask/keyring-api` `23.0.1`, plus related
bridge/assets/keyring client/internal deps).
>
> Updates `accountsControllerTestUtils.ts` to recognize Stellar
(`XlmAccountType.Account` -> `XlmScope.Pubnet`) when generating mock
account scopes.
>
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
e677792. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->1 parent 4ab229b commit 73a4e87
3 files changed
Lines changed: 95 additions & 56 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| 17 | + | |
| 18 | + | |
17 | 19 | | |
18 | 20 | | |
19 | 21 | | |
| |||
69 | 71 | | |
70 | 72 | | |
71 | 73 | | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
72 | 77 | | |
73 | 78 | | |
74 | 79 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
204 | 204 | | |
205 | 205 | | |
206 | 206 | | |
207 | | - | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
208 | 214 | | |
209 | 215 | | |
210 | 216 | | |
| |||
333 | 339 | | |
334 | 340 | | |
335 | 341 | | |
336 | | - | |
| 342 | + | |
337 | 343 | | |
338 | 344 | | |
339 | 345 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7742 | 7742 | | |
7743 | 7743 | | |
7744 | 7744 | | |
7745 | | - | |
7746 | | - | |
| 7745 | + | |
| 7746 | + | |
7747 | 7747 | | |
7748 | | - | |
| 7748 | + | |
7749 | 7749 | | |
7750 | 7750 | | |
7751 | | - | |
| 7751 | + | |
7752 | 7752 | | |
7753 | 7753 | | |
7754 | 7754 | | |
| |||
7885 | 7885 | | |
7886 | 7886 | | |
7887 | 7887 | | |
7888 | | - | |
7889 | | - | |
7890 | | - | |
| 7888 | + | |
| 7889 | + | |
| 7890 | + | |
7891 | 7891 | | |
7892 | 7892 | | |
7893 | 7893 | | |
7894 | 7894 | | |
7895 | 7895 | | |
7896 | 7896 | | |
7897 | | - | |
| 7897 | + | |
7898 | 7898 | | |
7899 | 7899 | | |
7900 | 7900 | | |
7901 | 7901 | | |
7902 | | - | |
| 7902 | + | |
7903 | 7903 | | |
7904 | | - | |
7905 | | - | |
| 7904 | + | |
| 7905 | + | |
7906 | 7906 | | |
7907 | 7907 | | |
7908 | 7908 | | |
| |||
7912 | 7912 | | |
7913 | 7913 | | |
7914 | 7914 | | |
7915 | | - | |
| 7915 | + | |
7916 | 7916 | | |
7917 | 7917 | | |
7918 | 7918 | | |
7919 | 7919 | | |
7920 | 7920 | | |
7921 | | - | |
| 7921 | + | |
7922 | 7922 | | |
7923 | 7923 | | |
7924 | 7924 | | |
7925 | | - | |
7926 | | - | |
7927 | | - | |
| 7925 | + | |
| 7926 | + | |
| 7927 | + | |
7928 | 7928 | | |
7929 | 7929 | | |
7930 | 7930 | | |
| |||
7974 | 7974 | | |
7975 | 7975 | | |
7976 | 7976 | | |
7977 | | - | |
| 7977 | + | |
7978 | 7978 | | |
7979 | 7979 | | |
7980 | 7980 | | |
| |||
8073 | 8073 | | |
8074 | 8074 | | |
8075 | 8075 | | |
8076 | | - | |
8077 | | - | |
8078 | | - | |
| 8076 | + | |
| 8077 | + | |
| 8078 | + | |
8079 | 8079 | | |
8080 | 8080 | | |
8081 | 8081 | | |
8082 | 8082 | | |
8083 | 8083 | | |
8084 | 8084 | | |
8085 | 8085 | | |
8086 | | - | |
8087 | | - | |
| 8086 | + | |
| 8087 | + | |
8088 | 8088 | | |
8089 | 8089 | | |
8090 | 8090 | | |
8091 | | - | |
| 8091 | + | |
8092 | 8092 | | |
8093 | 8093 | | |
8094 | 8094 | | |
| |||
8097 | 8097 | | |
8098 | 8098 | | |
8099 | 8099 | | |
8100 | | - | |
| 8100 | + | |
8101 | 8101 | | |
8102 | 8102 | | |
8103 | 8103 | | |
8104 | 8104 | | |
8105 | | - | |
| 8105 | + | |
8106 | 8106 | | |
8107 | 8107 | | |
8108 | 8108 | | |
8109 | | - | |
| 8109 | + | |
8110 | 8110 | | |
8111 | 8111 | | |
8112 | 8112 | | |
| |||
8130 | 8130 | | |
8131 | 8131 | | |
8132 | 8132 | | |
| 8133 | + | |
| 8134 | + | |
| 8135 | + | |
| 8136 | + | |
| 8137 | + | |
| 8138 | + | |
| 8139 | + | |
| 8140 | + | |
| 8141 | + | |
| 8142 | + | |
| 8143 | + | |
| 8144 | + | |
| 8145 | + | |
| 8146 | + | |
| 8147 | + | |
| 8148 | + | |
| 8149 | + | |
| 8150 | + | |
| 8151 | + | |
| 8152 | + | |
| 8153 | + | |
| 8154 | + | |
| 8155 | + | |
| 8156 | + | |
8133 | 8157 | | |
8134 | 8158 | | |
8135 | 8159 | | |
| |||
8925 | 8949 | | |
8926 | 8950 | | |
8927 | 8951 | | |
8928 | | - | |
| 8952 | + | |
8929 | 8953 | | |
8930 | 8954 | | |
8931 | 8955 | | |
| |||
8942 | 8966 | | |
8943 | 8967 | | |
8944 | 8968 | | |
8945 | | - | |
8946 | | - | |
8947 | | - | |
8948 | | - | |
8949 | | - | |
8950 | | - | |
8951 | | - | |
8952 | | - | |
8953 | | - | |
8954 | | - | |
8955 | | - | |
8956 | | - | |
8957 | | - | |
| 8969 | + | |
8958 | 8970 | | |
8959 | 8971 | | |
8960 | 8972 | | |
| |||
8989 | 9001 | | |
8990 | 9002 | | |
8991 | 9003 | | |
8992 | | - | |
8993 | | - | |
8994 | | - | |
| 9004 | + | |
| 9005 | + | |
| 9006 | + | |
8995 | 9007 | | |
8996 | | - | |
| 9008 | + | |
8997 | 9009 | | |
8998 | 9010 | | |
8999 | | - | |
| 9011 | + | |
9000 | 9012 | | |
9001 | 9013 | | |
9002 | 9014 | | |
| |||
9047 | 9059 | | |
9048 | 9060 | | |
9049 | 9061 | | |
| 9062 | + | |
| 9063 | + | |
| 9064 | + | |
| 9065 | + | |
| 9066 | + | |
| 9067 | + | |
| 9068 | + | |
| 9069 | + | |
| 9070 | + | |
| 9071 | + | |
| 9072 | + | |
| 9073 | + | |
| 9074 | + | |
| 9075 | + | |
| 9076 | + | |
| 9077 | + | |
9050 | 9078 | | |
9051 | 9079 | | |
9052 | 9080 | | |
| |||
10325 | 10353 | | |
10326 | 10354 | | |
10327 | 10355 | | |
10328 | | - | |
10329 | | - | |
10330 | | - | |
| 10356 | + | |
| 10357 | + | |
| 10358 | + | |
10331 | 10359 | | |
10332 | 10360 | | |
10333 | 10361 | | |
10334 | 10362 | | |
10335 | | - | |
10336 | | - | |
| 10363 | + | |
| 10364 | + | |
10337 | 10365 | | |
10338 | | - | |
10339 | | - | |
| 10366 | + | |
| 10367 | + | |
10340 | 10368 | | |
10341 | 10369 | | |
10342 | 10370 | | |
| |||
10350 | 10378 | | |
10351 | 10379 | | |
10352 | 10380 | | |
10353 | | - | |
| 10381 | + | |
10354 | 10382 | | |
10355 | 10383 | | |
10356 | 10384 | | |
| |||
35957 | 35985 | | |
35958 | 35986 | | |
35959 | 35987 | | |
35960 | | - | |
| 35988 | + | |
35961 | 35989 | | |
35962 | 35990 | | |
35963 | 35991 | | |
| |||
0 commit comments