Skip to content

Commit 7418947

Browse files
chore: bump ramps-controller to 13.2.0 (#28879)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Bumps `@metamask/ramps-controller` from `^13.1.0` to `^13.2.0` to pick up the `TransakService.verifyUserOtp` no-retry policy fix (TRAM-3442). **What changed in ramps-controller 13.2.0:** - **Fixed** — `TransakService.verifyUserOtp` no longer retries on failure, preventing single-use OTP attempts from being silently consumed when consumers configure a non-zero `maxRetries` in `policyOptions` ([core#8468](MetaMask/core#8468)) - **Changed** — Bump `@metamask/base-controller` from `^9.0.1` to `^9.1.0` ([core#8457](MetaMask/core#8457)) **Core release PR:** MetaMask/core#8476 **Scope of this PR:** bumps the `@metamask/ramps-controller` dependency version in `package.json`. No mobile source code changes. ## **Changelog** CHANGELOG entry: null ## **Related issues** Fixes: [TRAM-3442](https://consensyssoftware.atlassian.net/browse/TRAM-3442) ## **Manual testing steps** ```gherkin Feature: OTP verification no-retry policy Scenario: user enters an invalid OTP during Transak onramp Given user has initiated a Transak fiat-to-crypto purchase And user has received an OTP via SMS/email When user enters an incorrect OTP code Then the app surfaces the verification failure immediately And no automatic retry is performed against the Transak API And the user's remaining OTP attempt count decrements by exactly one Scenario: user enters a valid OTP during Transak onramp Given user has initiated a Transak fiat-to-crypto purchase And user has received an OTP via SMS/email When user enters the correct OTP code Then verification succeeds on the first attempt And the onramp flow proceeds to the next step ``` ## **Screenshots/Recordings** N/A — dependency bump only, no UI changes. ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable — N/A, dependency bump only - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable — N/A - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. [TRAM-3442]: https://consensyssoftware.atlassian.net/browse/TRAM-3442?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Dependency-only change, but it impacts the fiat ramps stack; behavior changes in the controller could affect onramp/offramp flows and should be smoke-tested. > > **Overview** > Updates the `@metamask/ramps-controller` dependency from `^13.1.0` to `^13.2.0`. > > Regenerates `yarn.lock` to pull in `@metamask/ramps-controller@13.2.0` and its updated transitive deps (notably `@metamask/base-controller@9.1.0` / `@metamask/messenger@^1.1.1`), with no application source changes. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 9ea81a7. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Darius Costolas <10818970+meltingice1337@users.noreply.github.com> Co-authored-by: Amitabh Aggarwal <aggarwal.amitabh@gmail.com>
1 parent ff903fd commit 7418947

2 files changed

Lines changed: 12 additions & 12 deletions

File tree

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,7 @@
293293
"@metamask/preinstalled-example-snap": "^0.7.2",
294294
"@metamask/profile-metrics-controller": "^3.1.0",
295295
"@metamask/profile-sync-controller": "^28.0.2",
296-
"@metamask/ramps-controller": "^13.1.0",
296+
"@metamask/ramps-controller": "^13.2.0",
297297
"@metamask/react-data-query": "^0.2.0",
298298
"@metamask/react-native-acm": "1.2.0",
299299
"@metamask/react-native-actionsheet": "2.4.2",

yarn.lock

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -8099,14 +8099,14 @@ __metadata:
80998099
languageName: node
81008100
linkType: hard
81018101

8102-
"@metamask/base-controller@npm:^9.0.0, @metamask/base-controller@npm:^9.0.1":
8103-
version: 9.0.1
8104-
resolution: "@metamask/base-controller@npm:9.0.1"
8102+
"@metamask/base-controller@npm:^9.0.0, @metamask/base-controller@npm:^9.0.1, @metamask/base-controller@npm:^9.1.0":
8103+
version: 9.1.0
8104+
resolution: "@metamask/base-controller@npm:9.1.0"
81058105
dependencies:
8106-
"@metamask/messenger": "npm:^1.0.0"
8106+
"@metamask/messenger": "npm:^1.1.1"
81078107
"@metamask/utils": "npm:^11.9.0"
81088108
immer: "npm:^9.0.6"
8109-
checksum: 10/bc5052c9a38c21a52003e9a79de1f609ff127d939c87eb7b9ebe01cdf05ce2a9ee8e4635dd96f193e9951983e9554d9381af303fbadaae740445ffb2424698e8
8109+
checksum: 10/752b70b35026fdf31ea8feef638f06286dbbde8d17e1ba804085fdbedbb076d900d2d7b6db3d2af284b3aa8fa84c95a0ceea6a3a46ee7b7e29433f037e9afc69
81108110
languageName: node
81118111
linkType: hard
81128112

@@ -9678,14 +9678,14 @@ __metadata:
96789678
languageName: node
96799679
linkType: hard
96809680

9681-
"@metamask/ramps-controller@npm:^13.1.0":
9682-
version: 13.1.0
9683-
resolution: "@metamask/ramps-controller@npm:13.1.0"
9681+
"@metamask/ramps-controller@npm:^13.1.0, @metamask/ramps-controller@npm:^13.2.0":
9682+
version: 13.2.0
9683+
resolution: "@metamask/ramps-controller@npm:13.2.0"
96849684
dependencies:
9685-
"@metamask/base-controller": "npm:^9.0.1"
9685+
"@metamask/base-controller": "npm:^9.1.0"
96869686
"@metamask/controller-utils": "npm:^11.20.0"
96879687
"@metamask/messenger": "npm:^1.1.1"
9688-
checksum: 10/e2994b535470794109322025d0414347577cf116109206fadd449af805dcba4ffc5f12352c0576b09aefefb044e789dc227980652d830b4ee36a9785de2350cf
9688+
checksum: 10/17ce6e74c5a2894c7fbe3ee3a6c39cd820212de04a7dda86324293f9f09fdf03e9ccc11d9d29cd7131f01ec62073eb4cc8e7cb321de40c956bb52b1dce774f95
96899689
languageName: node
96909690
linkType: hard
96919691

@@ -35917,7 +35917,7 @@ __metadata:
3591735917
"@metamask/profile-metrics-controller": "npm:^3.1.0"
3591835918
"@metamask/profile-sync-controller": "npm:^28.0.2"
3591935919
"@metamask/providers": "npm:^18.3.1"
35920-
"@metamask/ramps-controller": "npm:^13.1.0"
35920+
"@metamask/ramps-controller": "npm:^13.2.0"
3592135921
"@metamask/react-data-query": "npm:^0.2.0"
3592235922
"@metamask/react-native-acm": "npm:1.2.0"
3592335923
"@metamask/react-native-actionsheet": "npm:2.4.2"

0 commit comments

Comments
 (0)