refactor: enhance skill logging in hook-cursor-prompt-dispatch.sh and update test environment variables

- Updated the skill logging guard in `hook-cursor-prompt-dispatch.sh` to allow overriding the repository root for testing purposes.
- Modified test cases in `hook-dispatchers.test.ts` to use the new `TOOL_USAGE_REPO_ROOT` environment variable instead of `GIT_DIR`, improving test isolation and flexibility.

Author: NicolasMassart

scripts/tooling/hook-cursor-prompt-dispatch.sh

@@ -19,8 +19,9 @@ _skill_name=$(printf '%s' "$_payload" \
 
 [ -z "${_skill_name:-}" ] && exit 0
 
-# Only log skills shipped in this repo
-_repo_root=$(git rev-parse --show-toplevel 2>/dev/null)
+# Only log skills shipped in this repo.
+# TOOL_USAGE_REPO_ROOT can be overridden in tests to avoid a real git lookup.
+_repo_root="${TOOL_USAGE_REPO_ROOT:-$(git rev-parse --show-toplevel 2>/dev/null)}"
 _is_known_skill=0
 for _dir in \
   "${_repo_root}/.claude/skills" \

scripts/tooling/hook-dispatchers.test.ts

@@ -303,10 +303,9 @@ describe('Cursor slash command prompt payload', () => {
     runDispatcher(CURSOR_PROMPT_DISPATCHER, {
       stdin: slashCommandPayload,
       env: {
-        CI: '',                                   // opt-in to collection
-        HOME: tmpDir,                             // resolve SKILL.md via the stub created in beforeEach
-        GIT_DIR: '/dev/null',                     // prevent git rev-parse from resolving the real repo root
-        TOOL_USAGE_COLLECTION_LOG_PATH: logFile,  // write to the per-test temp file
+        CI: '',                                        // opt-in to collection
+        TOOL_USAGE_REPO_ROOT: tmpDir,                  // resolve SKILL.md via the stub created in beforeEach
+        TOOL_USAGE_COLLECTION_LOG_PATH: logFile,       // write to the per-test temp file
       },
     });
 
@@ -328,10 +327,9 @@ describe('Cursor slash command prompt payload', () => {
     const result = runDispatcher(CURSOR_PROMPT_DISPATCHER, {
       stdin: JSON.stringify({ prompt: '/totally-fake-skill', session_id: 's' }),
       env: {
-        CI: '',                                   // opt-in to collection
-        HOME: tmpDir,                             // resolve SKILL.md via the stub created in beforeEach
-        GIT_DIR: '/dev/null',                     // prevent git rev-parse from resolving the real repo root
-        TOOL_USAGE_COLLECTION_LOG_PATH: logFile,  // write to the per-test temp file
+        CI: '',                                        // opt-in to collection
+        TOOL_USAGE_REPO_ROOT: tmpDir,                  // resolve SKILL.md via the stub created in beforeEach
+        TOOL_USAGE_COLLECTION_LOG_PATH: logFile,       // write to the per-test temp file
       },
     });
     expect(result.stdout.trim()).toBe('{"permission":"allow"}');
@@ -366,10 +364,9 @@ describe('Cursor slash command prompt payload', () => {
     runDispatcher(CURSOR_PROMPT_DISPATCHER, {
       stdin: slashCommandPayload,
       env: {
-        CI: '',                                   // opt-in to collection
-        HOME: tmpDir,                             // resolve SKILL.md via the stub created in beforeEach
-        GIT_DIR: '/dev/null',                     // prevent git rev-parse from resolving the real repo root
-        TOOL_USAGE_COLLECTION_LOG_PATH: logFile,  // write to the per-test temp file
+        CI: '',                                        // opt-in to collection
+        TOOL_USAGE_REPO_ROOT: tmpDir,                  // resolve SKILL.md via the stub created in beforeEach
+        TOOL_USAGE_COLLECTION_LOG_PATH: logFile,       // write to the per-test temp file
       },
     });