Skip to content

Commit 79d4322

Browse files
authored
fix: expand excluded tags for AI selection (#24561)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Expand the list of excluded tags for AI selection to include additional broken tests. This change improves the accuracy of AI test selection by ensuring that more broken tests are excluded. - Added unmocked hyperliquid url to stop tests failing ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: ## **Related issues** Fixes: ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Broadens AI-driven E2E tag filtering and updates mock allowlist. > > - Expands `EXCLUDED_TAGS` in `e2e/tools/e2e-ai-analyzer/modes/select-tags/handlers.ts` to omit additional broken smoke tags (`SmokeWalletUX`, `SmokeAssets`, `SmokeStake`, `SmokeNotifications`, `SmokeMultiChainPermissions`, `SmokeAnalytics`). > - Adds `https://api.hyperliquid.xyz/info` to `ALLOWLISTED_URLS` in `e2e/api-mocking/mock-e2e-allowlist.ts` alongside the existing Hyperliquid `exchange` endpoint. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 8188990. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent e06cdc1 commit 79d4322

2 files changed

Lines changed: 12 additions & 1 deletion

File tree

e2e/api-mocking/mock-e2e-allowlist.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,4 +52,5 @@ export const ALLOWLISTED_URLS = [
5252
'https://signature-insights.api.cx.metamask.io/v1/signature?chainId=0x1',
5353
'https://price.api.cx.metamask.io/v1/exchange-rates?baseCurrency=usd',
5454
'https://api.hyperliquid.xyz/exchange',
55+
'https://api.hyperliquid.xyz/info',
5556
];

e2e/tools/e2e-ai-analyzer/modes/select-tags/handlers.ts

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,17 @@ import { smokeTags, flaskTags } from '../../../../tags';
99
/**
1010
* Tags to exclude from AI selection (broken/disabled tests)
1111
*/
12-
const EXCLUDED_TAGS = ['SmokeSwaps', 'SmokeMultiChainAPI', 'SmokeCore'];
12+
const EXCLUDED_TAGS = [
13+
'SmokeSwaps',
14+
'SmokeMultiChainAPI',
15+
'SmokeCore',
16+
'SmokeWalletUX',
17+
'SmokeAssets',
18+
'SmokeStake',
19+
'SmokeNotifications',
20+
'SmokeMultiChainPermissions',
21+
'SmokeAnalytics',
22+
];
1323

1424
/**
1525
* Derive AI config from smokeTags and flaskTags

0 commit comments

Comments
 (0)