Skip to content

Commit 7e9d0bc

Browse files
committed
Address ScreenView tyscript issue, remove prettier write from commit validator, adding a ts-expect-error to a bridge file that uses transition style and it is not supported by react native
1 parent bdb6942 commit 7e9d0bc

4 files changed

Lines changed: 14 additions & 6 deletions

File tree

app/components/Base/ScreenView.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,11 @@ const createStyles = (colors: ThemeColors) =>
1111
},
1212
});
1313

14-
const ScreenView: React.FC = (props) => {
14+
interface ScreenViewProps {
15+
children: React.ReactNode;
16+
}
17+
18+
const ScreenView: React.FC<ScreenViewProps> = (props) => {
1519
const { colors } = useTheme();
1620
const styles = createStyles(colors);
1721

app/components/UI/Bridge/Views/BridgeView/__snapshots__/BridgeView.test.tsx.snap

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,14 +150,21 @@ exports[`BridgeView renders 1`] = `
150150
"top": -1,
151151
}
152152
}
153+
onGestureCancel={[Function]}
153154
pointerEvents="box-none"
155+
sheetAllowedDetents="large"
156+
sheetCornerRadius={-1}
157+
sheetExpandsWhenScrolledToEdge={true}
158+
sheetGrabberVisible={false}
159+
sheetLargestUndimmedDetent="all"
154160
style={
155161
{
156162
"bottom": 0,
157163
"left": 0,
158164
"position": "absolute",
159165
"right": 0,
160166
"top": 0,
167+
"zIndex": undefined,
161168
}
162169
}
163170
>

app/components/UI/Bridge/components/TransactionDetails/Segment.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ const getSegmentStyle = (type: StatusTypes | null) =>
1414
height: 4,
1515
width: 0,
1616
borderRadius: 9999,
17+
// @ts-expect-error - bridge team needs to fix this with animated api since transition does not exist in react native
1718
transition: 'width 1.5s cubic-bezier(0.68, -0.55, 0.27, 1.55)',
1819
...(type === StatusTypes.PENDING && { width: '50%' }),
1920
...(type === StatusTypes.COMPLETE && { width: '100%' }),

package.json

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -99,11 +99,7 @@
9999
},
100100
"lint-staged": {
101101
"*.{js,jsx,ts,tsx}": [
102-
"prettier --write",
103102
"eslint"
104-
],
105-
"*.json": [
106-
"prettier --write"
107103
]
108104
},
109105
"resolutions": {
@@ -634,4 +630,4 @@
634630
}
635631
},
636632
"packageManager": "yarn@1.22.22"
637-
}
633+
}

0 commit comments

Comments
 (0)