fix: cp-7.65.0 totals in MUSD conversion using max button (#26029)

## **Description**

Cherry-pick #26015 into `7.65.0` release.

Applies a Yarn patch to `@metamask/transaction-pay-controller` instead
of bumping controller version to avoid unrelated changes.

## **Changelog**

CHANGELOG entry: null

## **Related issues**

Fixes: #25972 

## **Manual testing steps**

## **Screenshots/Recordings**

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I've included tests if applicable
- [x] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Touches transaction-pay quoting/totals and stablecoin detection, which
can affect displayed costs and max-amount behavior across networks;
mitigated by being a targeted patch and limited app-side changes.
> 
> **Overview**
> Fixes transaction pay quote/total calculations by **patching
`@metamask/transaction-pay-controller` 12.1.0** rather than bumping the
dependency.
> 
> The patch centralizes a multi-chain `STABLECOINS` list, treats
stablecoins as $1 in token fiat-rate logic, and changes `targetAmount`
across quotes/totals to be a `FiatValue` summed via `sumFiat` (avoiding
incorrect max/totals math). Relay quote normalization now accounts for
`fees.subsidized` by zeroing provider fees when subsidized and
optionally including the subsidized amount in the computed target fiat
value; Bridge normalization aligns `targetAmount` to fiat-only as well.
> 
> On the mobile side, `useTokenFiatRates` now uses a stablecoin
allowlist (Mainnet/Arbitrum/Linea/Polygon) to return a fixed USD rate of
`1`, and the related unit test is generalized accordingly. The
Transaction Pay controller messenger drops the unused
`TokenListController:getState` action, and `package.json`/`yarn.lock`
are updated to consume the patched controller via Yarn’s `patch:`
protocol.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
61d257e. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Author: matthewwalsh0

.yarn/patches/@metamask-transaction-pay-controller-npm-12.1.0-226665ee88.patch

@@ -2,8 +2,6 @@ import { CHAIN_IDS } from '@metamask/transaction-controller';
 import { backgroundState } from '../../../../../util/test/initial-root-state';
 import { renderHookWithProvider } from '../../../../../util/test/renderWithProvider';
 import { TokenFiatRateRequest, useTokenFiatRates } from './useTokenFiatRates';
-import { ARBITRUM_USDC } from '../../constants/perps';
-import { POLYGON_USDCE } from '../../constants/predict';
 
 jest.mock('../../../../../util/address', () => ({
   toChecksumAddress: jest.fn((address) => address),
@@ -107,11 +105,11 @@ describe('useTokenFiatRates', () => {
     expect(result).toEqual([CONVERSION_RATE_1_MOCK]);
   });
 
-  it('returns fixed exchange rate if Arbitrum USDC and selected currency is USD', () => {
+  it('returns fixed exchange rate for stablecoin when currency is USD', () => {
     const result = runHook({
       requests: [
         {
-          address: ARBITRUM_USDC.address,
+          address: '0xaf88d065e77c8cc2239327c5edb3a432268e5831',
           chainId: CHAIN_IDS.ARBITRUM,
           currency: 'usd',
         },
@@ -121,20 +119,6 @@ describe('useTokenFiatRates', () => {
     expect(result).toEqual([1]);
   });
 
-  it('returns fixed exchange rate if Polygon USDCE and selected currency is USD', () => {
-    const result = runHook({
-      requests: [
-        {
-          address: POLYGON_USDCE.address,
-          chainId: CHAIN_IDS.POLYGON,
-          currency: 'usd',
-        },
-      ],
-    });
-
-    expect(result).toEqual([1]);
-  });
-
   it('returns USD conversion rates if currency is USD', () => {
     const result = runHook({
       requests: [

app/components/Views/confirmations/hooks/tokens/useTokenFiatRates.test.ts

@@ -10,8 +10,26 @@ import { useMemo } from 'react';
 import { useDeepMemo } from '../useDeepMemo';
 import { toChecksumAddress } from '../../../../../util/address';
 import { CHAIN_IDS } from '@metamask/transaction-controller';
-import { ARBITRUM_USDC } from '../../constants/perps';
-import { POLYGON_USDCE } from '../../constants/predict';
+
+// Pending conversion to a remote feature flag
+const STABLECOINS: Record<Hex, Hex[]> = {
+  [CHAIN_IDS.MAINNET]: [
+    '0xaca92e438df0b2401ff60da7e4337b687a2435da', // MUSD
+    '0xa0b86991c6218b36c1d19d4a2e9eb0ce3606eb48', // USDC
+    '0xdac17f958d2ee523a2206206994597c13d831ec7', // USDT
+  ],
+  [CHAIN_IDS.ARBITRUM]: [
+    '0xaf88d065e77c8cc2239327c5edb3a432268e5831', // USDC
+  ],
+  [CHAIN_IDS.LINEA_MAINNET]: [
+    '0xaca92e438df0b2401ff60da7e4337b687a2435da', // MUSD
+    '0x176211869ca2b568f2a7d4ee941e073a821ee1ff', // USDC
+    '0xa219439258ca9da29e9cc4ce5596924745e12b93', // USDT
+  ],
+  [CHAIN_IDS.POLYGON]: [
+    '0x2791bca1f2de4661ed88a30c99a7a9449aa84174', // USDC.e
+  ],
+};
 
 export interface TokenFiatRateRequest {
   address: Hex;
@@ -32,15 +50,11 @@ export function useTokenFiatRates(requests: TokenFiatRateRequest[]) {
         const currency = currencyOverride ?? selectedCurrency;
         const isUsd = currency.toLowerCase() === 'usd';
 
-        const isArbitrumUSDC =
-          address.toLowerCase() === ARBITRUM_USDC.address.toLowerCase() &&
-          chainId === CHAIN_IDS.ARBITRUM;
-
-        const isPolygonUSDCE =
-          address.toLowerCase() === POLYGON_USDCE.address.toLowerCase() &&
-          chainId === CHAIN_IDS.POLYGON;
+        const isStablecoin = STABLECOINS[chainId]?.includes(
+          address.toLowerCase() as Hex,
+        );
 
-        if (isUsd && (isArbitrumUSDC || isPolygonUSDCE)) {
+        if (isUsd && isStablecoin) {
           return 1;
         }
 

app/components/Views/confirmations/hooks/tokens/useTokenFiatRates.ts

@@ -32,7 +32,6 @@ export function getTransactionPayControllerMessenger(
       'NetworkController:getNetworkClientById',
       'RemoteFeatureFlagController:getState',
       'TokenBalancesController:getState',
-      'TokenListController:getState',
       'TokenRatesController:getState',
       'TokensController:getState',
       'TransactionController:estimateGas',

app/core/Engine/messengers/transaction-pay-controller-messenger/transaction-pay-controller-messenger.ts

@@ -299,7 +299,7 @@
     "@metamask/swappable-obj-proxy": "^2.1.0",
     "@metamask/swaps-controller": "^15.0.0",
     "@metamask/transaction-controller": "^62.14.0",
-    "@metamask/transaction-pay-controller": "^12.1.0",
+    "@metamask/transaction-pay-controller": "patch:@metamask/transaction-pay-controller@npm%3A12.1.0#~/.yarn/patches/@metamask-transaction-pay-controller-npm-12.1.0-226665ee88.patch",
     "@metamask/tron-wallet-snap": "^1.19.2",
     "@metamask/utils": "^11.8.1",
     "@ngraveio/bc-ur": "^1.1.6",

package.json

@@ -9829,7 +9829,7 @@ __metadata:
   languageName: node
   linkType: hard
 
-"@metamask/transaction-pay-controller@npm:^12.1.0":
+"@metamask/transaction-pay-controller@npm:12.1.0":
   version: 12.1.0
   resolution: "@metamask/transaction-pay-controller@npm:12.1.0"
   dependencies:
@@ -9855,6 +9855,32 @@ __metadata:
   languageName: node
   linkType: hard
 
+"@metamask/transaction-pay-controller@patch:@metamask/transaction-pay-controller@npm%3A12.1.0#~/.yarn/patches/@metamask-transaction-pay-controller-npm-12.1.0-226665ee88.patch":
+  version: 12.1.0
+  resolution: "@metamask/transaction-pay-controller@patch:@metamask/transaction-pay-controller@npm%3A12.1.0#~/.yarn/patches/@metamask-transaction-pay-controller-npm-12.1.0-226665ee88.patch::version=12.1.0&hash=a5ca90"
+  dependencies:
+    "@ethersproject/abi": "npm:^5.7.0"
+    "@ethersproject/contracts": "npm:^5.7.0"
+    "@metamask/assets-controllers": "npm:^99.2.0"
+    "@metamask/base-controller": "npm:^9.0.0"
+    "@metamask/bridge-controller": "npm:^65.2.0"
+    "@metamask/bridge-status-controller": "npm:^65.0.1"
+    "@metamask/controller-utils": "npm:^11.18.0"
+    "@metamask/gas-fee-controller": "npm:^26.0.2"
+    "@metamask/messenger": "npm:^0.3.0"
+    "@metamask/metamask-eth-abis": "npm:^3.1.1"
+    "@metamask/network-controller": "npm:^29.0.0"
+    "@metamask/remote-feature-flag-controller": "npm:^4.0.0"
+    "@metamask/transaction-controller": "npm:^62.14.0"
+    "@metamask/utils": "npm:^11.9.0"
+    bignumber.js: "npm:^9.1.2"
+    bn.js: "npm:^5.2.1"
+    immer: "npm:^9.0.6"
+    lodash: "npm:^4.17.21"
+  checksum: 10/8503ba5e75a7aa5d49f95160b24f4ba2c9df2395a329b2747f8e29a1375df432c202cc57c29933f099db8f7524d011084f9f9190a55035eca3a12af363eec8aa
+  languageName: node
+  linkType: hard
+
 "@metamask/tron-wallet-snap@npm:^1.19.2":
   version: 1.19.2
   resolution: "@metamask/tron-wallet-snap@npm:1.19.2"
@@ -34893,7 +34919,7 @@ __metadata:
     "@metamask/test-dapp-multichain": "npm:^0.17.1"
     "@metamask/test-dapp-solana": "npm:^0.3.0"
     "@metamask/transaction-controller": "npm:^62.14.0"
-    "@metamask/transaction-pay-controller": "npm:^12.1.0"
+    "@metamask/transaction-pay-controller": "patch:@metamask/transaction-pay-controller@npm%3A12.1.0#~/.yarn/patches/@metamask-transaction-pay-controller-npm-12.1.0-226665ee88.patch"
     "@metamask/tron-wallet-snap": "npm:^1.19.2"
     "@metamask/utils": "npm:^11.8.1"
     "@ngraveio/bc-ur": "npm:^1.1.6"