refactor: remove learn more link from MainNotificationToggle component and associated tests

Author: baptiste-marchand

app/components/Views/Settings/NotificationsSettings/MainNotificationToggle.test.tsx

@@ -1,9 +1,7 @@
 import { fireEvent, render, waitFor } from '@testing-library/react-native';
 import React from 'react';
 import { Linking } from 'react-native';
-import AppConstants from '../../../../core/AppConstants';
 import {
-  MAIN_NOTIFICATION_TOGGLE_LEARN_MORE_TEST_ID,
   MAIN_NOTIFICATION_TOGGLE_TEST_ID,
   MainNotificationToggle,
 } from './MainNotificationToggle';
@@ -57,20 +55,4 @@ describe('MainNotificationToggle', () => {
       expect(mocks.mockOnToggle).toHaveBeenCalled();
     });
   });
-
-  it('opens learn more link', async () => {
-    const mocks = arrangeMocks();
-    const { getByTestId } = render(<MainNotificationToggle />);
-    const learnMoreText = getByTestId(
-      MAIN_NOTIFICATION_TOGGLE_LEARN_MORE_TEST_ID,
-    );
-
-    fireEvent.press(learnMoreText);
-
-    await waitFor(() => {
-      expect(mocks.mockOpenURL).toHaveBeenCalledWith(
-        AppConstants.URLS.PROFILE_SYNC,
-      );
-    });
-  });
 });

app/components/Views/Settings/NotificationsSettings/MainNotificationToggle.tsx

@@ -10,27 +10,23 @@ import {
   TextVariant,
 } from '@metamask/design-system-react-native';
 import { useStyles } from '../../../../component-library/hooks';
-import AppConstants from '../../../../core/AppConstants';
 import { useMainNotificationToggle } from './MainNotificationToggle.hooks';
 import styleSheet from './NotificationsSettings.styles';
 import { NotificationSettingsViewSelectorsIDs } from './NotificationSettingsView.testIds';
 
 export const MAIN_NOTIFICATION_TOGGLE_TEST_ID = 'main-notification-toggle';
-export const MAIN_NOTIFICATION_TOGGLE_LEARN_MORE_TEST_ID =
-  'main-notification-toggle--learn-more-button';
 
 export const MainNotificationToggle = () => {
   const theme = useTheme();
   const { styles } = useStyles(styleSheet, { theme });
 
   const { onToggle, value } = useMainNotificationToggle();
 
-  const goToLearnMore = useCallback(() => {
-    Linking.openURL(AppConstants.URLS.PROFILE_SYNC);
-  }, []);
-
   return (
     <>
+      <Text color={TextColor.TextAlternative} variant={TextVariant.BodySm}>
+        {strings('app_settings.allow_notifications_desc')}
+      </Text>
       <View
         style={styles.switchElement}
         testID={MAIN_NOTIFICATION_TOGGLE_TEST_ID}
@@ -55,19 +51,6 @@ export const MainNotificationToggle = () => {
           testID={NotificationSettingsViewSelectorsIDs.NOTIFICATIONS_TOGGLE}
         />
       </View>
-      <View style={styles.setting}>
-        <Text color={TextColor.TextAlternative} variant={TextVariant.BodySm}>
-          {strings('app_settings.allow_notifications_desc')}{' '}
-          <Text
-            variant={TextVariant.BodySm}
-            color={TextColor.InfoDefault}
-            onPress={goToLearnMore}
-            testID={MAIN_NOTIFICATION_TOGGLE_LEARN_MORE_TEST_ID}
-          >
-            {strings('notifications.activation_card.learn_more')}
-          </Text>
-        </Text>
-      </View>
     </>
   );
 };