Skip to content

Commit 856b700

Browse files
committed
Merge branch 'rn-upgrade/0.81.5-no-unit-tests' of https://github.com/MetaMask/metamask-mobile into rn-upgrade/0.81.5-no-unit-tests
2 parents c22dc5d + 1d83e25 commit 856b700

71 files changed

Lines changed: 2772 additions & 580 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/guidelines/E2E_DECISION_TREE.md

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ To save infra resources while waiting for static analysis findings and potential
3333
- E2E tests are skipped and merge is blocked while the label is present, **unless** all changes are ignorable-only.
3434
- If E2E tests are needed, they should pass to be able to merge.
3535

36-
## AI test selection
36+
## Smart AI E2E test selection
3737

3838
Runs only when all of the following are true:
3939

@@ -53,3 +53,10 @@ Flakiness detection is applied to modified E2E test files in PRs:
5353
- Modified E2E test files run twice
5454
- It applies to existing test files as well as new test files added in the PR
5555
- It can be disabled by adding the label `skip-e2e-flakiness-detection`. Useful when making large refactors or when changes don't pose flakiness risk.
56+
57+
## Release branches
58+
59+
PRs to release branches (cherry-picked from main) are exempt from the following:
60+
61+
- Label `pr-not-ready-for-e2e` is not applied
62+
- Smart AI E2E selection is skipped - all E2E suites are run (if changes are not ignorable-only, e.g. only docs)

.github/workflows/update-e2e-fixtures.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,7 @@ jobs:
255255
run: |
256256
IS_TEST='true' NODE_OPTIONS='--experimental-vm-modules' \
257257
yarn detox test -c ios.sim.main.ci --headless \
258-
tests/regression/fixtures/fixture-validation.spec.ts
258+
tests/smoke/fixtures/fixture-validation.spec.ts
259259
env:
260260
PREBUILT_IOS_APP_PATH: artifacts/main-qa-MetaMask.app
261261

app/components/UI/Identity/BackupAndSyncFeaturesToggles/BackupAndSyncFeaturesToggles.tsx

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,13 @@
11
import React, { useCallback, useMemo } from 'react';
22
import { View, Switch, InteractionManager } from 'react-native';
33

4-
import Text, {
4+
import {
5+
Text,
56
TextColor,
67
TextVariant,
7-
} from '../../../../component-library/components/Texts/Text';
8+
Icon,
9+
IconName,
10+
} from '@metamask/design-system-react-native';
811
import { useTheme } from '../../../../util/theme';
912
import styles from './BackupAndSyncFeaturesToggles.styles';
1013
import { useBackupAndSync } from '../../../../util/identity/hooks/useBackupAndSync';
@@ -16,9 +19,6 @@ import {
1619
selectIsBackupAndSyncUpdateLoading,
1720
} from '../../../../selectors/identity';
1821
import { BACKUPANDSYNC_FEATURES } from '@metamask/profile-sync-controller/user-storage';
19-
import Icon, {
20-
IconName,
21-
} from '../../../../component-library/components/Icons/Icon';
2222
import { strings } from '../../../../../locales/i18n';
2323
import { MetaMetricsEvents } from '../../../../core/Analytics';
2424
import { useAnalytics } from '../../../hooks/useAnalytics/useAnalytics';
@@ -126,10 +126,10 @@ const BackupAndSyncFeaturesToggles = () => {
126126
return (
127127
<View style={styles.setting}>
128128
<View style={styles.heading}>
129-
<Text variant={TextVariant.HeadingSM}>
129+
<Text variant={TextVariant.HeadingSm}>
130130
{strings('backupAndSync.manageWhatYouSync.title')}
131131
</Text>
132-
<Text variant={TextVariant.BodySM} color={TextColor.Alternative}>
132+
<Text variant={TextVariant.BodySm} color={TextColor.TextAlternative}>
133133
{strings('backupAndSync.manageWhatYouSync.description')}
134134
</Text>
135135
</View>

app/components/UI/Identity/BackupAndSyncToggle/BackupAndSyncToggle.tsx

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,11 @@ import React, { useCallback, useEffect } from 'react';
33
import { View, Switch, Linking, InteractionManager } from 'react-native';
44
// import { useNavigation } from '@react-navigation/native';
55

6-
import Text, {
6+
import {
7+
Text,
78
TextVariant,
89
TextColor,
9-
} from '../../../../component-library/components/Texts/Text';
10+
} from '@metamask/design-system-react-native';
1011
import { useTheme } from '../../../../util/theme';
1112
// import { strings } from '../../../../../locales/i18n';
1213
import styles from './BackupAndSyncToggle.styles';
@@ -150,7 +151,7 @@ const BackupAndSyncToggle = ({
150151
return (
151152
<View style={styles.setting}>
152153
<View style={styles.heading}>
153-
<Text variant={TextVariant.HeadingSM}>
154+
<Text variant={TextVariant.HeadingSm}>
154155
{strings('backupAndSync.title')}
155156
</Text>
156157
<Switch
@@ -165,9 +166,9 @@ const BackupAndSyncToggle = ({
165166
testID={BACKUP_AND_SYNC_TOGGLE_TEST_IDS.TOGGLE}
166167
/>
167168
</View>
168-
<Text variant={TextVariant.BodyMD} color={TextColor.Alternative}>
169+
<Text variant={TextVariant.BodyMd} color={TextColor.TextAlternative}>
169170
{strings('backupAndSync.enable.description')}
170-
<Text color={TextColor.Info} onPress={handleLink}>
171+
<Text color={TextColor.InfoDefault} onPress={handleLink}>
171172
{strings('backupAndSync.privacyLink')}
172173
</Text>
173174
</Text>

app/components/UI/Identity/ConfirmTurnOnBackupAndSyncModal/ConfirmTurnOnBackupAndSyncModal.tsx

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,13 @@
11
import React, { useRef } from 'react';
22

3-
import BottomSheet, {
4-
BottomSheetRef,
5-
} from '../../../../component-library/components/BottomSheets/BottomSheet';
6-
import { strings } from '../../../../../locales/i18n';
7-
83
import {
4+
BottomSheet,
5+
type BottomSheetRef,
96
IconColor,
107
IconName,
118
IconSize,
12-
} from '../../../../component-library/components/Icons/Icon';
9+
} from '@metamask/design-system-react-native';
10+
import { strings } from '../../../../../locales/i18n';
1311
import ModalContent from '../../Notification/Modal';
1412
import { toggleBasicFunctionality } from '../../../../actions/settings';
1513
import { useParams } from '../../../../util/navigation/navUtils';
@@ -45,7 +43,7 @@ const ConfirmTurnOnBackupAndSyncModal = () => {
4543
const turnContent = {
4644
icon: {
4745
name: IconName.Check,
48-
color: IconColor.Success,
46+
color: IconColor.SuccessDefault,
4947
},
5048
bottomSheetTitle: strings('backupAndSync.enable.title'),
5149
bottomSheetMessage: strings('backupAndSync.enable.confirmation'),

0 commit comments

Comments
 (0)