feat(card): enable cashback for US users (#29138)

Brunonascdev · web-flow · commit 85dc04ec162a · 2026-04-21T18:14:03.000Z
## **Description**  This PR enables the Card Cashback feature for US users, removing the location verification from the BaanxProvider capabilities. ## **Changelog**  CHANGELOG entry: Enable Card Cashback for US users ## **Related issues** Fixes: ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist**  - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. #### Performance checks (if applicable) - [ ] I've tested on Android - Ideally on a mid-range device; emulator is acceptable - [ ] I've tested with a power user scenario - Use these [power-user SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93) to import wallets with many accounts and tokens - [ ] I've instrumented key operations with Sentry traces for production performance metrics - See [`trace()`](/app/util/trace.ts) for usage and [`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274) for an example For performance guidelines and tooling, see the [Performance Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers). ## **Pre-merge reviewer checklist**  - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.  --- > [!NOTE] > **Medium Risk** > Changes the card capability contract and removes location-based overrides, which could affect downstream UI/feature gating for providers if any relied on per-location capability resolution. > > **Overview** > Enables cashback for US users by removing Baanx’s US-specific capability overrides and making `CardController.getCapabilities()` always return the provider’s static `capabilities`. > > This drops the `ICardProvider.resolveCapabilities()` hook entirely and updates tests to no longer assert location-dependent capability behavior. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit ba8235a. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup>
diff --git a/app/core/Engine/controllers/card-controller/CardController.test.ts b/app/core/Engine/controllers/card-controller/CardController.test.ts
@@ -1373,57 +1373,14 @@ describe('CardController — getCapabilities', () => {
     supportsCashback: true,
   };
 
-  it('returns base capabilities when provider has no resolveCapabilities', () => {
-    // Provider without resolveCapabilities → controller falls back to capabilities
+  it('returns base capabilities', () => {
     const provider = buildMockProvider({ capabilities: baseCapabilities });
-    const controller = buildController(provider, {
-      providerData: { baanx: { location: 'international' } },
-    });
+    const controller = buildController(provider);
 
     const caps = controller.getCapabilities();
     expect(caps.supportsPinView).toBe(false);
     expect(caps.supportsCashback).toBe(true);
   });
-
-  it('delegates to resolveCapabilities with the current location', () => {
-    const resolved = {
-      ...baseCapabilities,
-      supportsPinView: true,
-      supportsCashback: false,
-    };
-    const provider = buildMockProvider({
-      capabilities: baseCapabilities,
-      resolveCapabilities: jest.fn().mockReturnValue(resolved),
-    });
-    const controller = buildController(provider, {
-      providerData: { baanx: { location: 'us' } },
-    });
-
-    const caps = controller.getCapabilities();
-    expect(provider.resolveCapabilities).toHaveBeenCalledWith('us');
-    expect(caps.supportsPinView).toBe(true);
-    expect(caps.supportsCashback).toBe(false);
-  });
-
-  it('forces supportsPinView true and supportsCashback false for US', () => {
-    // Use a provider that implements the Baanx-style location override logic
-    const provider = buildMockProvider({
-      capabilities: baseCapabilities,
-      resolveCapabilities: jest.fn((location: string) => ({
-        ...baseCapabilities,
-        supportsPinView: location === 'us' || baseCapabilities.supportsPinView,
-        supportsCashback:
-          location !== 'us' && baseCapabilities.supportsCashback,
-      })),
-    });
-    const controller = buildController(provider, {
-      providerData: { baanx: { location: 'us' } },
-    });
-
-    const caps = controller.getCapabilities();
-    expect(caps.supportsPinView).toBe(true);
-    expect(caps.supportsCashback).toBe(false);
-  });
 });
 
 describe('CardController — data pass-throughs', () => {
diff --git a/app/core/Engine/controllers/card-controller/CardController.ts b/app/core/Engine/controllers/card-controller/CardController.ts
@@ -642,12 +642,7 @@ export class CardController extends BaseController<
 
   getCapabilities(): CardProviderCapabilities {
     const provider = this.getActiveProvider();
-    const pid = this.state.activeProviderId ?? '';
-    const provData = this.state.providerData[pid] as
-      | { location?: string }
-      | undefined;
-    const location = provData?.location ?? '';
-    return provider.resolveCapabilities?.(location) ?? provider.capabilities;
+    return provider.capabilities;
   }
 
   async getCardHomeData(address: string): Promise<CardHomeData> {
diff --git a/app/core/Engine/controllers/card-controller/provider-types.ts b/app/core/Engine/controllers/card-controller/provider-types.ts
@@ -325,7 +325,6 @@ export interface RegistrationStatus {
 export interface ICardProvider {
   readonly id: CardProviderId;
   readonly capabilities: CardProviderCapabilities;
-  resolveCapabilities?(location: string): CardProviderCapabilities;
 
   initiateAuth(country: string): Promise<CardAuthSession>;
   submitCredentials(
diff --git a/app/core/Engine/controllers/card-controller/providers/BaanxProvider.ts b/app/core/Engine/controllers/card-controller/providers/BaanxProvider.ts
@@ -231,21 +231,6 @@ export class BaanxProvider implements ICardProvider {
     supportsPinView: true,
     supportsCashback: true,
   };
-
-  /**
-   * Applies Baanx-specific location overrides:
-   * - US users always get PIN view (regardless of base flag).
-   * - US users do not have cashback (only available outside the US).
-   */
-  resolveCapabilities(location: string): CardProviderCapabilities {
-    const isUS = location === 'us';
-    return {
-      ...this.capabilities,
-      supportsPinView: isUS || this.capabilities.supportsPinView,
-      supportsCashback: !isUS && this.capabilities.supportsCashback,
-    };
-  }
-
   private readonly service: BaanxService;
   private readonly cardFeatureFlag: CardFeatureFlag | null;
 
