fix: stop merging pending smart transactions into selectLocalTransactions

Author: matthewwalsh0

app/selectors/transactionController.ts

@@ -219,14 +219,12 @@ export const selectSortedEVMTransactionsForSelectedAccountGroup =
 export const selectLocalTransactions = createDeepEqualSelector(
   [
     selectNonReplacedTransactions,
-    selectPendingSmartTransactionsForSelectedAccountGroup,
     selectSelectedAccountGroupEvmInternalAccount,
     selectEvmAddress,
     selectRequiredTransactionIds,
   ],
   (
     nonReplacedTransactions,
-    pendingSmartTransactions,
     groupEvmAccount,
     fallbackEvmAddress,
     requiredTransactionIds,
@@ -246,20 +244,9 @@ export const selectLocalTransactions = createDeepEqualSelector(
       return areAddressesEqual(fromAddress, activeEvmAddress);
     });
 
-    const pendingSmartTransactionsForActiveAddress =
-      pendingSmartTransactions.filter((transaction) => {
-        const fromAddress = transaction.txParams?.from;
-        if (!fromAddress || !activeEvmAddress) {
-          return false;
-        }
-
-        return areAddressesEqual(fromAddress, activeEvmAddress);
-      });
-
-    return dedupeTransactions([
-      ...transactions,
-      ...pendingSmartTransactionsForActiveAddress,
-    ]).sort((a, b) => (b?.time ?? 0) - (a?.time ?? 0));
+    return dedupeTransactions(transactions).sort(
+      (a, b) => (b?.time ?? 0) - (a?.time ?? 0),
+    );
   },
 );