Skip to content

Commit 8fc03e3

Browse files
committed
chore: upgrade to @metamask/messenger@2.0.0 + TC 68.4.0, match main
- Bump @metamask/messenger resolution from ^1.2.0 to ^2.0.0 - Bump @metamask/transaction-controller from 68.2.2 to 68.4.0 - Drop @metamask/snaps-rpc-methods pin (17.0.0) - Drop stale @metamask/messenger@^0.3.0 override - Restore SnapsMethodMiddleware getMessenger buildChild hook (matches main) - Update caveat specifications test to expect 15 (snaps-rpc-methods@17.1.0) TC 68.3.0 fixes bridge transactions being stuck-as-pending when a user has saved advanced gas fees; this is likely responsible for the e2e swap suite's 'Bridge transaction should show Confirmed status' timeout. TC 68.3.0 requires @metamask/messenger@^2.0.0, which is what mobile main now uses; align everything with main's versions to keep the surface area minimal.
1 parent b3a41c0 commit 8fc03e3

4 files changed

Lines changed: 52 additions & 31 deletions

File tree

app/core/Permissions/specifications.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ describe('PermissionController specifications', () => {
2525
describe('caveat specifications', () => {
2626
it('getCaveatSpecifications returns the expected specifications object', () => {
2727
const caveatSpecifications = getCaveatSpecifications({});
28-
expect(Object.keys(caveatSpecifications)).toHaveLength(14);
28+
expect(Object.keys(caveatSpecifications)).toHaveLength(15);
2929
expect(caveatSpecifications[Caip25CaveatType].type).toStrictEqual(
3030
Caip25CaveatType,
3131
);

app/core/Snaps/SnapsMethodMiddleware.ts

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,16 @@
11
///: BEGIN:ONLY_INCLUDE_IF(snaps)
2-
import { createSnapsMethodMiddleware } from '@metamask/snaps-rpc-methods';
2+
import {
3+
createSnapsMethodMiddleware,
4+
type PermittedRpcMethodHooks,
5+
} from '@metamask/snaps-rpc-methods';
36
import { SubjectType } from '@metamask/permission-controller';
47
import { Json } from '@metamask/utils';
58
import { captureException } from '@sentry/react-native';
69
import { AppState } from 'react-native';
710
import { getVersion } from 'react-native-device-info';
811

912
import { keyringSnapPermissionsBuilder } from '../SnapKeyring/keyringSnapsPermissions';
10-
import { RootExtendedMessenger, EngineContext } from '../Engine';
13+
import { RootExtendedMessenger, GlobalActions, GlobalEvents } from '../Engine';
1114
import { analytics } from '../../util/analytics/analytics';
1215
import { AnalyticsEventBuilder } from '../../util/analytics/AnalyticsEventBuilder';
1316
import { endTrace, trace } from '../../util/trace';
@@ -55,6 +58,12 @@ const snapMethodMiddlewareBuilder = (
5558

5659
return `${baseVersion}-${buildType}.0`;
5760
},
61+
getMessenger: ({ actions, events }) =>
62+
controllerMessenger.buildChild<string, GlobalActions, GlobalEvents>({
63+
namespace: origin,
64+
actions: (actions ?? []) as GlobalActions['type'][],
65+
events: (events ?? []) as GlobalEvents['type'][],
66+
}) as ReturnType<PermittedRpcMethodHooks['getMessenger']>,
5867
// @ts-expect-error Type 'string' is not assignable to type 'TraceName'.
5968
startTrace: trace,
6069
// @ts-expect-error Type 'string' is not assignable to type 'TraceName'.

package.json

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -204,9 +204,7 @@
204204
"pretty-format/react-is": "^19.0.0",
205205
"bn.js@npm:4.11.6": "4.12.3",
206206
"bn.js@npm:5.2.1": "5.2.3",
207-
"@metamask/messenger@^0.3.0": "^1.0.0",
208-
"@metamask/messenger": "^1.2.0",
209-
"@metamask/snaps-rpc-methods": "17.0.0",
207+
"@metamask/messenger": "^2.0.0",
210208
"@metamask/keyring-internal-api": "^11.0.1",
211209
"@metamask/keyring-api@npm:^21.3.0": "^23.3.0",
212210
"@metamask/keyring-api@npm:^21.4.0": "^23.3.0",
@@ -216,7 +214,7 @@
216214
"react-native-quick-base64@npm:^2.0.5": "patch:react-native-quick-base64@npm%3A2.2.0#~/.yarn/patches/react-native-quick-base64-npm-2.2.0-9083eb316a.patch",
217215
"@metamask/permission-controller": "^13.1.1",
218216
"react-native-ble-plx@npm:3.4.0": "patch:react-native-ble-plx@npm%3A3.4.0#~/.yarn/patches/react-native-ble-plx-npm-3.4.0-401e8b3343.patch",
219-
"@metamask/transaction-controller": "68.2.2",
217+
"@metamask/transaction-controller": "68.4.0",
220218
"@metamask/keyring-controller": "^27.1.0",
221219
"@metamask/accounts-controller": "^39.0.3",
222220
"expo-web-browser@npm:~55.0.16": "55.0.16",
@@ -303,7 +301,7 @@
303301
"@metamask/keyring-utils": "^3.3.1",
304302
"@metamask/logging-controller": "^8.0.0",
305303
"@metamask/message-signing-snap": "^1.1.2",
306-
"@metamask/messenger": "^1.2.0",
304+
"@metamask/messenger": "^2.0.0",
307305
"@metamask/metamask-eth-abis": "3.1.1",
308306
"@metamask/mobile-wallet-protocol-core": "^0.4.0",
309307
"@metamask/mobile-wallet-protocol-wallet-client": "^0.3.0",
@@ -358,7 +356,7 @@
358356
"@metamask/storage-service": "^1.0.0",
359357
"@metamask/superstruct": "^3.2.1",
360358
"@metamask/swappable-obj-proxy": "^2.1.0",
361-
"@metamask/transaction-controller": "^68.2.2",
359+
"@metamask/transaction-controller": "^68.4.0",
362360
"@metamask/transaction-pay-controller": "^23.17.4",
363361
"@metamask/tron-wallet-snap": "^1.29.1",
364362
"@metamask/utils": "^11.11.0",

yarn.lock

Lines changed: 36 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -9353,17 +9353,14 @@ __metadata:
93539353
languageName: node
93549354
linkType: hard
93559355

9356-
"@metamask/messenger@npm:^1.0.0, @metamask/messenger@npm:^1.2.0":
9357-
version: 1.2.0
9358-
resolution: "@metamask/messenger@npm:1.2.0"
9356+
"@metamask/messenger@npm:^2.0.0":
9357+
version: 2.0.0
9358+
resolution: "@metamask/messenger@npm:2.0.0"
93599359
dependencies:
9360-
"@metamask/utils": "npm:^11.9.0"
9361-
yargs: "npm:^17.7.2"
9360+
"@metamask/utils": "npm:^11.11.0"
93629361
peerDependencies:
93639362
typescript: ">=5.0.0"
9364-
bin:
9365-
messenger-generate-action-types: ./dist/generate-action-types/cli.mjs
9366-
checksum: 10/6818e4609d6162a436cc07955905f9e57ff6dbef841e9066a5fb9cc0538e981526fbcb5eef1fa1968d79212d57ddda2fce4dda5f87eb64d8d98f7db1216a6a98
9363+
checksum: 10/c387511edd89db73b774f631fb4bb382c9254af2dd7f80f9bd45f776e618cf90f653cc0e9744b1bf491f71f99c8318b16e8230a847f619a4fca655ea3f6a08e1
93679364
languageName: node
93689365
linkType: hard
93699366

@@ -10399,20 +10396,37 @@ __metadata:
1039910396
languageName: node
1040010397
linkType: hard
1040110398

10402-
"@metamask/snaps-rpc-methods@npm:17.0.0":
10403-
version: 17.0.0
10404-
resolution: "@metamask/snaps-rpc-methods@npm:17.0.0"
10399+
"@metamask/snaps-rpc-methods@npm:^15.0.2":
10400+
version: 15.1.1
10401+
resolution: "@metamask/snaps-rpc-methods@npm:15.1.1"
1040510402
dependencies:
1040610403
"@metamask/key-tree": "npm:^10.1.1"
10407-
"@metamask/permission-controller": "npm:^13.1.1"
10404+
"@metamask/permission-controller": "npm:^12.3.0"
1040810405
"@metamask/rpc-errors": "npm:^7.0.3"
10409-
"@metamask/snaps-sdk": "npm:^11.1.1"
10410-
"@metamask/snaps-utils": "npm:^12.2.1"
10406+
"@metamask/snaps-sdk": "npm:^11.1.0"
10407+
"@metamask/snaps-utils": "npm:^12.2.0"
1041110408
"@metamask/superstruct": "npm:^3.2.1"
1041210409
"@metamask/utils": "npm:^11.11.0"
1041310410
"@noble/hashes": "npm:^1.7.1"
1041410411
async-mutex: "npm:^0.5.0"
10415-
checksum: 10/731696bf6118a7ae1d75776fcb6948a6ee1b3659a1871dced2b78dbedd349c2bba6a3f767ad53b2af3e7bf04ec46798392a4463d316a68d30766c90129410480
10412+
checksum: 10/906eafa8a2d4944e50d73b8aa4d32a7070c33367ad3d58843e892e62b3bd8facb0a02e1d88a9245c18a281637435d97266212b7706ef67ee6a68db85a5991ea3
10413+
languageName: node
10414+
linkType: hard
10415+
10416+
"@metamask/snaps-rpc-methods@npm:^17.0.0, @metamask/snaps-rpc-methods@npm:^17.1.0":
10417+
version: 17.1.0
10418+
resolution: "@metamask/snaps-rpc-methods@npm:17.1.0"
10419+
dependencies:
10420+
"@metamask/key-tree": "npm:^10.1.1"
10421+
"@metamask/permission-controller": "npm:^13.1.1"
10422+
"@metamask/rpc-errors": "npm:^7.0.3"
10423+
"@metamask/snaps-sdk": "npm:^11.2.0"
10424+
"@metamask/snaps-utils": "npm:^12.3.0"
10425+
"@metamask/superstruct": "npm:^3.3.0"
10426+
"@metamask/utils": "npm:^11.11.0"
10427+
"@noble/hashes": "npm:^1.7.1"
10428+
async-mutex: "npm:^0.5.0"
10429+
checksum: 10/0afcd10f7f45611b74845c757bf9cad49044b51bfa1cf4043690f2084ad422684405aac405abed2b1c7f314857a6d208e902204dc82055d40f3a40c49c00c81d
1041610430
languageName: node
1041710431
linkType: hard
1041810432

@@ -10597,9 +10611,9 @@ __metadata:
1059710611
languageName: node
1059810612
linkType: hard
1059910613

10600-
"@metamask/transaction-controller@npm:68.2.2":
10601-
version: 68.2.2
10602-
resolution: "@metamask/transaction-controller@npm:68.2.2"
10614+
"@metamask/transaction-controller@npm:68.4.0":
10615+
version: 68.4.0
10616+
resolution: "@metamask/transaction-controller@npm:68.4.0"
1060310617
dependencies:
1060410618
"@ethereumjs/common": "npm:^4.4.0"
1060510619
"@ethereumjs/tx": "npm:^5.4.0"
@@ -10614,7 +10628,7 @@ __metadata:
1061410628
"@metamask/controller-utils": "npm:^12.3.0"
1061510629
"@metamask/core-backend": "npm:^6.5.0"
1061610630
"@metamask/gas-fee-controller": "npm:^26.2.4"
10617-
"@metamask/messenger": "npm:^1.2.0"
10631+
"@metamask/messenger": "npm:^2.0.0"
1061810632
"@metamask/metamask-eth-abis": "npm:^3.1.1"
1061910633
"@metamask/network-controller": "npm:^34.0.0"
1062010634
"@metamask/nonce-tracker": "npm:^6.0.0"
@@ -10631,7 +10645,7 @@ __metadata:
1063110645
peerDependencies:
1063210646
"@babel/runtime": ^7.0.0
1063310647
"@metamask/eth-block-tracker": ">=9"
10634-
checksum: 10/299741f8c238c70be1008e8a2768e9f64052fefd8582a59879d58c669551b23f4c0b55ffcecbfed56cafb5be3edb577ccfee11d910ebad14bfcbfb9b1b11003e
10648+
checksum: 10/12a9ea21e6a5d7d0ca8a504dde2a453fdfb74d826e80432f775bbaaab1acae5faf561bcfbef37d5cc36acf927f0bba53e4f56353ca0e0fb0ae866e450226e73b
1063510649
languageName: node
1063610650
linkType: hard
1063710651

@@ -35862,7 +35876,7 @@ __metadata:
3586235876
"@metamask/keyring-utils": "npm:^3.3.1"
3586335877
"@metamask/logging-controller": "npm:^8.0.0"
3586435878
"@metamask/message-signing-snap": "npm:^1.1.2"
35865-
"@metamask/messenger": "npm:^1.2.0"
35879+
"@metamask/messenger": "npm:^2.0.0"
3586635880
"@metamask/messenger-cli": "npm:^0.2.0"
3586735881
"@metamask/metamask-eth-abis": "npm:3.1.1"
3586835882
"@metamask/mobile-provider": "npm:^3.0.0"
@@ -35926,7 +35940,7 @@ __metadata:
3592635940
"@metamask/test-dapp-bitcoin": "npm:^0.2.0"
3592735941
"@metamask/test-dapp-multichain": "npm:^0.17.1"
3592835942
"@metamask/test-dapp-solana": "npm:^0.3.0"
35929-
"@metamask/transaction-controller": "npm:^68.2.2"
35943+
"@metamask/transaction-controller": "npm:^68.4.0"
3593035944
"@metamask/transaction-pay-controller": "npm:^23.17.4"
3593135945
"@metamask/tron-wallet-snap": "npm:^1.29.1"
3593235946
"@metamask/utils": "npm:^11.11.0"

0 commit comments

Comments
 (0)