chore(rewards): perps campaign remove margin stat (#29911)

## **Description**

Removes the margin requirement from the Perps Trading Campaign rewards
qualification UI to match the latest design. Qualification is now driven
solely by notional volume (≥ $25k); the `marginDeployed` field is
dropped from DTOs, cached state, controller cache read/write, locale
keys, and tests. On the stats screen PnL and Volume now share one row,
and the summary card replaces the margin StatCell with a spacer so
Volume stays left-aligned.

## **Changelog**

CHANGELOG entry: null

## **Screenshots/Recordings**

- Active campaign, have positions

<img width="305" height="176" alt="image"
src="https://github.com/user-attachments/assets/9738b8f3-9ef1-4c33-8a92-9b3a94e2e940"
/>

<img width="313" height="280" alt="image"
src="https://github.com/user-attachments/assets/7b151b6f-4b79-4be7-b9a4-24bf13cfc3a5"
/>

- Completed campaign, have positions

<img width="313" height="280" alt="image"
src="https://github.com/user-attachments/assets/c50271b7-6592-45b2-842f-45adb3155f02"
/>




<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Medium risk because it removes the `marginDeployed` field from Perps
leaderboard position DTO/state and updates controller caching logic,
which could break consumers expecting that data or older cached shapes.
> 
> **Overview**
> Updates the Perps Trading Campaign flow to **drop the margin-deployed
metric and requirement**, making qualification driven solely by notional
volume.
> 
> This removes `marginDeployed` from the Perps leaderboard position DTO
and cached state, updates `RewardsController` cache read/write
accordingly, and simplifies the stats/summary UI to no longer render a
margin StatCell (using a spacer to preserve layout). Tests and locale
strings are updated to match the new three-stat display and revised
qualification semantics.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
855c01b. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>

Author: VGR-GIT

app/components/UI/Rewards/Views/PerpsTradingCampaignDetailsView.test.tsx

@@ -348,7 +348,6 @@ function toMockLeaderboardPosition(
     rank: position.rank,
     pnl: 0,
     notionalVolume: 0,
-    marginDeployed: 0,
     qualified: true,
     neighbors: position.neighbors as PerpsTradingCampaignLeaderboardEntry[],
     computedAt: '2025-08-15T12:00:00.000Z',

app/components/UI/Rewards/Views/PerpsTradingCampaignLeaderboardView.test.tsx

@@ -149,7 +149,6 @@ const basePosition: PerpsTradingCampaignLeaderboardPositionDto = {
   rank: 4,
   pnl: 1000,
   notionalVolume: 10_000,
-  marginDeployed: 2000,
   qualified: true,
   neighbors: [],
   computedAt: '2025-01-01T00:00:00.000Z',

app/components/UI/Rewards/Views/PerpsTradingCampaignStatsView.test.tsx

@@ -173,7 +173,6 @@ const basePosition: PerpsTradingCampaignLeaderboardPositionDto = {
   rank: 4,
   pnl: 1500.25,
   notionalVolume: 30_000,
-  marginDeployed: 2000,
   qualified: true,
   neighbors: [],
   computedAt: '2025-01-01T00:00:00.000Z',
@@ -288,9 +287,6 @@ describe('PerpsTradingCampaignStatsView', () => {
     expect(
       getByTestId(PERPS_CAMPAIGN_STATS_VIEW_TEST_IDS.PERFORMANCE_VOLUME),
     ).toBeDefined();
-    expect(
-      getByTestId(PERPS_CAMPAIGN_STATS_VIEW_TEST_IDS.PERFORMANCE_MARGIN),
-    ).toBeDefined();
   });
 
   it('shows last-computed when position has a timestamp', () => {
@@ -327,7 +323,7 @@ describe('PerpsTradingCampaignStatsView', () => {
     ).toBeNull();
   });
 
-  it('hides volume and margin StatCells when campaign is complete (only PnL remains)', () => {
+  it('hides volume StatCell when campaign is complete (only PnL remains)', () => {
     const completeCampaign = {
       ...mockCampaign,
       endDate: '2020-01-01T00:00:00Z',
@@ -346,9 +342,6 @@ describe('PerpsTradingCampaignStatsView', () => {
     expect(
       queryByTestId(PERPS_CAMPAIGN_STATS_VIEW_TEST_IDS.PERFORMANCE_VOLUME),
     ).toBeNull();
-    expect(
-      queryByTestId(PERPS_CAMPAIGN_STATS_VIEW_TEST_IDS.PERFORMANCE_MARGIN),
-    ).toBeNull();
   });
 
   it('hides qualification cards when campaign is complete and shows last-computed after performance when position exists', () => {
@@ -384,7 +377,6 @@ describe('PerpsTradingCampaignStatsView', () => {
         ...basePosition,
         qualified: false,
         notionalVolume: 5_000,
-        marginDeployed: 500,
       },
       isLoading: false,
       hasError: false,

app/components/UI/Rewards/Views/PerpsTradingCampaignStatsView.tsx

@@ -47,7 +47,6 @@ export const PERPS_CAMPAIGN_STATS_VIEW_TEST_IDS = {
   CONTAINER: 'perps-campaign-stats-view-container',
   PERFORMANCE_PNL: 'perps-campaign-stats-view-performance-pnl',
   PERFORMANCE_VOLUME: 'perps-campaign-stats-view-performance-volume',
-  PERFORMANCE_MARGIN: 'perps-campaign-stats-view-performance-margin',
   QUALIFIED_CARD: 'perps-campaign-stats-view-qualified-card',
   QUALIFY_FOR_RANK_CARD: 'perps-campaign-stats-view-qualify-for-rank-card',
   LAST_COMPUTED: 'perps-campaign-stats-view-last-computed',
@@ -96,7 +95,6 @@ const PerpsTradingCampaignStatsView: React.FC = () => {
     : TextColor.TextDefault;
 
   const volumeValue = position ? formatUsd(position.notionalVolume) : '—';
-  const marginValue = position ? formatUsd(position.marginDeployed) : '—';
   const isQualified = position != null && position.qualified;
   const isPending = position != null && !position.qualified;
 
@@ -176,27 +174,18 @@ const PerpsTradingCampaignStatsView: React.FC = () => {
                 valueColor={pnlColor}
                 testID={PERPS_CAMPAIGN_STATS_VIEW_TEST_IDS.PERFORMANCE_PNL}
               />
-              <Box twClassName="flex-1" />
-            </Box>
-
-            {!isCampaignComplete && (
-              <Box flexDirection={BoxFlexDirection.Row}>
+              {!isCampaignComplete ? (
                 <StatCell
                   label={strings('rewards.perps_trading_campaign.label_volume')}
                   value={volumeValue}
                   isLoading={isLoading}
                   suffix={isQualified ? <CheckIcon /> : undefined}
                   testID={PERPS_CAMPAIGN_STATS_VIEW_TEST_IDS.PERFORMANCE_VOLUME}
                 />
-                <StatCell
-                  label={strings('rewards.perps_trading_campaign.label_margin')}
-                  value={marginValue}
-                  isLoading={isLoading}
-                  suffix={isQualified ? <CheckIcon /> : undefined}
-                  testID={PERPS_CAMPAIGN_STATS_VIEW_TEST_IDS.PERFORMANCE_MARGIN}
-                />
-              </Box>
-            )}
+              ) : (
+                <Box twClassName="flex-1" />
+              )}
+            </Box>
 
             {showQualifiedCard && (
               <Box

app/components/UI/Rewards/Views/PerpsTradingCampaignWinningView.test.tsx

@@ -70,7 +70,6 @@ describe('PerpsTradingCampaignWinningView', () => {
         rank: 3,
         pnl: 1500.25,
         notionalVolume: 30000,
-        marginDeployed: 1200,
         qualified: true,
         neighbors: [],
         computedAt: '2025-08-15T12:00:00.000Z',

app/components/UI/Rewards/components/Campaigns/PerpsCampaignStatsSummary.test.tsx

@@ -64,14 +64,13 @@ const basePosition: PerpsTradingCampaignLeaderboardPositionDto = {
   rank: 7,
   pnl: 1500.25,
   notionalVolume: 30_000,
-  marginDeployed: 2000,
   qualified: true,
   neighbors: [],
   computedAt: '2025-01-01T00:00:00.000Z',
 };
 
 describe('PerpsCampaignStatsSummary', () => {
-  it('renders container and four stat labels', () => {
+  it('renders container and three stat labels', () => {
     const { getByTestId, getByText } = render(
       <PerpsCampaignStatsSummary
         leaderboardPosition={basePosition}
@@ -87,9 +86,6 @@ describe('PerpsCampaignStatsSummary', () => {
     expect(
       getByText('rewards.perps_trading_campaign.label_volume'),
     ).toBeDefined();
-    expect(
-      getByText('rewards.perps_trading_campaign.label_margin'),
-    ).toBeDefined();
     expect(getByText('07')).toBeDefined();
     expect(getByText('+$1,500.25')).toBeDefined();
   });
@@ -123,7 +119,7 @@ describe('PerpsCampaignStatsSummary', () => {
         leaderboard={null}
       />,
     );
-    expect(getAllByText('—').length).toBeGreaterThanOrEqual(4);
+    expect(getAllByText('—').length).toBeGreaterThanOrEqual(3);
   });
 
   it('shows pending tag on rank when campaign is active and user is not qualified', () => {
@@ -186,7 +182,7 @@ describe('PerpsCampaignStatsSummary', () => {
     expect(queryByTestId(TEST_IDS.QUALIFY_FOR_RANK_CARD)).toBeNull();
   });
 
-  it('hides volume and margin StatCells when campaign is complete (only rank and PnL remain)', () => {
+  it('hides volume StatCell when campaign is complete (only rank and PnL remain)', () => {
     const { queryByTestId, getByTestId } = render(
       <PerpsCampaignStatsSummary
         leaderboardPosition={basePosition}
@@ -197,7 +193,6 @@ describe('PerpsCampaignStatsSummary', () => {
     expect(getByTestId(TEST_IDS.RANK)).toBeDefined();
     expect(getByTestId(TEST_IDS.PNL)).toBeDefined();
     expect(queryByTestId(TEST_IDS.NOTIONAL_VOLUME)).toBeNull();
-    expect(queryByTestId(TEST_IDS.MARGIN_DEPLOYED)).toBeNull();
   });
 
   it("hides You're qualified card when campaign is complete", () => {
@@ -219,7 +214,6 @@ describe('PerpsCampaignStatsSummary', () => {
           ...basePosition,
           qualified: false,
           notionalVolume: 5_000,
-          marginDeployed: 200,
         }}
         leaderboard={mockLeaderboard}
       />,
@@ -236,7 +230,6 @@ describe('PerpsCampaignStatsSummary', () => {
           ...basePosition,
           qualified: false,
           notionalVolume: 30_000,
-          marginDeployed: 2_000,
         }}
         leaderboard={mockLeaderboard}
       />,

app/components/UI/Rewards/components/Campaigns/PerpsCampaignStatsSummary.tsx

@@ -32,7 +32,6 @@ export const PERPS_CAMPAIGN_STATS_SUMMARY_TEST_IDS = {
   RANK: 'perps-campaign-stats-summary-rank',
   PNL: 'perps-campaign-stats-summary-pnl',
   NOTIONAL_VOLUME: 'perps-campaign-stats-summary-notional-volume',
-  MARGIN_DEPLOYED: 'perps-campaign-stats-summary-margin-deployed',
   PENDING_TAG: 'perps-campaign-stats-summary-pending-tag',
   QUALIFIED_TAG: 'perps-campaign-stats-summary-qualified-tag',
   QUALIFIED_CARD: 'perps-campaign-stats-summary-qualified-card',
@@ -81,10 +80,6 @@ const PerpsCampaignStatsSummary: React.FC<PerpsCampaignStatsSummaryProps> = ({
     ? formatUsd(leaderboardPosition.notionalVolume)
     : '—';
 
-  const marginDisplay = leaderboardPosition
-    ? formatUsd(leaderboardPosition.marginDeployed)
-    : '—';
-
   const notionalGap = leaderboardPosition
     ? Math.max(
         0,
@@ -140,11 +135,7 @@ const PerpsCampaignStatsSummary: React.FC<PerpsCampaignStatsSummaryProps> = ({
             value={volumeDisplay}
             testID={PERPS_CAMPAIGN_STATS_SUMMARY_TEST_IDS.NOTIONAL_VOLUME}
           />
-          <StatCell
-            label={strings('rewards.perps_trading_campaign.label_margin')}
-            value={marginDisplay}
-            testID={PERPS_CAMPAIGN_STATS_SUMMARY_TEST_IDS.MARGIN_DEPLOYED}
-          />
+          <Box twClassName="flex-1" />
         </Box>
       )}
 

app/components/UI/Rewards/components/Campaigns/PerpsTradingCampaignStatsHeader.test.tsx

@@ -53,7 +53,6 @@ const basePosition: PerpsTradingCampaignLeaderboardPositionDto = {
   rank: 7,
   pnl: 1500.25,
   notionalVolume: 30_000,
-  marginDeployed: 2000,
   qualified: true,
   neighbors: [],
   computedAt: '2025-01-01T00:00:00.000Z',

app/components/UI/Rewards/hooks/useGetPerpsTradingCampaignLeaderboardPosition.test.ts

@@ -64,7 +64,6 @@ const MOCK_POSITION: PerpsTradingCampaignLeaderboardPositionDto = {
   rank: 5,
   pnl: 1500,
   notionalVolume: 30000,
-  marginDeployed: 2000,
   qualified: true,
   neighbors: [],
   computedAt: '2024-03-20T12:00:00.000Z',

app/core/Engine/controllers/rewards-controller/RewardsController.ts

@@ -4603,7 +4603,6 @@ export class RewardsController extends BaseController<
               rank: cached.rank,
               pnl: cached.pnl,
               notionalVolume: cached.notionalVolume,
-              marginDeployed: cached.marginDeployed,
               qualified: cached.qualified,
               neighbors: cached.neighbors,
               computedAt: cached.computedAt,
@@ -4636,7 +4635,6 @@ export class RewardsController extends BaseController<
                 rank: payload.rank,
                 pnl: payload.pnl,
                 notionalVolume: payload.notionalVolume,
-                marginDeployed: payload.marginDeployed,
                 qualified: payload.qualified,
                 neighbors: payload.neighbors,
                 computedAt: payload.computedAt,