Skip to content

Commit 928fccb

Browse files
committed
chore: update name to chain_name
1 parent 37a85bf commit 928fccb

5 files changed

Lines changed: 19 additions & 19 deletions

File tree

app/components/Views/SocialLeaderboard/TraderPositionView/TraderPositionView.test.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -449,7 +449,7 @@ describe('TraderPositionView', () => {
449449
expect.objectContaining({
450450
trader_address: '0xabc',
451451
asset_name: 'PEPE',
452-
chain: 'base',
452+
chain_name: 'base',
453453
caip19: expect.stringContaining('eip155:8453/erc20:'),
454454
cta_type: 'buy',
455455
}),
@@ -505,7 +505,7 @@ describe('TraderPositionView', () => {
505505
expect.objectContaining({
506506
trader_address: '0xabc',
507507
asset_name: 'ETH',
508-
chain: 'hyperliquid',
508+
chain_name: 'hyperliquid',
509509
perps_market: 'ETH',
510510
source: 'trader_profile',
511511
}),
@@ -524,7 +524,7 @@ describe('TraderPositionView', () => {
524524
expect.objectContaining({
525525
trader_address: '0xabc',
526526
asset_name: 'ETH',
527-
chain: 'hyperliquid',
527+
chain_name: 'hyperliquid',
528528
perps_market: 'ETH',
529529
cta_type: 'trade',
530530
}),
@@ -542,7 +542,7 @@ describe('TraderPositionView', () => {
542542
MetaMetricsEvents.SOCIAL_FOLLOW_TRADING_TOKEN_DISMISSED,
543543
{
544544
trader_address: '0xabc',
545-
chain: 'hyperliquid',
545+
chain_name: 'hyperliquid',
546546
perps_market: 'ETH',
547547
},
548548
);

app/components/Views/SocialLeaderboard/TraderProfileView/TraderProfileView.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -708,7 +708,7 @@ describe('TraderProfileView', () => {
708708
expect.objectContaining({
709709
trader_address: '0xabc',
710710
asset_name: 'BTC',
711-
chain: 'hyperliquid',
711+
chain_name: 'hyperliquid',
712712
perps_market: 'BTC',
713713
is_open: true,
714714
}),

app/components/Views/SocialLeaderboard/analytics/buildFollowTradingTokenContext.test.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ describe('buildFollowTradingTokenContext', () => {
5656
expect(context).toEqual({
5757
trader_address: '0xtrader',
5858
asset_name: 'PEPE',
59-
chain: 'base',
59+
chain_name: 'base',
6060
caip19: 'eip155:8453/erc20:0x1234567890123456789012345678901234567890',
6161
});
6262
});
@@ -79,7 +79,7 @@ describe('buildFollowTradingTokenContext', () => {
7979
expect(context).toEqual({
8080
trader_address: '0xtrader',
8181
asset_name: 'ETH',
82-
chain: 'hyperliquid',
82+
chain_name: 'hyperliquid',
8383
perps_market: 'ETH',
8484
});
8585
expect(context).not.toHaveProperty('caip19');
@@ -94,7 +94,7 @@ describe('buildFollowTradingTokenContext', () => {
9494
expect(context).toEqual({
9595
trader_address: '0xtrader',
9696
asset_name: 'cash:SPCX',
97-
chain: 'hyperliquid',
97+
chain_name: 'hyperliquid',
9898
perps_market: 'xyz:SPCX',
9999
});
100100
});
@@ -112,7 +112,7 @@ describe('pickFollowTradingDismissedProperties', () => {
112112

113113
expect(pickFollowTradingDismissedProperties(context)).toEqual({
114114
trader_address: '0xtrader',
115-
chain: 'base',
115+
chain_name: 'base',
116116
caip19: 'eip155:8453/erc20:0x1234567890123456789012345678901234567890',
117117
});
118118
});
@@ -128,7 +128,7 @@ describe('pickFollowTradingDismissedProperties', () => {
128128

129129
expect(pickFollowTradingDismissedProperties(context)).toEqual({
130130
trader_address: '0xtrader',
131-
chain: 'hyperliquid',
131+
chain_name: 'hyperliquid',
132132
perps_market: 'ETH',
133133
});
134134
expect(pickFollowTradingDismissedProperties(context)).not.toHaveProperty(

app/components/Views/SocialLeaderboard/analytics/buildFollowTradingTokenContext.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import { SocialLeaderboardEventProperties } from './socialLeaderboardEvents';
77
export type FollowTradingTokenContext = {
88
[SocialLeaderboardEventProperties.TRADER_ADDRESS]: string;
99
[SocialLeaderboardEventProperties.ASSET_NAME]: string;
10-
[SocialLeaderboardEventProperties.CHAIN]: string;
10+
[SocialLeaderboardEventProperties.CHAIN_NAME]: string;
1111
} & (
1212
| {
1313
[SocialLeaderboardEventProperties.CAIP19]: string;
@@ -37,7 +37,7 @@ export function buildFollowTradingTokenContext(
3737
const base = {
3838
[SocialLeaderboardEventProperties.TRADER_ADDRESS]: traderAddress,
3939
[SocialLeaderboardEventProperties.ASSET_NAME]: position.tokenSymbol,
40-
[SocialLeaderboardEventProperties.CHAIN]: position.chain.toLowerCase(),
40+
[SocialLeaderboardEventProperties.CHAIN_NAME]: position.chain.toLowerCase(),
4141
};
4242

4343
if (isPerpPosition(position)) {
@@ -69,23 +69,23 @@ export function buildFollowTradingTokenContext(
6969

7070
/**
7171
* Picks only the global identifier fields from a follow-trading context for
72-
* dismissed events (trader_address + chain + caip19 or perps_market).
72+
* dismissed events (trader_address + chain_name + caip19 or perps_market).
7373
*/
7474
export function pickFollowTradingDismissedProperties(
7575
context: FollowTradingTokenContext,
7676
): Pick<
7777
FollowTradingTokenContext,
7878
| typeof SocialLeaderboardEventProperties.TRADER_ADDRESS
79-
| typeof SocialLeaderboardEventProperties.CHAIN
79+
| typeof SocialLeaderboardEventProperties.CHAIN_NAME
8080
| typeof SocialLeaderboardEventProperties.CAIP19
8181
| typeof SocialLeaderboardEventProperties.PERPS_MARKET
8282
> {
8383
if (SocialLeaderboardEventProperties.PERPS_MARKET in context) {
8484
return {
8585
[SocialLeaderboardEventProperties.TRADER_ADDRESS]:
8686
context[SocialLeaderboardEventProperties.TRADER_ADDRESS],
87-
[SocialLeaderboardEventProperties.CHAIN]:
88-
context[SocialLeaderboardEventProperties.CHAIN],
87+
[SocialLeaderboardEventProperties.CHAIN_NAME]:
88+
context[SocialLeaderboardEventProperties.CHAIN_NAME],
8989
[SocialLeaderboardEventProperties.PERPS_MARKET]:
9090
context[SocialLeaderboardEventProperties.PERPS_MARKET],
9191
};
@@ -94,8 +94,8 @@ export function pickFollowTradingDismissedProperties(
9494
return {
9595
[SocialLeaderboardEventProperties.TRADER_ADDRESS]:
9696
context[SocialLeaderboardEventProperties.TRADER_ADDRESS],
97-
[SocialLeaderboardEventProperties.CHAIN]:
98-
context[SocialLeaderboardEventProperties.CHAIN],
97+
[SocialLeaderboardEventProperties.CHAIN_NAME]:
98+
context[SocialLeaderboardEventProperties.CHAIN_NAME],
9999
[SocialLeaderboardEventProperties.CAIP19]:
100100
context[SocialLeaderboardEventProperties.CAIP19],
101101
};

app/components/Views/SocialLeaderboard/analytics/socialLeaderboardEvents.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ export const SocialLeaderboardEventProperties = {
1313
ASSET_NAME: 'asset_name',
1414
CAIP19: 'caip19',
1515
PERPS_MARKET: 'perps_market',
16-
CHAIN: 'chain',
16+
CHAIN_NAME: 'chain_name',
1717
CHAIN_FILTER: 'chain_filter',
1818
CTA_TYPE: 'cta_type',
1919
FEED_ACTION: 'feed_action',

0 commit comments

Comments
 (0)