Skip to content

Commit 94c8e83

Browse files
fix: replace TestHelpers.delay with executeWithRetry in ENS test (MMQA-1721)
Replace prohibited TestHelpers.delay(5000) with Utilities.executeWithRetry for waiting on ENS page load. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 0638442 commit 94c8e83

1 file changed

Lines changed: 11 additions & 5 deletions

File tree

tests/smoke/wallet/browser/browser-navigation.spec.ts

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,9 @@ import {
1212
import { DappVariants } from '../../../framework/Constants';
1313
import Browser from '../../../page-objects/Browser/BrowserView';
1414
import EnsWebsite from '../../../page-objects/Browser/ExternalWebsites/EnsWebsite';
15-
import { Assertions } from '../../../framework';
15+
import { Assertions, Utilities } from '../../../framework';
1616
import { TestSpecificMock } from '../../../framework/types';
1717
import { setupMockRequest } from '../../../api-mocking/helpers/mockHelpers';
18-
import TestHelpers from '../../../helpers.js';
1918
import { ensResolutionMock } from '../../../api-mocking/mock-responses/ens-resolution-mocks';
2019

2120
const INVALID_URL = 'https://quackquakc.easq';
@@ -112,9 +111,16 @@ describe(SmokeWalletPlatform('Browser Navigation'), () => {
112111
await navigateToBrowserView();
113112
await Browser.tapUrlInputBox();
114113
await Browser.navigateToURL('vitalik.eth');
115-
// ENS resolution + IPFS gateway fetch takes time
116-
await TestHelpers.delay(5000);
117-
await EnsWebsite.tapGeneralButton();
114+
// Wait for ENS page to load, then tap the "General" link
115+
await Utilities.executeWithRetry(
116+
async () => {
117+
await EnsWebsite.tapGeneralButton();
118+
},
119+
{
120+
timeout: 15000,
121+
description: 'wait for ENS page to load and tap General link',
122+
},
123+
);
118124
},
119125
);
120126
});

0 commit comments

Comments
 (0)