Commit 9d97e2f
feat: rewards dropdown filter on activity tab (#24910)
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->
## **Description**
Support filter by event types in the Activity Tab
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->
## **Changelog**
<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`
If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`
(This helps the Release Engineer do their job more quickly and
accurately)
-->
CHANGELOG entry: Support filter by event types in the Activity Tab
## **Related issues**
Fixes:
## **Manual testing steps**
```gherkin
Feature: my feature name
Scenario: user [verb for user action]
Given [describe expected initial app state]
When user [verb for user action]
Then [describe expected outcome]
```
## **Screenshots/Recordings**
<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->
### **Before**
<!-- [screenshots/recordings] -->
### **After**
<!-- [screenshots/recordings] -->
<img width="1179" height="2556" alt="Simulator Screenshot - E2E Test -
2026-01-20 at 17 15 44"
src="https://github.com/user-attachments/assets/23996550-b539-4cbb-8d82-134bf6afa4d3"
/>
<img width="1179" height="2556" alt="Simulator Screenshot - E2E Test -
2026-01-20 at 17 15 39"
src="https://github.com/user-attachments/assets/b8197292-9321-4c31-985c-8be6b574ae63"
/>
## **Pre-merge author checklist**
- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
## **Pre-merge reviewer checklist**
- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Medium Risk**
> Medium risk because it changes the points-events fetching pipeline
(new `type` query param, caching key changes, and request-cancellation
logic), which could impact activity feed freshness/pagination if edge
cases were missed.
>
> **Overview**
> Adds an **Activity Tab dropdown filter** that lets users fetch points
activity by earn type, driven by season-provided `activityTypes` and new
i18n strings.
>
> Extends `usePointsEvents` and the rewards backend to support
**type-filtered points events**: the hook now accepts `type` and
`enabled`, cancels in-flight first-page/pagination requests when
dependencies change, and the RewardsController/DataService include
`type` in API requests and cache keys.
>
> Updates `SelectOptionSheet`/`OptionsSheet` UI (design-system icon,
sorted options with `all` pinned, new close header) and tweaks a few
Rewards visuals (smaller icons, bonus text color), with substantial
test/snapshot updates to cover filtering and new fetch behavior.
>
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
049b910. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
---------
Co-authored-by: Rik Van Gulck <vangulckrik@gmail.com>1 parent 129c314 commit 9d97e2f
19 files changed
Lines changed: 2767 additions & 923 deletions
File tree
- app
- components
- UI
- Rewards
- components
- RewardItem
- Tabs/ActivityTab
- hooks
- SelectOptionSheet
- __snapshots__
- Views/LedgerConnect/__snapshots__
- core/Engine/controllers/rewards-controller
- services
- locales/languages
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
377 | 377 | | |
378 | 378 | | |
379 | 379 | | |
380 | | - | |
| 380 | + | |
381 | 381 | | |
382 | 382 | | |
383 | 383 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
131 | 131 | | |
132 | 132 | | |
133 | 133 | | |
134 | | - | |
| 134 | + | |
135 | 135 | | |
136 | 136 | | |
137 | 137 | | |
| |||
172 | 172 | | |
173 | 173 | | |
174 | 174 | | |
175 | | - | |
| 175 | + | |
176 | 176 | | |
177 | 177 | | |
178 | 178 | | |
| |||
0 commit comments