cleanup

Co-authored-by: Copilot <copilot@github.com>

Author: n3ps

app/selectors/transactionController.ts

@@ -5,7 +5,7 @@ import {
   selectPendingSmartTransactionsBySender,
   selectPendingSmartTransactionsForSelectedAccountGroup,
 } from './smartTransactionsController';
-import { selectSelectedAccountGroupInternalAccounts } from './multichainAccounts/accountTreeController';
+import { selectSelectedAccountGroupWithInternalAccountsAddresses } from './multichainAccounts/accountTreeController';
 import {
   TransactionMeta,
   TransactionType,
@@ -18,7 +18,7 @@ interface MetaMaskPayToken {
   chainId: Hex;
 }
 
-const PENDING_EVM_TRANSACTION_STATUSES = new Set([
+const transactionPendingStatuses = new Set([
   'submitted',
   'signed',
   'unapproved',
@@ -139,20 +139,13 @@ export const selectLocalTransactions = createDeepEqualSelector(
   [
     selectNonReplacedTransactions,
     selectPendingSmartTransactionsForSelectedAccountGroup,
-    selectSelectedAccountGroupInternalAccounts,
+    selectSelectedAccountGroupWithInternalAccountsAddresses,
   ],
-  (
-    nonReplacedTransactions,
-    pendingSmartTransactions,
-    selectedAccountGroupInternalAccounts,
-  ) => {
-    const selectedAddresses = selectedAccountGroupInternalAccounts
-      .map((account) => account.address)
-      .filter(Boolean);
-
+  (nonReplacedTransactions, pendingSmartTransactions, addresses) => {
     const pendingTransactions = nonReplacedTransactions.filter(
       (transaction) => {
-        if (!PENDING_EVM_TRANSACTION_STATUSES.has(transaction.status)) {
+        // Extracted from UnifiedTransactionsView submittedTxs filter
+        if (!transactionPendingStatuses.has(transaction.status)) {
           return false;
         }
 
@@ -161,8 +154,9 @@ export const selectLocalTransactions = createDeepEqualSelector(
           return false;
         }
 
-        return selectedAddresses.some((address) =>
-          areAddressesEqual(fromAddress, address),
+        // Extracted from UnifiedTransactionsView submittedTxsFiltered filter
+        return addresses.some((address) =>
+          areAddressesEqual(fromAddress, address || ''),
         );
       },
     );