Skip to content

Commit 9ee92ba

Browse files
authored
chore: sync envs cp-7.67.0 (#26661)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Add missing env variables in push-eas-updates.yml and builds.yml ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: Fixed missing env variables in push-eas-updates.yml ## **Related issues** Fixes: ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I've included tests if applicable - [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Touches release/CI configuration for EAS OTA updates and build secret mappings; misnamed/missing secrets could cause update/build failures, but no app runtime logic changes. > > **Overview** > Ensures EAS OTA update publishing has the full set of required QuickNode RPC secrets by adding `QUICKNODE_BSC_URL`, `QUICKNODE_SEI_URL`, and `QUICKNODE_HYPEREVM_URL` to `push-eas-update.yml`. > > Updates `builds.yml` to include `EXPO_PROJECT_ID` in the shared secrets map and fixes YAML structure around the `remote_feature_flags` anchor (including removing a stray/dangling entry) to keep build config parsing consistent. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 6451b50. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent 60f066c commit 9ee92ba

2 files changed

Lines changed: 7 additions & 3 deletions

File tree

.github/workflows/push-eas-update.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -312,6 +312,9 @@ jobs:
312312
QUICKNODE_MONAD_URL: ${{ secrets.QUICKNODE_MONAD_URL }}
313313
QUICKNODE_OPTIMISM_URL: ${{ secrets.QUICKNODE_OPTIMISM_URL }}
314314
QUICKNODE_POLYGON_URL: ${{ secrets.QUICKNODE_POLYGON_URL }}
315+
QUICKNODE_BSC_URL: ${{ secrets.QUICKNODE_BSC_URL }}
316+
QUICKNODE_SEI_URL: ${{ secrets.QUICKNODE_SEI_URL }}
317+
QUICKNODE_HYPEREVM_URL: ${{ secrets.QUICKNODE_HYPEREVM_URL }}
315318
steps:
316319
- name: Checkout repository
317320
uses: actions/checkout@v4

builds.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,8 @@ _secrets: &secrets # Infrastructure
9090
ANDROID_GOOGLE_SERVER_CLIENT_ID: 'ANDROID_GOOGLE_SERVER_CLIENT_ID'
9191
# Card/Baanx
9292
MM_CARD_BAANX_API_CLIENT_KEY: 'MM_CARD_BAANX_API_CLIENT_KEY'
93+
# Expo
94+
EXPO_PROJECT_ID: 'EXPO_PROJECT_ID'
9395

9496
# Signing config (AWS Secrets Manager) - omit for dev/simulator builds
9597
# android_keystore_path: filename in android/keystores/ (build.gradle expects fixed paths)
@@ -160,8 +162,8 @@ _code_fencing_flask: &code_fencing_flask
160162
# LaunchDarkly will override these at runtime
161163
# Production (conservative) defaults - override in dev/exp builds as needed
162164
# =============================================================================
163-
_remote_feature_flags: &remote_feature_flags
164-
# Bitcoin/Tron/Multichain accounts (prod LD values — each uses a custom type-guard validator)
165+
_remote_feature_flags:
166+
&remote_feature_flags # Bitcoin/Tron/Multichain accounts (prod LD values — each uses a custom type-guard validator)
165167
bitcoinAccounts:
166168
enabled: true
167169
minimumVersion: '7.59.0'
@@ -580,4 +582,3 @@ builds:
580582
MM_CARD_BAANX_API_CLIENT_KEY: MM_CARD_BAANX_API_CLIENT_KEY_UAT
581583
code_fencing: *code_fencing_main
582584
remote_feature_flags: *remote_feature_flags
583-

0 commit comments

Comments
 (0)