Skip to content

Commit a2df8f0

Browse files
committed
feat: fix breaking tests
1 parent 665cde6 commit a2df8f0

File tree

2 files changed

+19
-10
lines changed

2 files changed

+19
-10
lines changed

app/components/UI/Earn/components/Musd/MusdConversionAssetOverviewCta/MusdConversionAssetOverviewCta.test.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,7 @@ describe('MusdConversionAssetOverviewCta', () => {
4545
jest.mocked(useMusdConversionTokens).mockReturnValue({
4646
isMusdSupportedOnChain: jest.fn().mockReturnValue(true),
4747
isConversionToken: jest.fn().mockReturnValue(false),
48-
isTokenWithCta: jest.fn().mockReturnValue(false),
4948
tokens: [],
50-
tokensWithCTAs: [],
5149
filterAllowedTokens: jest.fn(),
5250
getMusdOutputChainId: jest
5351
.fn()

app/components/UI/Tokens/TokenList/TokenListItem/TokenListItem.test.tsx

Lines changed: 19 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import {
1212
SECONDARY_BALANCE_TEST_ID,
1313
} from '../../../AssetElement/index.constants';
1414
import renderWithProvider from '../../../../../util/test/renderWithProvider';
15-
import { fireEvent, waitFor } from '@testing-library/react-native';
15+
import { act, fireEvent, waitFor } from '@testing-library/react-native';
1616
import Routes from '../../../../../constants/navigation/Routes';
1717
import { toHex } from '@metamask/controller-utils';
1818

@@ -78,6 +78,13 @@ const mockUseMusdConversionTokens =
7878
typeof useMusdConversionTokens
7979
>;
8080

81+
const mockShouldShowTokenListItemCta = jest.fn();
82+
jest.mock('../../../Earn/hooks/useMusdCtaVisibility', () => ({
83+
useMusdCtaVisibility: () => ({
84+
shouldShowTokenListItemCta: mockShouldShowTokenListItemCta,
85+
}),
86+
}));
87+
8188
jest.mock('../../../../../selectors/earnController/earn', () => ({
8289
earnSelectors: {
8390
selectPrimaryEarnExperienceTypeForAsset: jest.fn(() => 'pooled-staking'),
@@ -231,15 +238,17 @@ describe('TokenListItem - Component Rendering Tests for Coverage', () => {
231238
}: PrepareMocksOptions = {}) {
232239
jest.clearAllMocks();
233240

241+
mockShouldShowTokenListItemCta.mockReturnValue(
242+
isMusdConversionEnabled && isTokenWithCta,
243+
);
244+
234245
// mUSD conversion mocks
235246
mockSelectIsMusdConversionFlowEnabledFlag.mockReturnValue(
236247
isMusdConversionEnabled,
237248
);
238249
mockUseMusdConversionTokens.mockReturnValue({
239250
isConversionToken: jest.fn().mockReturnValue(false),
240251
getMusdOutputChainId: jest.fn().mockReturnValue('0xe708'),
241-
isTokenWithCta: jest.fn().mockReturnValue(isTokenWithCta),
242-
tokensWithCTAs: [],
243252
filterAllowedTokens: jest.fn(),
244253
isMusdSupportedOnChain: jest.fn().mockReturnValue(true),
245254
tokens: [],
@@ -320,10 +329,10 @@ describe('TokenListItem - Component Rendering Tests for Coverage', () => {
320329
/>,
321330
);
322331

323-
expect(getByText('Test Token')).toBeDefined();
324-
expect(getByText('$123.00')).toBeDefined();
325-
expect(getByText('1.23 TEST')).toBeDefined();
326-
expect(getByText('+5.67%')).toBeDefined();
332+
expect(getByText('Test Token')).toBeOnTheScreen();
333+
expect(getByText('$123.00')).toBeOnTheScreen();
334+
expect(getByText('1.23 TEST')).toBeOnTheScreen();
335+
expect(getByText('+5.67%')).toBeOnTheScreen();
327336
});
328337
});
329338

@@ -558,7 +567,9 @@ describe('TokenListItem - Component Rendering Tests for Coverage', () => {
558567
/>,
559568
);
560569

561-
fireEvent.press(getByTestId(SECONDARY_BALANCE_BUTTON_TEST_ID));
570+
await act(async () => {
571+
fireEvent.press(getByTestId(SECONDARY_BALANCE_BUTTON_TEST_ID));
572+
});
562573

563574
await waitFor(() => {
564575
expect(mockInitiateConversion).toHaveBeenCalledWith({

0 commit comments

Comments
 (0)