refactor(card): remove cardGeolocation property and selectors (#27747)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Refactors Card-related code so **geolocation is read only from
`GeolocationController`** (`selectGeolocationLocation` →
`engine.backgroundState.GeolocationController.location`) instead of a
duplicated **`geoLocation` field on the card Redux slice** or from
**`getCardholder`**.

**Why**: Geo was stored in multiple places (card slice, async
`getCardholder` + controller messenger). That duplicated state,
complicated the `loadCardholderAccounts` payload, and risked drift. The
single source of truth should be the engine’s GeolocationController.

**What changed**:

- **Card slice (`card/index.ts`)**: Removed `geoLocation` from
`CardSliceState` and initial state; removed writing geo on
`loadCardholderAccounts.fulfilled`; removed **`selectCardGeoLocation`**.
**`selectIsUserInSupportedCardCountry`** now uses
**`selectGeolocationLocation`** instead of card-stored geo.
- **`getCardholder`**: Returns only **`{ cardholderAddresses }`**;
removed parallel `GeolocationController:getGeolocation` call and
**`geoLocation`** from the return type and error paths.
- **Consumers**: **`SignUp`**, **`isBaanxLoginEnabled`** (pure helper +
hook), **`useCardAuthenticationVerification`**, and deeplink handlers
(**`handleCardKycNotification`**, **`handleCardHome`**,
**`handleCardOnboarding`**) now use **`selectGeolocationLocation`**.
**`isBaanxLoginEnabled`** params use **`geolocationLocation`** (and
**`handleCardKycNotification`** passes that key correctly).
- **Tests**: Updated **`SignUp.test.tsx`** (store includes
`engine.backgroundState.GeolocationController` for selectors),
**`card/index.test.ts`**, **`getCardholder.test.ts`**, deeplink handler
tests, **`isBaanxLoginEnabled.test.ts`**, and
**`handleCardKycNotification.test.ts`** (mocks
**`geolocationController`**).

## **Changelog**

CHANGELOG entry: Card geolocation now comes from GeolocationController
only; removed duplicated `geoLocation` from card state and from
`getCardholder` results.

## **Related issues**

Fixes:

## **Manual testing steps**

```gherkin
Feature: Card flows use GeolocationController geo consistently

  Scenario: Card sign-up country prefill from geo
    Given GeolocationController has a supported country code (e.g. US)
    When I open Card sign-up
    Then the country field may prefill from geo and user card location updates as before

  Scenario: Card button / Baanx gating vs supported countries
    Given remote config maps supported countries for Card
    When my location from GeolocationController is in that map and flags allow
    Then Card entry / Baanx login gating behaves as before

  Scenario: Card KYC notification deeplink
    Given I receive a card KYC notification deeplink
    When the handler runs
    Then feature gating still uses geo + flags correctly and navigation still works

  Scenario: Cardholder load
    When cardholder accounts load completes
    Then card slice only updates cardholder list / loaded state (no separate geo field on card)
```

## **Screenshots/Recordings**

No intentional UI copy or layout changes; behavior should match main if
geo from the controller matches previous values.

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I've included tests if applicable
- [x] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Medium risk because it changes the source of truth for geo-based
feature gating and session clearing across onboarding, deeplinks, and
auth verification; incorrect selector wiring or missing engine state
could disable/enable Card flows unexpectedly.
> 
> **Overview**
> **Geolocation is now sourced only from `GeolocationController`.** The
Card slice no longer stores `geoLocation` (and `selectCardGeoLocation`
is removed), and country gating (`selectIsUserInSupportedCardCountry`,
`isBaanxLoginEnabled`, deeplink handlers, and `SignUp`) now reads
`selectGeolocationLocation` instead.
> 
> `getCardholder` is simplified to return only `cardholderAddresses` (no
parallel geolocation fetch), and `useCardAuthenticationVerification`
tightens session-clearing to only reset auth once geolocation is
*loaded* and not `UNKNOWN`. Tests are updated accordingly, including
injecting `engine.backgroundState.GeolocationController.location` into
the test store and updating mocks/expectations throughout.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
8730edb. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Author: Brunonascdev

app/components/UI/Card/components/Onboarding/SignUp.test.tsx

@@ -85,9 +85,25 @@ jest.mock('./OnboardingStep', () => {
 });
 
 // Create test store
-const createTestStore = (initialState = {}) =>
-  configureStore({
+// SignUp reads geoLocation from state.engine.backgroundState.GeolocationController.location
+// via selectGeolocationLocation. Pass { geoLocation: 'US' } etc. to control it.
+const createTestStore = (initialState: Record<string, unknown> = {}) => {
+  const { geoLocation, ...cardState } = initialState;
+  const engineState = {
+    backgroundState: {
+      GeolocationController:
+        typeof geoLocation === 'string' ? { location: geoLocation } : undefined,
+    },
+  };
+
+  return configureStore({
     reducer: {
+      engine: (state = engineState, action = { type: '', payload: null }) => {
+        switch (action.type) {
+          default:
+            return state;
+        }
+      },
       card: (
         state = {
           onboarding: {
@@ -97,8 +113,7 @@ const createTestStore = (initialState = {}) =>
             user: null,
           },
           userCardLocation: 'international',
-          geoLocation: 'UNKNOWN',
-          ...initialState,
+          ...cardState,
         },
         action = { type: '', payload: null },
       ) => {
@@ -114,6 +129,7 @@ const createTestStore = (initialState = {}) =>
       },
     },
   });
+};
 
 describe('SignUp Component', () => {
   let store: ReturnType<typeof createTestStore>;

app/components/UI/Card/components/Onboarding/SignUp.tsx

@@ -30,7 +30,6 @@ import { useDebouncedValue } from '../../../../hooks/useDebouncedValue';
 import useEmailVerificationSend from '../../hooks/useEmailVerificationSend';
 import useRegions from '../../hooks/useRegions';
 import {
-  selectCardGeoLocation,
   setContactVerificationId,
   setUserCardLocation,
 } from '../../../../../core/redux/slices/card';
@@ -48,6 +47,7 @@ import {
 import SelectField from './SelectField';
 import { mapCountryToLocation } from '../../util/mapCountryToLocation';
 import type { Region } from '../../types';
+import { selectGeolocationLocation } from '../../../../../selectors/geolocationController';
 
 const SignUp = () => {
   const navigation = useNavigation();
@@ -61,7 +61,7 @@ const SignUp = () => {
   const [isPasswordVisible, setIsPasswordVisible] = useState(false);
   const [selectedCountry, setSelectedCountry] = useState<Region | null>(null);
   const hasAutoSelectedCountry = useRef(false);
-  const geoLocation = useSelector(selectCardGeoLocation);
+  const geoLocation = useSelector(selectGeolocationLocation);
   const {
     signUpRegions,
     getRegionByCode,

app/components/UI/Card/hooks/isBaanxLoginEnabled.test.ts

@@ -11,20 +11,20 @@ const mockUseSelector = useSelector as jest.MockedFunction<typeof useSelector>;
 interface MockSelectorsParams {
   displayCardButtonFeatureFlag: boolean | null | undefined;
   alwaysShowCardButton: boolean | null | undefined;
-  cardGeoLocation: string;
+  geolocationLocation: string;
   cardSupportedCountries: Record<string, boolean> | null | undefined;
 }
 
 const mockSelectors = ({
   displayCardButtonFeatureFlag,
   alwaysShowCardButton,
-  cardGeoLocation,
+  geolocationLocation,
   cardSupportedCountries,
 }: MockSelectorsParams) => {
   mockUseSelector
     .mockReturnValueOnce(displayCardButtonFeatureFlag)
     .mockReturnValueOnce(alwaysShowCardButton)
-    .mockReturnValueOnce(cardGeoLocation)
+    .mockReturnValueOnce(geolocationLocation)
     .mockReturnValueOnce(cardSupportedCountries);
 };
 
@@ -38,7 +38,7 @@ describe('useIsBaanxLoginEnabled', () => {
       mockSelectors({
         displayCardButtonFeatureFlag: false,
         alwaysShowCardButton: true,
-        cardGeoLocation: 'US',
+        geolocationLocation: 'US',
         cardSupportedCountries: { US: false },
       });
 
@@ -51,7 +51,7 @@ describe('useIsBaanxLoginEnabled', () => {
       mockSelectors({
         displayCardButtonFeatureFlag: true,
         alwaysShowCardButton: true,
-        cardGeoLocation: 'XX',
+        geolocationLocation: 'XX',
         cardSupportedCountries: {},
       });
 
@@ -66,7 +66,7 @@ describe('useIsBaanxLoginEnabled', () => {
       mockSelectors({
         displayCardButtonFeatureFlag: true,
         alwaysShowCardButton: false,
-        cardGeoLocation: 'US',
+        geolocationLocation: 'US',
         cardSupportedCountries: { US: true },
       });
 
@@ -79,7 +79,7 @@ describe('useIsBaanxLoginEnabled', () => {
       mockSelectors({
         displayCardButtonFeatureFlag: false,
         alwaysShowCardButton: false,
-        cardGeoLocation: 'US',
+        geolocationLocation: 'US',
         cardSupportedCountries: { US: true },
       });
 
@@ -92,7 +92,7 @@ describe('useIsBaanxLoginEnabled', () => {
       mockSelectors({
         displayCardButtonFeatureFlag: true,
         alwaysShowCardButton: false,
-        cardGeoLocation: 'XX',
+        geolocationLocation: 'XX',
         cardSupportedCountries: { US: true, GB: true },
       });
 
@@ -105,7 +105,7 @@ describe('useIsBaanxLoginEnabled', () => {
       mockSelectors({
         displayCardButtonFeatureFlag: true,
         alwaysShowCardButton: false,
-        cardGeoLocation: 'US',
+        geolocationLocation: 'US',
         cardSupportedCountries: { US: false },
       });
 
@@ -120,7 +120,7 @@ describe('useIsBaanxLoginEnabled', () => {
       mockSelectors({
         displayCardButtonFeatureFlag: null,
         alwaysShowCardButton: null,
-        cardGeoLocation: 'US',
+        geolocationLocation: 'US',
         cardSupportedCountries: null,
       });
 
@@ -133,7 +133,7 @@ describe('useIsBaanxLoginEnabled', () => {
       mockSelectors({
         displayCardButtonFeatureFlag: undefined,
         alwaysShowCardButton: undefined,
-        cardGeoLocation: 'US',
+        geolocationLocation: 'US',
         cardSupportedCountries: undefined,
       });
 
@@ -146,7 +146,7 @@ describe('useIsBaanxLoginEnabled', () => {
       mockSelectors({
         displayCardButtonFeatureFlag: true,
         alwaysShowCardButton: false,
-        cardGeoLocation: 'US',
+        geolocationLocation: 'US',
         cardSupportedCountries: {},
       });
 
@@ -155,11 +155,11 @@ describe('useIsBaanxLoginEnabled', () => {
       expect(result.current).toBe(false);
     });
 
-    it('returns false when cardGeoLocation is empty string', () => {
+    it('returns false when geolocationLocation is empty string', () => {
       mockSelectors({
         displayCardButtonFeatureFlag: true,
         alwaysShowCardButton: false,
-        cardGeoLocation: '',
+        geolocationLocation: '',
         cardSupportedCountries: { US: true },
       });
 
@@ -174,7 +174,7 @@ describe('useIsBaanxLoginEnabled', () => {
       mockSelectors({
         displayCardButtonFeatureFlag: true,
         alwaysShowCardButton: false,
-        cardGeoLocation: 'GB',
+        geolocationLocation: 'GB',
         cardSupportedCountries: { US: true, GB: true, CA: true },
       });
 
@@ -187,7 +187,7 @@ describe('useIsBaanxLoginEnabled', () => {
       mockSelectors({
         displayCardButtonFeatureFlag: true,
         alwaysShowCardButton: false,
-        cardGeoLocation: 'DE',
+        geolocationLocation: 'DE',
         cardSupportedCountries: { US: true, GB: true, CA: true },
       });
 
@@ -201,7 +201,7 @@ describe('useIsBaanxLoginEnabled', () => {
     mockSelectors({
       displayCardButtonFeatureFlag: false,
       alwaysShowCardButton: false,
-      cardGeoLocation: 'US',
+      geolocationLocation: 'US',
       cardSupportedCountries: { US: true },
     });
     const { result, rerender } = renderHook(() => useIsBaanxLoginEnabled());
@@ -211,7 +211,7 @@ describe('useIsBaanxLoginEnabled', () => {
     mockSelectors({
       displayCardButtonFeatureFlag: false,
       alwaysShowCardButton: true,
-      cardGeoLocation: 'US',
+      geolocationLocation: 'US',
       cardSupportedCountries: { US: true },
     });
     rerender();

app/components/UI/Card/hooks/isBaanxLoginEnabled.ts

@@ -3,19 +3,17 @@ import {
   selectCardSupportedCountries,
   selectDisplayCardButtonFeatureFlag,
 } from '../../../../selectors/featureFlagController/card';
-import {
-  selectAlwaysShowCardButton,
-  selectCardGeoLocation,
-} from '../../../../core/redux/slices/card';
+import { selectAlwaysShowCardButton } from '../../../../core/redux/slices/card';
+import { selectGeolocationLocation } from '../../../../selectors/geolocationController';
 
 export const isBaanxLoginEnabled = (params: {
   alwaysShowCardButton: boolean;
-  cardGeoLocation: string;
+  geolocationLocation: string;
   cardSupportedCountries: Record<string, boolean>;
   displayCardButtonFeatureFlag: boolean;
 }) =>
   params.alwaysShowCardButton ||
-  (params.cardSupportedCountries?.[params.cardGeoLocation] === true &&
+  (params.cardSupportedCountries?.[params.geolocationLocation] === true &&
     params.displayCardButtonFeatureFlag) ||
   false;
 
@@ -24,15 +22,15 @@ const useIsBaanxLoginEnabled = () => {
     selectDisplayCardButtonFeatureFlag,
   );
   const alwaysShowCardButton = useSelector(selectAlwaysShowCardButton);
-  const cardGeoLocation = useSelector(selectCardGeoLocation);
+  const geolocationLocation = useSelector(selectGeolocationLocation);
   const cardSupportedCountries = useSelector(selectCardSupportedCountries);
 
   // If user has explicitly enabled the experimental switch,
   // they should have full access to the feature including authentication/onboarding,
   // regardless of the progressive rollout flag state
   return isBaanxLoginEnabled({
     alwaysShowCardButton,
-    cardGeoLocation,
+    geolocationLocation,
     displayCardButtonFeatureFlag,
     cardSupportedCountries: cardSupportedCountries as Record<string, boolean>,
   });

app/components/UI/Card/hooks/useCardAuthenticationVerification.test.ts

@@ -33,23 +33,23 @@ describe('useCardAuthenticationVerification', () => {
 
   /**
    * Sets up mocks for the hook's dependencies.
-   * useSelector is called 3 times in order: userLoggedIn, isAuthenticated, cardGeoLocation
+   * useSelector is called 3 times in order: userLoggedIn, isAuthenticated, geolocationLocation
    */
   const setupMocks = ({
     userLoggedIn,
     isBaanxLoginEnabled,
     isAuthenticated = false,
-    cardGeoLocation = 'UNKNOWN',
+    geolocationLocation = 'UNKNOWN',
   }: {
     userLoggedIn: boolean;
     isBaanxLoginEnabled: boolean;
     isAuthenticated?: boolean;
-    cardGeoLocation?: string;
+    geolocationLocation?: string;
   }) => {
     mockUseSelector
       .mockReturnValueOnce(userLoggedIn)
       .mockReturnValueOnce(isAuthenticated)
-      .mockReturnValueOnce(cardGeoLocation);
+      .mockReturnValueOnce(geolocationLocation);
     mockUseIsBaanxLoginEnabled.mockReturnValue(isBaanxLoginEnabled);
   };
 
@@ -69,7 +69,7 @@ describe('useCardAuthenticationVerification', () => {
     setupMocks({
       userLoggedIn: true,
       isBaanxLoginEnabled: false,
-      cardGeoLocation: 'UNKNOWN',
+      geolocationLocation: 'UNKNOWN',
     });
 
     renderHook(() => useCardAuthenticationVerification());
@@ -172,25 +172,38 @@ describe('useCardAuthenticationVerification', () => {
   });
 
   describe('session clearing when isBaanxLoginEnabled is false', () => {
-    it('does not reset auth when geoLocation is UNKNOWN (transient geo failure)', () => {
+    it('does not reset auth when geolocationLocation is UNKNOWN (transient geo failure)', () => {
       setupMocks({
         userLoggedIn: true,
         isBaanxLoginEnabled: false,
         isAuthenticated: true,
-        cardGeoLocation: 'UNKNOWN',
+        geolocationLocation: 'UNKNOWN',
       });
 
       renderHook(() => useCardAuthenticationVerification());
 
       expect(mockDispatch).not.toHaveBeenCalled();
     });
 
-    it('resets auth when geoLocation is resolved and feature is disabled for that region', () => {
+    it('does not reset auth when geolocationLocation is undefined (geo not loaded yet)', () => {
       setupMocks({
         userLoggedIn: true,
         isBaanxLoginEnabled: false,
         isAuthenticated: true,
-        cardGeoLocation: 'FR',
+        geolocationLocation: undefined,
+      });
+
+      renderHook(() => useCardAuthenticationVerification());
+
+      expect(mockDispatch).not.toHaveBeenCalled();
+    });
+
+    it('resets auth when geolocationLocation is resolved and feature is disabled for that region', () => {
+      setupMocks({
+        userLoggedIn: true,
+        isBaanxLoginEnabled: false,
+        isAuthenticated: true,
+        geolocationLocation: 'FR',
       });
 
       renderHook(() => useCardAuthenticationVerification());
@@ -203,7 +216,7 @@ describe('useCardAuthenticationVerification', () => {
         userLoggedIn: true,
         isBaanxLoginEnabled: false,
         isAuthenticated: false,
-        cardGeoLocation: 'FR',
+        geolocationLocation: 'FR',
       });
 
       renderHook(() => useCardAuthenticationVerification());
@@ -217,7 +230,7 @@ describe('useCardAuthenticationVerification', () => {
         userLoggedIn: true,
         isBaanxLoginEnabled: true,
         isAuthenticated: true,
-        cardGeoLocation: 'US',
+        geolocationLocation: 'US',
       });
       const { rerender } = renderHook(() =>
         useCardAuthenticationVerification(),
@@ -232,7 +245,7 @@ describe('useCardAuthenticationVerification', () => {
         userLoggedIn: true,
         isBaanxLoginEnabled: false,
         isAuthenticated: true,
-        cardGeoLocation: 'UNKNOWN',
+        geolocationLocation: 'UNKNOWN',
       });
       rerender();
 
@@ -245,7 +258,7 @@ describe('useCardAuthenticationVerification', () => {
         userLoggedIn: true,
         isBaanxLoginEnabled: false,
         isAuthenticated: true,
-        cardGeoLocation: 'UNKNOWN',
+        geolocationLocation: 'UNKNOWN',
       });
       const { rerender } = renderHook(() =>
         useCardAuthenticationVerification(),
@@ -258,7 +271,7 @@ describe('useCardAuthenticationVerification', () => {
         userLoggedIn: true,
         isBaanxLoginEnabled: false,
         isAuthenticated: true,
-        cardGeoLocation: 'FR',
+        geolocationLocation: 'FR',
       });
       rerender();