Skip to content

Commit a98213c

Browse files
chore(analytics): sweep saveDataRecording from bridge-controller test mocks (#31994)
## **Description** Removes `saveDataRecording: false` from the inline `build()` return value in `bridge-controller-init.test.ts`. The field was stale after the legacy `saveDataRecording` chain was removed in N8 (#31256). This is **PR-D of 6** in the owner-scoped sequence finishing the legacy MetaMetrics migration (#26820). PRs A–E are parallel mock-sweeps; PR-F does the interface removal once all five merge. ## **Changelog** CHANGELOG entry: null ## **Related issues** Refs: #26820 ## **Manual testing steps** N/A — test mock cleanup only; unit tests cover the changed file. ## **Screenshots/Recordings** ### **Before** N/A ### **After** N/A ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. #### Performance checks (if applicable) - [x] I've tested on Android - Ideally on a mid-range device; emulator is acceptable - [x] I've tested with a power user scenario - Use these [power-user SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93) to import wallets with many accounts and tokens - [x] I've instrumented key operations with Sentry traces for production performance metrics - See [`trace()`](/app/util/trace.ts) for usage and [`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274) for an example ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Test-only mock cleanup with no production or analytics runtime changes. > > **Overview** > Removes the obsolete **`saveDataRecording: false`** field from the `AnalyticsEventBuilder` `build()` mock in **`bridge-controller-init.test.ts`**, aligning the test stub with **`AnalyticsTrackingEvent`** after the legacy `saveDataRecording` chain was dropped (N8 / #31256). > > This is **PR-D** in the owner-scoped mock sweep ahead of removing the field from the analytics interface (#26820); runtime bridge init and metrics behavior are unchanged. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 263cde4. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Cursor <cursoragent@cursor.com>
1 parent 159d9ed commit a98213c

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

app/core/Engine/controllers/bridge-controller/bridge-controller-init.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,6 @@ describe('BridgeController Init', () => {
105105
name: 'mock-event',
106106
properties: {},
107107
sensitiveProperties: {},
108-
saveDataRecording: false,
109108
get isAnonymous(): boolean {
110109
return false;
111110
},

0 commit comments

Comments
 (0)