Skip to content

Commit ab2e5a8

Browse files
authored
feat: update ramp data flow to fetch cryptos before payment methods (#14437)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This is a UX upgrade to the ramp flow. It swaps the importance of the payment method and crypto. - removes payment method step from first time flow and after region change - auto-selects the payment method - shows all cryptos in the list - switches payment method to a valid one if the chosen one doesn't support the new selected crypto <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Related issues** Fixes: ## **Manual testing steps** 1. reset ramp region in settings, then visit ramps experience. confirm that payment method selection page is removed 2. choose a payment with low token-availability (like paypal-staging). then pick a token you know is unsupported (like SNX). Confirm that the payment method is changed 3. confirm that various other similar user interactions such as changing region, crypto, fiat and payment method always lead to an expected result without error. ## **Screenshots/Recordings** Video demonstration of the feature: https://www.loom.com/share/fe29b773bb8f46afab8c4a6dadfc59ba <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
1 parent b7f37c0 commit ab2e5a8

18 files changed

+61
-11748
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1010
### Added
1111

1212
- feat(multi-srp): enable multi-srp in main and beta ([#14558](https://github.com/MetaMask/metamask-mobile/pull/14558))
13+
- feat(ramp): Update ramp data flow to fetch cryptos before payment methods ([#14437](https://github.com/MetaMask/metamask-mobile/pull/14437))
1314
- feat(bridge): add destination account picker ([#14656](https://github.com/MetaMask/metamask-mobile/pull/14656))
1415
- feat(bridge): add Solana assets to bridge token pickers ([#14365](https://github.com/MetaMask/metamask-mobile/pull/14365))
1516
- feat: add AppMetadataController controller ([#14513](https://github.com/MetaMask/metamask-mobile/pull/14513))

app/components/UI/Ramp/Views/PaymentMethods/PaymentMethods.constants.ts

-76
This file was deleted.

0 commit comments

Comments
 (0)