Commit ab46059
authored
chore: remove token list item v2 flag (#27731)
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->
## **Description**
Remove token list item V2 FF and token list item V1
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->
## **Changelog**
<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`
If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`
(This helps the Release Engineer do their job more quickly and
accurately)
-->
CHANGELOG entry: remove token list item V2 FF and token list item V1
## **Related issues**
Fixes: https://consensyssoftware.atlassian.net/browse/ASSETS-2951
## **Manual testing steps**
```gherkin
Feature: my feature name
Scenario: user [verb for user action]
Given [describe expected initial app state]
When user [verb for user action]
Then [describe expected outcome]
```
## **Screenshots/Recordings**
<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->
### **Before**
<!-- [screenshots/recordings] -->
### **After**
<!-- [screenshots/recordings] -->
## **Pre-merge author checklist**
- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I've included tests if applicable
- [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
## **Pre-merge reviewer checklist**
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Medium Risk**
> Medium risk because it removes an A/B-gated codepath and replaces the
token row implementation and related analytics attribution, which can
affect wallet token list rendering, navigation, and metrics across
networks (EVM + non-EVM).
>
> **Overview**
> Removes the `tokenListItemV2AbtestVersioned` feature flag and all V2
token list item codepaths, making token lists (`TokenList`,
`TokensSection`) always render `TokenListItem`.
>
> `TokenListItem` is updated to absorb the former V2 layout: it replaces
`AssetElement` with a custom row UI, adds fiat token-price display (EVM
via market data + FX rates; non‑EVM via multichain rates), handles
testnet/"loading" fiat states, and refines secondary-balance behavior
for mUSD conversion and Merkl claim bonus (including claim/CTA
tracking).
>
> Token details analytics attribution is simplified by dropping
token-list-layout A/B test properties from `TOKEN_DETAILS_OPENED`, and
unit tests/feature-flag registry entries are updated accordingly.
>
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
0b37022. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->1 parent fbfbf17 commit ab46059
12 files changed
Lines changed: 711 additions & 2913 deletions
File tree
- app
- components
- UI
- TokenDetails/Views
- Tokens/TokenList
- TokenListItemV2
- TokenListItem
- Views/Homepage/Sections/Tokens
- selectors/featureFlagController/tokenListLayout
- tests/feature-flags
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | 4 | | |
6 | 5 | | |
7 | 6 | | |
| |||
317 | 316 | | |
318 | 317 | | |
319 | 318 | | |
320 | | - | |
321 | 319 | | |
322 | 320 | | |
323 | 321 | | |
| |||
356 | 354 | | |
357 | 355 | | |
358 | 356 | | |
359 | | - | |
| 357 | + | |
360 | 358 | | |
361 | | - | |
362 | | - | |
363 | | - | |
364 | | - | |
365 | | - | |
366 | | - | |
367 | | - | |
368 | | - | |
| 359 | + | |
369 | 360 | | |
370 | 361 | | |
371 | 362 | | |
| |||
378 | 369 | | |
379 | 370 | | |
380 | 371 | | |
381 | | - | |
382 | 372 | | |
383 | 373 | | |
384 | 374 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
77 | 77 | | |
78 | 78 | | |
79 | 79 | | |
80 | | - | |
81 | | - | |
82 | | - | |
83 | | - | |
84 | | - | |
85 | | - | |
86 | | - | |
87 | | - | |
88 | | - | |
89 | | - | |
90 | | - | |
91 | | - | |
92 | | - | |
93 | | - | |
94 | | - | |
95 | | - | |
96 | | - | |
97 | | - | |
98 | | - | |
99 | 80 | | |
100 | 81 | | |
101 | 82 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
21 | 20 | | |
22 | 21 | | |
23 | 22 | | |
| |||
31 | 30 | | |
32 | 31 | | |
33 | 32 | | |
34 | | - | |
35 | 33 | | |
36 | 34 | | |
37 | 35 | | |
| |||
74 | 72 | | |
75 | 73 | | |
76 | 74 | | |
77 | | - | |
78 | | - | |
79 | | - | |
80 | | - | |
81 | 75 | | |
82 | 76 | | |
83 | 77 | | |
| |||
166 | 160 | | |
167 | 161 | | |
168 | 162 | | |
169 | | - | |
| 163 | + | |
170 | 164 | | |
171 | 165 | | |
172 | 166 | | |
| |||
178 | 172 | | |
179 | 173 | | |
180 | 174 | | |
181 | | - | |
182 | 175 | | |
183 | 176 | | |
184 | 177 | | |
| |||
197 | 190 | | |
198 | 191 | | |
199 | 192 | | |
200 | | - | |
| 193 | + | |
201 | 194 | | |
202 | 195 | | |
203 | 196 | | |
| |||
0 commit comments