fix(predict): repair allowances during deposit and withdraw

Author: matallui

app/components/UI/Predict/providers/polymarket/preflight/deposit.ts

@@ -12,7 +12,8 @@ import {
 } from './core';
 import { inspectMissingRequirements } from './inspectMissingRequirements';
 import {
-  getLegacySweepAllowanceRequirements,
+  getActiveV2AllowanceRequirements,
+  getCanonicalV2AllowanceRequirements,
   type V2AllowanceRequirement,
 } from './v2AllowanceRequirements';
 
@@ -37,13 +38,14 @@ export async function planDepositMaintenance({
       address: safeAddress,
       tokenAddress: protocol.collateral.legacyUsdceToken,
     }));
-  const missingRequirements =
+  const requirements =
     preExistingSafeUsdceBalance > 0n
-      ? await inspectMissingRequirements({
-          address: safeAddress,
-          requirements: getLegacySweepAllowanceRequirements(protocol),
-        })
-      : [];
+      ? getCanonicalV2AllowanceRequirements(protocol)
+      : getActiveV2AllowanceRequirements(protocol);
+  const missingRequirements = await inspectMissingRequirements({
+    address: safeAddress,
+    requirements,
+  });
 
   return {
     missingRequirements,

app/components/UI/Predict/providers/polymarket/preflight/withdraw.test.ts

@@ -22,11 +22,16 @@ jest.mock('../utils', () => ({
 
 import { POLYMARKET_V2_PROTOCOL } from '../protocol/definitions';
 import { getRawTokenBalance } from './core';
+import { inspectMissingRequirements } from './inspectMissingRequirements';
 import { planWithdraw } from './withdraw';
 
 const mockGetRawTokenBalance = getRawTokenBalance as jest.MockedFunction<
   typeof getRawTokenBalance
 >;
+const mockInspectMissingRequirements =
+  inspectMissingRequirements as jest.MockedFunction<
+    typeof inspectMissingRequirements
+  >;
 
 const signer = {
   address: '0x1111111111111111111111111111111111111111',
@@ -55,6 +60,18 @@ describe('planWithdraw', () => {
       address: '0x9999999999999999999999999999999999999999',
       tokenAddress: POLYMARKET_V2_PROTOCOL.collateral.legacyUsdceToken,
     });
+    expect(mockInspectMissingRequirements).toHaveBeenCalledWith({
+      address: '0x9999999999999999999999999999999999999999',
+      requirements: expect.arrayContaining([
+        expect.objectContaining({
+          tokenAddress: POLYMARKET_V2_PROTOCOL.collateral.legacyUsdceToken,
+          spender: POLYMARKET_V2_PROTOCOL.collateral.onrampAddress,
+        }),
+        expect.objectContaining({
+          tokenAddress: POLYMARKET_V2_PROTOCOL.collateral.tradingToken,
+        }),
+      ]),
+    });
     expect(plan.transactions.map((transaction) => transaction.to)).toEqual([
       POLYMARKET_V2_PROTOCOL.collateral.onrampAddress,
       POLYMARKET_V2_PROTOCOL.collateral.tradingToken,

app/components/UI/Predict/providers/polymarket/preflight/withdraw.ts

@@ -13,7 +13,8 @@ import {
 } from './core';
 import { inspectMissingRequirements } from './inspectMissingRequirements';
 import {
-  getLegacySweepAllowanceRequirements,
+  getActiveV2AllowanceRequirements,
+  getCanonicalV2AllowanceRequirements,
   type V2AllowanceRequirement,
 } from './v2AllowanceRequirements';
 
@@ -43,13 +44,14 @@ export async function planWithdraw({
       address: safeAddress,
       tokenAddress: protocol.collateral.legacyUsdceToken,
     }));
-  const missingRequirements =
+  const requirements =
     safeLegacyUsdceBalance > 0n
-      ? await inspectMissingRequirements({
-          address: safeAddress,
-          requirements: getLegacySweepAllowanceRequirements(protocol),
-        })
-      : [];
+      ? getCanonicalV2AllowanceRequirements(protocol)
+      : getActiveV2AllowanceRequirements(protocol);
+  const missingRequirements = await inspectMissingRequirements({
+    address: safeAddress,
+    requirements,
+  });
 
   return {
     requestedAmountRaw,

app/components/UI/Predict/providers/polymarket/preflight/workflows.test.ts

@@ -109,6 +109,19 @@ describe('preflight workflow planners', () => {
     );
   });
 
+  it('builds deposit maintenance allowance repairs even without legacy balance', async () => {
+    mockGetRawTokenBalance.mockResolvedValueOnce(0n);
+
+    const plan = await planDepositMaintenance({
+      protocol: POLYMARKET_V2_PROTOCOL,
+      safeAddress: '0x1111111111111111111111111111111111111111',
+    });
+
+    expect(plan.transactions.map((transaction) => transaction.to)).toEqual([
+      '0x1000000000000000000000000000000000000000',
+    ]);
+  });
+
   it('builds claim transactions as repairs, wrap, adapter claim, then exact pUSD gas transfer', async () => {
     mockGetRawTokenBalance.mockResolvedValueOnce(10n).mockResolvedValueOnce(0n);
 
@@ -197,4 +210,20 @@ describe('preflight workflow planners', () => {
       POLYMARKET_V2_PROTOCOL.collateral.tradingToken,
     ]);
   });
+
+  it('builds withdraw allowance repairs even without legacy balance', async () => {
+    mockGetRawTokenBalance.mockResolvedValueOnce(0n);
+
+    const plan = await planWithdraw({
+      protocol: POLYMARKET_V2_PROTOCOL,
+      signer,
+      safeAddress: '0x9999999999999999999999999999999999999999',
+      requestedAmountRaw: BigInt(parseUnits('2', 6).toString()),
+    });
+
+    expect(plan.transactions.map((transaction) => transaction.to)).toEqual([
+      '0x1000000000000000000000000000000000000000',
+      POLYMARKET_V2_PROTOCOL.collateral.tradingToken,
+    ]);
+  });
 });