Skip to content

Commit b3b39aa

Browse files
committed
chore(runway): cherry-pick fix: add missing prop to fix TokenListItem test (#25559)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** TokenListItem tests are failing. https://github.com/MetaMask/metamask-mobile/actions/runs/21614511374/job/62290254653?pr=25557 This is a fix. ``` Error: app/components/UI/Tokens/TokenList/TokenListItem/TokenListItem.test.tsx(1043,10): error TS2741: Property 'shouldShowTokenListItemCta' is missing in type '{ assetKey: FlashListAssetKey; showRemoveMenu: Mock<any, any, any>; setShowScamWarningModal: Mock<any, any, any>; privacyMode: false; }' but required in type 'TokenListItemProps'. Error: app/components/UI/Tokens/TokenList/TokenListItem/TokenListItem.test.tsx(1070,10): error TS2741: Property 'shouldShowTokenListItemCta' is missing in type '{ assetKey: FlashListAssetKey; showRemoveMenu: Mock<any, any, any>; setShowScamWarningModal: Mock<any, any, any>; privacyMode: false; }' but required in type 'TokenListItemProps'. Error: Process completed with exit code 2. ``` <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Fixes: ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I've included tests if applicable - [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk: test-only change that wires a newly-required prop into `TokenListItem` render calls, with no runtime behavior impact. > > **Overview** > Fixes failing `TokenListItem` unit tests by passing the required `shouldShowTokenListItemCta` prop in the stablecoin lending CTA scenarios, aligning the test renders with the updated `TokenListItemProps` type. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 571ac1c. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent 4c150e4 commit b3b39aa

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

app/components/UI/Tokens/TokenList/TokenListItem/TokenListItem.test.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1044,6 +1044,7 @@ describe('TokenListItem - Component Rendering Tests for Coverage', () => {
10441044
assetKey={assetKey}
10451045
showRemoveMenu={jest.fn()}
10461046
setShowScamWarningModal={jest.fn()}
1047+
shouldShowTokenListItemCta={mockShouldShowTokenListItemCta}
10471048
privacyMode={false}
10481049
/>,
10491050
);
@@ -1071,6 +1072,7 @@ describe('TokenListItem - Component Rendering Tests for Coverage', () => {
10711072
assetKey={assetKey}
10721073
showRemoveMenu={jest.fn()}
10731074
setShowScamWarningModal={jest.fn()}
1075+
shouldShowTokenListItemCta={mockShouldShowTokenListItemCta}
10741076
privacyMode={false}
10751077
/>,
10761078
);

0 commit comments

Comments
 (0)