refactors

Author: bergarces

app/components/UI/Assets/PriceAlerts/Views/CreatePriceAlertView/AbsolutePriceAlertForm.tsx

@@ -64,7 +64,7 @@ const AbsolutePriceAlertForm: React.FC<AbsolutePriceAlertFormProps> = ({
 
   const hasInput = targetAmount !== KEYPAD_EMPTY;
   const targetPrice = useMemo(() => {
-    const parsed = parseFloat(targetAmount);
+    const parsed = Number.parseFloat(targetAmount);
     return Number.isFinite(parsed) ? parsed : 0;
   }, [targetAmount]);
   const hasValidTarget = targetPrice > 0;

app/components/UI/Assets/PriceAlerts/Views/CreatePriceAlertView/PercentChangeAlertForm.tsx

@@ -6,6 +6,10 @@ import {
   Button,
   ButtonVariant,
   FontWeight,
+  Icon,
+  IconColor,
+  IconName,
+  IconSize,
   Text,
   TextColor,
   TextVariant,
@@ -15,11 +19,6 @@ import { strings } from '../../../../../../../locales/i18n';
 import KeypadComponent, {
   type KeypadChangeData,
 } from '../../../../../Base/Keypad';
-import Icon, {
-  IconColor,
-  IconName,
-  IconSize,
-} from '../../../../../../component-library/components/Icons/Icon';
 import AlertAmountInput from '../../components/AlertAmountInput';
 import AlertPeriodToggle from '../../components/AlertPeriodToggle';
 import RecurringToggle from '../../components/RecurringToggle';
@@ -74,7 +73,7 @@ const PercentChangeAlertForm: React.FC<PercentChangeAlertFormProps> = ({
 
   const hasInput = percentAmount !== KEYPAD_EMPTY;
   const percentValue = useMemo(() => {
-    const parsed = parseFloat(percentAmount);
+    const parsed = Number.parseFloat(percentAmount);
     return Number.isFinite(parsed) ? parsed : 0;
   }, [percentAmount]);
   const hasValidPercent = percentValue > 0;
@@ -220,7 +219,9 @@ const PercentChangeAlertForm: React.FC<PercentChangeAlertFormProps> = ({
       <Icon
         name={direction === 'up' ? IconName.TrendUp : IconName.TrendDown}
         size={IconSize.Md}
-        color={direction === 'up' ? IconColor.Success : IconColor.Error}
+        color={
+          direction === 'up' ? IconColor.SuccessDefault : IconColor.ErrorDefault
+        }
       />
     </TouchableOpacity>
   );

app/components/UI/Assets/PriceAlerts/Views/ManagePriceAlertsView/ManagePriceAlertsView.test.tsx

@@ -5,9 +5,9 @@ import { notifyManager } from '@tanstack/query-core';
 import ManagePriceAlertsView from './ManagePriceAlertsView';
 import {
   ManagePriceAlertsTestIds,
+  type AbsolutePriceAlert,
   type Alert,
   type PercentChangeAlert,
-  type PriceAlert,
 } from '../../constants';
 import Routes from '../../../../../../constants/navigation/Routes';
 import { ToastContext } from '../../../../../../component-library/components/Toast';
@@ -82,7 +82,9 @@ jest.mock('../../api', () => ({
   priceAlertsQueryKey: (assetId: string) => ['priceAlerts', assetId],
 }));
 
-const makeAlert = (overrides: Partial<PriceAlert> = {}): PriceAlert => ({
+const makeAlert = (
+  overrides: Partial<AbsolutePriceAlert> = {},
+): AbsolutePriceAlert => ({
   id: 'alert-1',
   userId: 'user-1',
   asset: 'eip155:1/slip44:60',

app/components/UI/Assets/PriceAlerts/api.test.ts

@@ -18,7 +18,11 @@ import {
   useSubmitPriceAlert,
   useSubmitPercentAlert,
 } from './api';
-import type { Alert, PercentChangeAlert, PriceAlert } from './constants';
+import type {
+  AbsolutePriceAlert,
+  Alert,
+  PercentChangeAlert,
+} from './constants';
 
 // Prevents teardown crashes with unstable_batchedUpdates in Jest
 notifyManager.setBatchNotifyFunction((callback: () => void) => {
@@ -248,7 +252,9 @@ describe('priceAlertsQueryKey', () => {
   });
 });
 
-const makeAlert = (overrides: Partial<PriceAlert> = {}): PriceAlert => ({
+const makeAlert = (
+  overrides: Partial<AbsolutePriceAlert> = {},
+): AbsolutePriceAlert => ({
   id: 'alert-1',
   userId: 'user-1',
   asset: 'eip155:1/slip44:60',

app/components/UI/Assets/PriceAlerts/api.ts

@@ -5,7 +5,6 @@ import type {
   Alert,
   AbsolutePriceAlert,
   PercentChangeAlert,
-  PriceAlert,
   SaveAlertParams,
   SavePercentAlertParams,
   UpdateAlertParams,
@@ -114,7 +113,7 @@ export const deleteAlertByType = (alert: Alert): Promise<Response> =>
     ? deletePercentAlert(alert.id)
     : deleteAlert(alert.id);
 
-export const useSubmitPriceAlert = (editingAlert?: PriceAlert) => {
+export const useSubmitPriceAlert = (editingAlert?: AbsolutePriceAlert) => {
   const { mutateAsync, isPending } = useMutation<void, Error, SaveAlertParams>({
     mutationFn: async ({ asset, threshold, recurring }) => {
       const response = editingAlert

app/components/UI/Assets/PriceAlerts/constants.ts

@@ -59,14 +59,6 @@ export interface PercentChangeAlert extends BaseAlert {
 /** Any alert returned by the API. Narrow on `type` before reading period/direction. */
 export type Alert = AbsolutePriceAlert | PercentChangeAlert;
 
-/**
- * @deprecated Prefer {@link Alert} (the discriminated union). Kept as an alias
- * to the absolute-price shape so existing absolute-only call sites keep
- * compiling; older API deployments may omit `type` entirely on this shape
- * (see `normalizeAlert` in `api.ts`).
- */
-export type PriceAlert = AbsolutePriceAlert;
-
 export const PRICE_ALERT_QUICK_PERCENTAGES = [-10, -5, 5, 10] as const;
 
 /**