fix(predict): use parse util to catch errors

Author: matallui

app/components/UI/Predict/controllers/PredictController.ts

@@ -101,6 +101,7 @@ import {
   POLYMARKET_PROVIDER_ID,
 } from '../providers/polymarket/constants';
 import {
+  DEFAULT_FEE_COLLECTION_FLAG,
   DEFAULT_LIVE_SPORTS_FLAG,
   DEFAULT_MARKET_HIGHLIGHTS_FLAG,
 } from '../constants/flags';
@@ -115,8 +116,7 @@ import {
   validatedVersionGatedFeatureFlag,
 } from '../../../../util/remoteFeatureFlag';
 import { unwrapRemoteFeatureFlag } from '../utils/flags';
-import { create } from '@metamask/superstruct';
-import { PredictFeeCollectionSchema } from '../schemas';
+import { parse, PredictFeeCollectionSchema } from '../schemas';
 
 /**
  * State shape for PredictController
@@ -439,11 +439,12 @@ export class PredictController extends BaseController<
         ? rawMarketHighlightsFlag
         : DEFAULT_MARKET_HIGHLIGHTS_FLAG;
 
-    const feeCollection = create(
+    const feeCollection = parse(
       unwrapRemoteFeatureFlag<PredictFeatureFlags['feeCollection']>(
         flags.predictFeeCollection,
       ),
       PredictFeeCollectionSchema,
+      DEFAULT_FEE_COLLECTION_FLAG,
     );
 
     const fakOrdersEnabled =

app/components/UI/Predict/schemas/common.ts

@@ -1,6 +1,7 @@
 import { define } from '@metamask/superstruct';
+import { Hex } from '@metamask/utils';
 
-export const HexSchema = define<`0x${string}`>('Hex', (value) => {
+export const HexSchema = define<Hex>('HexSchema', (value) => {
   if (typeof value !== 'string') {
     return false;
   }

app/components/UI/Predict/schemas/index.ts

@@ -1,2 +1,4 @@
+export { parse } from './utils';
+
 export { HexSchema } from './common';
 export { PredictFeeCollectionSchema } from './flags';

app/components/UI/Predict/schemas/utils.ts

@@ -0,0 +1,20 @@
+import { create, Struct, StructError } from '@metamask/superstruct';
+
+export function parse<T>(
+  value: unknown,
+  schema: Struct<T, unknown>,
+  defaultValue?: T,
+) {
+  try {
+    return create(value, schema);
+  } catch (error) {
+    if (defaultValue !== undefined) {
+      return defaultValue;
+    }
+    if (error instanceof StructError || error instanceof Error) {
+      throw new Error(`Invalid value: ${error.message}`);
+    } else {
+      throw new Error(`Invalid value: ${error}`);
+    }
+  }
+}