test: installs foundry with yarn instead of global install

Author: christopherferreira9

.github/actions/setup-e2e-env/action.yml

@@ -41,10 +41,6 @@ inputs:
     description: JDK distribution to use (only for Android)
     required: false
     default: 'temurin'
-  foundry-version:
-    description: Foundry version to install
-    required: false
-    default: 'v0.3.0'
   android-avd-name:
     description: 'Name of AVD to create and boot (for Android)'
     required: false
@@ -231,22 +227,10 @@ runs:
 
     - name: Install Foundry
       shell: bash
-      env:
-        FOUNDRY_VERSION: ${{ inputs.foundry-version }}
       run: |
-        echo "Installing Foundry via foundryup..."
-
-        export FOUNDRY_DIR="${XDG_CONFIG_HOME:-$HOME/.config}/.foundry"
-        export FOUNDRY_BIN="$FOUNDRY_DIR/bin"
-
-        mkdir -p "$FOUNDRY_BIN"
-
-        curl -sL https://raw.githubusercontent.com/foundry-rs/foundry/master/foundryup/foundryup -o "$FOUNDRY_BIN/foundryup"
-        chmod +x "$FOUNDRY_BIN/foundryup"
-
-        echo "$FOUNDRY_BIN" >> "$GITHUB_PATH"
-
-        "$FOUNDRY_BIN/foundryup" -i "$FOUNDRY_VERSION"
+        echo "Installing Foundry via yarn install:foundryup (matches local dev and tests/seeder)..."
+        yarn install:foundryup
+        echo "$GITHUB_WORKSPACE/node_modules/.bin" >> "$GITHUB_PATH"
 
     ## iOS Setup ##
 

.github/workflows/build-android-e2e.yml

@@ -45,6 +45,12 @@ jobs:
       - name: Checkout repo
         uses: actions/checkout@v4
 
+      - name: Restore .metamask folder (Foundry download cache for install:foundryup)
+        uses: actions/cache@v4
+        with:
+          path: .metamask
+          key: .metamask-${{ hashFiles('package.json', 'yarn.lock') }}
+
       - name: Setup Android Build Environment
         timeout-minutes: 15
         uses: ./.github/actions/setup-e2e-env
@@ -55,16 +61,6 @@ jobs:
           android-api-level: 36
           target: ${{ inputs.keystore_target }} # qa for taget=main and flask for target=flask
 
-      - name: Restore .metamask folder
-        id: restore-metamask
-        uses: actions/cache@v4
-        with:
-          path: .metamask
-          key: .metamask-${{ hashFiles('package.json', 'yarn.lock') }}
-
-      - name: Install Foundry if cache missed
-        if: steps.restore-metamask.outputs.cache-hit != 'true'
-        run: yarn install:foundryup
       - name: Setup project dependencies with retry
         uses: nick-fields/retry@ce71cc2ab81d554ebbe88c79ab5975992d79ba08 #v3.0.2
         with:

.github/workflows/build-ios-e2e.yml

@@ -96,6 +96,12 @@ jobs:
             ios/build
           key: ${{ runner.os }}-xcode-main-${{ env.XCODE_CACHE_VERSION }}-${{ hashFiles('ios/**/*.{h,m,mm,swift}', 'ios/**/Podfile.lock', 'yarn.lock') }}
 
+      - name: Restore .metamask folder (Foundry download cache for install:foundryup)
+        uses: actions/cache@v4
+        with:
+          path: .metamask
+          key: .metamask-${{ hashFiles('package.json', 'yarn.lock') }}
+
       # Install Node.js, Xcode tools, and other iOS development dependencies
       - name: Installing iOS Environment Setup
         timeout-minutes: 15
@@ -122,16 +128,6 @@ jobs:
       - name: Clean iOS plist files
         run: find ios -name "*.plist" -exec xattr -c {} \;
 
-      - name: Restore .metamask folder
-        id: restore-metamask
-        uses: actions/cache@v4
-        with:
-          path: .metamask
-          key: .metamask-${{ hashFiles('package.json', 'yarn.lock') }}
-
-      - name: Install Foundry if cache missed
-        if: steps.restore-metamask.outputs.cache-hit != 'true'
-        run: yarn install:foundryup
       # Run project setup with retry for better resilience
       - name: Setup project dependencies with retry
         uses: nick-fields/retry@ce71cc2ab81d554ebbe88c79ab5975992d79ba08 #v3.0.2

.github/workflows/run-e2e-workflow.yml

@@ -102,6 +102,12 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v4
 
+      - name: Restore .metamask folder
+        uses: actions/cache@v4
+        with:
+          path: .metamask
+          key: .metamask-${{ hashFiles('package.json', 'yarn.lock') }}
+
       - name: Set up E2E environment
         timeout-minutes: 15
         uses: ./.github/actions/setup-e2e-env

.github/workflows/update-e2e-fixtures.yml

@@ -217,6 +217,12 @@ jobs:
         with:
           ref: ${{ needs.prepare.outputs.BRANCH }}
 
+      - name: Restore .metamask folder (Foundry download cache for install:foundryup)
+        uses: actions/cache@v4
+        with:
+          path: .metamask
+          key: .metamask-${{ hashFiles('package.json', 'yarn.lock') }}
+
       - name: Set up E2E environment
         timeout-minutes: 15
         uses: ./.github/actions/setup-e2e-env