fix: metrics functionality fixes for money account transactions (#29723)

<!--
Please submit this PR as a draft initially.

Do not mark it as "Ready for review" until this PR meets the canonical
Definition of Ready For Review in `docs/readme/ready-for-review.md`.

In short: the template must be materially complete (not just section
titles
present), all status checks must be currently passing, and the only
expected
follow-up commits must be reviewer-driven.
-->

## **Description**

Metrics functionality fixes for money account transactions

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry:

## **Related issues**

Fixes: https://consensyssoftware.atlassian.net/browse/CONF-1341

## **Manual testing steps**

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**
NA

## **Pre-merge author checklist**

<!--
Every checklist item must be consciously assessed before marking this PR
as
"Ready for review". A checked box means you deliberately considered that
responsibility, not that you literally performed every action listed.

Unchecked boxes are ambiguous: they are not an implicit "N/A" and they
are not
a silent "skip". See `docs/readme/ready-for-review.md` for the full
checklist
semantics.
-->

- [X] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [X] I've completed the PR template to the best of my ability
- [X] I've included tests if applicable
- [X] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [X] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

#### Performance checks (if applicable)

- [ ] I've tested on Android
  - Ideally on a mid-range device; emulator is acceptable
- [ ] I've tested with a power user scenario
- Use these [power-user
SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93)
to import wallets with many accounts and tokens
- [ ] I've instrumented key operations with Sentry traces for production
performance metrics
- See [`trace()`](/app/util/trace.ts) for usage and
[`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274)
for an example

For performance guidelines and tooling, see the [Performance
Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers).

## **Pre-merge reviewer checklist**

<!--
Reviewer checklist items follow the same semantics as the author
checklist: an
unchecked box is ambiguous, a checked box means the reviewer consciously
assessed that responsibility. See `docs/readme/ready-for-review.md`.
-->

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Updates transaction-type classification for metrics and activity
filtering, which could affect analytics attribution and visibility of
transactions in activity feeds if mis-tagged. Changes are mostly
additive and covered by new unit tests, but touch shared transaction
metrics utilities.
> 
> **Overview**
> Adds *money account* support to the transaction metrics pipeline by
introducing `MonetizedPrimitive.MoneyAccount`, mapping
`moneyAccountDeposit`/`moneyAccountWithdraw` in `getMonetizedPrimitive`,
and ensuring base `transaction_type` string derivation returns
`money_account_deposit|withdraw` (including when nested).
> 
> Updates MM Pay metrics to treat money account deposit/withdraw as PAY
types and derive `mm_pay_use_case` accordingly, and adjusts the
confirmation UI metrics hook to include
`simulation_sending_assets_total_value` for money account **deposits**
(but not withdraws). Also expands staged A/B test attribution and
activity `PAY_TYPES` filtering to include money account transactions,
with accompanying test coverage.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
bac530a. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Author: jpuri

app/components/Views/confirmations/hooks/pay/useTransactionPayMetrics.test.ts

@@ -234,6 +234,48 @@ describe('useTransactionPayMetrics', () => {
     });
   });
 
+  it('includes simulation_sending_assets_total_value for money account deposit', async () => {
+    useTransactionPayTokenMock.mockReturnValue({
+      payToken: PAY_TOKEN_MOCK,
+      setPayToken: noop,
+    } as ReturnType<typeof useTransactionPayToken>);
+
+    runHook({ type: TransactionType.moneyAccountDeposit });
+
+    await act(async () => noop());
+
+    expect(updateConfirmationMetricMock).toHaveBeenCalledWith({
+      id: transactionIdMock,
+      params: {
+        properties: expect.objectContaining({
+          simulation_sending_assets_total_value: 1.23,
+        }),
+        sensitiveProperties: {},
+      },
+    });
+  });
+
+  it('omits simulation_sending_assets_total_value for money account withdraw', async () => {
+    useTransactionPayTokenMock.mockReturnValue({
+      payToken: PAY_TOKEN_MOCK,
+      setPayToken: noop,
+    } as ReturnType<typeof useTransactionPayToken>);
+
+    runHook({ type: TransactionType.moneyAccountWithdraw });
+
+    await act(async () => noop());
+
+    const calledProps = (
+      updateConfirmationMetricMock.mock.calls[0]?.[0] as {
+        params: { properties: Record<string, unknown> };
+      }
+    )?.params?.properties;
+
+    expect(calledProps).not.toHaveProperty(
+      'simulation_sending_assets_total_value',
+    );
+  });
+
   describe('mm_pay_quote_requested', () => {
     it('is false initially', async () => {
       useTransactionPayTokenMock.mockReturnValue({

app/components/Views/confirmations/hooks/pay/useTransactionPayMetrics.ts

@@ -87,7 +87,10 @@ export function useTransactionPayMetrics() {
   if (
     payToken &&
     (hasTransactionType(transactionMeta, [TransactionType.perpsDeposit]) ||
-      hasTransactionType(transactionMeta, [TransactionType.predictDeposit]))
+      hasTransactionType(transactionMeta, [TransactionType.predictDeposit]) ||
+      hasTransactionType(transactionMeta, [
+        TransactionType.moneyAccountDeposit,
+      ]))
   ) {
     properties.simulation_sending_assets_total_value = sendingValue;
   }

app/core/Analytics/MetaMetrics.types.ts

@@ -161,6 +161,7 @@ export enum MonetizedPrimitive {
   Ramps = 'ramps',
   Predict = 'predict',
   MmPay = 'mm_pay',
+  MoneyAccount = 'money_account',
 }
 
 /**

app/core/Analytics/events/transactions/utils.ts

@@ -23,6 +23,9 @@ export function getMonetizedPrimitive(
     case TransactionType.predictWithdraw:
     case TransactionType.predictClaim:
       return MonetizedPrimitive.Predict;
+    case TransactionType.moneyAccountDeposit:
+    case TransactionType.moneyAccountWithdraw:
+      return MonetizedPrimitive.MoneyAccount;
     default:
       return undefined;
   }

app/core/Engine/controllers/transaction-controller/metrics_properties/base.test.ts

@@ -104,6 +104,8 @@ describe('getTransactionTypeValue', () => {
     ['predict_deposit', TransactionType.predictDeposit],
     ['predict_withdraw', TransactionType.predictWithdraw],
     ['perps_withdraw', TransactionType.perpsWithdraw],
+    ['money_account_deposit', TransactionType.moneyAccountDeposit],
+    ['money_account_withdraw', TransactionType.moneyAccountWithdraw],
     ['musd_conversion', TransactionType.musdConversion],
     ['musd_claim', TransactionType.musdClaim],
   ])('returns %s if nested transaction type is %s', (expected, nestedType) => {

app/core/Engine/controllers/transaction-controller/metrics_properties/base.ts

@@ -74,6 +74,18 @@ export function getTransactionTypeValue(
     return 'predict_claim';
   }
 
+  if (
+    hasTransactionType(transactionMeta, [TransactionType.moneyAccountDeposit])
+  ) {
+    return 'money_account_deposit';
+  }
+
+  if (
+    hasTransactionType(transactionMeta, [TransactionType.moneyAccountWithdraw])
+  ) {
+    return 'money_account_withdraw';
+  }
+
   if (hasTransactionType(transactionMeta, [TransactionType.musdConversion])) {
     return 'musd_conversion';
   }

app/core/Engine/controllers/transaction-controller/metrics_properties/metamask-pay.test.ts

@@ -83,6 +83,75 @@ describe('Metamask Pay Metrics', () => {
     });
   });
 
+  it.each([
+    TransactionType.moneyAccountDeposit,
+    TransactionType.moneyAccountWithdraw,
+  ])('returns nothing if %s without controller state', (type) => {
+    request.transactionMeta.type = type;
+
+    const result = getMetaMaskPayProperties(request);
+
+    expect(result).toStrictEqual({
+      properties: {},
+      sensitiveProperties: {},
+    });
+  });
+
+  it.each([
+    [TransactionType.moneyAccountDeposit, 'money_account_deposit'],
+    [TransactionType.moneyAccountWithdraw, 'money_account_withdraw'],
+  ])(
+    'derives mm_pay_use_case=%s for %s parent',
+    (parentType, expectedUseCase) => {
+      getStateMock.mockReturnValue({
+        engine: {
+          backgroundState: {
+            TokensController: { allTokens: {} },
+            TransactionPayController: {
+              transactionData: {
+                'parent-1': {
+                  paymentToken: { symbol: 'USDC', chainId: '0x1' },
+                  quotes: [{ strategy: TransactionPayStrategy.Relay }],
+                  tokens: [{ skipIfBalance: false, amountUsd: '50' }],
+                  totals: {
+                    targetAmount: { usd: '49.5', fiat: '49.5' },
+                    fees: {
+                      metaMask: { usd: '0', fiat: '0' },
+                      provider: { usd: '0.2', fiat: '0.2' },
+                      sourceNetwork: { estimate: { usd: '0.1', fiat: '0.1' } },
+                      targetNetwork: { usd: '0', fiat: '0' },
+                    },
+                  },
+                },
+              },
+            },
+          },
+        },
+      } as never);
+
+      request.allTransactions = [
+        {
+          id: 'parent-1',
+          type: parentType,
+          metamaskPay: { chainId: '0x1', tokenAddress: '0xA0b8' },
+          requiredTransactionIds: ['child-1'],
+        } as unknown as TransactionMeta,
+      ];
+
+      const result = getMetaMaskPayProperties(request);
+
+      expect(result).toStrictEqual({
+        properties: expect.objectContaining({
+          mm_pay: true,
+          mm_pay_use_case: expectedUseCase,
+          mm_pay_token_selected: 'USDC',
+          mm_pay_chain_selected: '0x1',
+        }),
+        sensitiveProperties: {},
+      });
+    },
+  );
+
   it('derives parent mm_pay_* properties for child transaction from controller state', () => {
     getStateMock.mockReturnValue({
       engine: {

app/core/Engine/controllers/transaction-controller/metrics_properties/metamask-pay.ts

@@ -20,6 +20,8 @@ import { BigNumber } from 'bignumber.js';
 const FOUR_BYTE_SAFE_PROXY_CREATE = '0xa1884d2c';
 
 const PAY_TYPES = [
+  TransactionType.moneyAccountDeposit,
+  TransactionType.moneyAccountWithdraw,
   TransactionType.perpsDeposit,
   TransactionType.perpsWithdraw,
   TransactionType.predictDeposit,
@@ -31,6 +33,8 @@ const USE_CASE_MAP: [TransactionType[], string][] = [
   [[TransactionType.predictDeposit], 'predict_deposit'],
   [[TransactionType.perpsDeposit], 'perps_deposit'],
   [[TransactionType.perpsWithdraw], 'perps_withdraw'],
+  [[TransactionType.moneyAccountDeposit], 'money_account_deposit'],
+  [[TransactionType.moneyAccountWithdraw], 'money_account_withdraw'],
 ];
 
 export const getMetaMaskPayProperties: TransactionMetricsBuilder = ({

app/core/Engine/controllers/transaction-controller/metrics_properties/swap-transaction-ab-tests.test.ts

@@ -108,4 +108,34 @@ describe('getSwapTransactionActiveAbTestProperties', () => {
       sensitiveProperties: {},
     });
   });
+
+  it.each([
+    TransactionType.moneyAccountDeposit,
+    TransactionType.moneyAccountWithdraw,
+  ])('returns active_ab_tests for %s Transaction Added', (type) => {
+    const abTests = [
+      { key: 'homeTMCU470AbtestTrendingSections', value: 'trendingSections' },
+    ];
+    registerTransactionAbTestAttributionForIds([TX_ID], abTests);
+    const request = createMockRequest({
+      transactionMeta: {
+        id: TX_ID,
+        type,
+      } as never,
+    });
+
+    expect(getSwapTransactionActiveAbTestProperties(request)).toEqual({
+      properties: {
+        active_ab_tests: [
+          {
+            key: 'homeTMCU470AbtestTrendingSections',
+            value: 'trendingSections',
+            key_value_pair:
+              'homeTMCU470AbtestTrendingSections=trendingSections',
+          },
+        ],
+      },
+      sensitiveProperties: {},
+    });
+  });
 });

app/core/Engine/controllers/transaction-controller/metrics_properties/swap-transaction-ab-tests.ts

@@ -18,6 +18,8 @@ const TRANSACTION_TYPES_FOR_ACTIVE_AB_TESTS: ReadonlySet<TransactionType> =
     TransactionType.swapApproval,
     TransactionType.swapAndSend,
     TransactionType.bridgeApproval,
+    TransactionType.moneyAccountDeposit,
+    TransactionType.moneyAccountWithdraw,
     TransactionType.perpsAcrossDeposit,
     TransactionType.perpsDeposit,
     TransactionType.perpsDepositAndOrder,