Properly clean up timers

Author: FrederikBolding

app/core/BackgroundBridge/createDupeReqFilterStream.ts

@@ -11,7 +11,7 @@ export const THREE_MINUTES = inMilliseconds(3, Duration.Minute);
 const makeExpirySet = () => {
   const map: Map<string | number | null, number> = new Map();
 
-  setInterval(() => {
+  const timerId = setInterval(() => {
     const cutoffTime = Date.now() - THREE_MINUTES;
 
     for (const [id, timestamp] of map.entries()) {
@@ -37,6 +37,14 @@ const makeExpirySet = () => {
       }
       return false;
     },
+
+    /**
+     * Destroy the set and tear down the underlying timer.
+     */
+    destroy() {
+      map.clear();
+      clearInterval(timerId);
+    },
   };
 };
 
@@ -62,6 +70,10 @@ export default function createDupeReqFilterStream() {
         cb();
       }
     },
+    destroy(error, cb) {
+      seenRequestIds.destroy();
+      cb(error);
+    },
     objectMode: true,
   });
 }