Skip to content

Commit c859ce0

Browse files
authored
fix: recipient list display in send flow cp-7.68.0 (#26771)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Fix recipient list display in send flow. ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: ## **Related issues** Fixes: #26684 ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <img width="396" height="847" alt="Screenshot 2026-03-02 at 5 04 59 PM" src="https://github.com/user-attachments/assets/3b4e8f2d-448c-41a2-bf53-55f2ba2d967c" /> ## **Pre-merge author checklist** - [X] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I've included tests if applicable - [X] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk UI-only change that swaps the row wrapper component and tweaks padding/accessibility; main risk is minor touch/spacing regressions in the recipient list. > > **Overview** > Fixes the recipient list row rendering in the send/confirmation flow by replacing the design-system `ButtonBase` wrapper with React Native `Pressable`. > > Updates the row styling to include horizontal padding (`px-4`) and explicitly sets `accessibilityRole="button"` while preserving the existing pressed/selected background behavior. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit e5b33b4. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent 1a0ed51 commit c859ce0

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

  • app/components/Views/confirmations/components/UI/recipient

app/components/Views/confirmations/components/UI/recipient/recipient.tsx

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
import React, { useCallback } from 'react';
2+
import { Pressable } from 'react-native';
23
import { KeyringAccountType } from '@metamask/keyring-api';
34
import {
45
Box,
56
FontWeight,
67
Text,
78
TextVariant,
8-
ButtonBase,
99
} from '@metamask/design-system-react-native';
1010
import { useTailwind } from '@metamask/design-system-twrnc-preset';
1111

@@ -73,19 +73,20 @@ export function Recipient({
7373
ACCOUNT_TYPE_LABELS[recipient.accountType as KeyringAccountType];
7474

7575
return (
76-
<ButtonBase
76+
<Pressable
7777
testID={
7878
isSelected
7979
? `selected-${recipient.address}`
8080
: `recipient-${recipient.address}`
8181
}
8282
style={({ pressed }) =>
8383
tw.style(
84-
'w-full flex-row items-center justify-between h-18 rounded-none',
84+
'w-full flex-row items-center justify-between h-18 rounded-none px-4',
8585
pressed || isSelected ? 'bg-pressed' : 'bg-transparent',
8686
)
8787
}
8888
onPress={handlePressRecipient}
89+
accessibilityRole="button"
8990
>
9091
<Box twClassName="flex-row items-center">
9192
<Box twClassName="h-12 justify-center">
@@ -120,6 +121,6 @@ export function Recipient({
120121
</Box>
121122
</Box>
122123
</Box>
123-
</ButtonBase>
124+
</Pressable>
124125
);
125126
}

0 commit comments

Comments
 (0)