chore: remove duplication

Author: shane-t

app/components/UI/Money/components/MoneyTransactionDetailsSheet/MoneyTransactionDetailsSheet.tsx

@@ -15,11 +15,6 @@ import { strings } from '../../../../../../locales/i18n';
 import { TransactionDetails } from '../../../../Views/confirmations/components/activity/transaction-details/transaction-details';
 import { useTransactionDetails } from '../../../../Views/confirmations/hooks/activity/useTransactionDetails';
 
-/**
- * Maps each Money/Earn transaction type to its i18n title key.
- * Edit this map to customise detail-sheet titles without touching
- * shared confirmations code.
- */
 const TITLE_KEYS: Partial<Record<TransactionType, string>> = {
   [TransactionType.moneyAccountDeposit]:
     'transaction_details.title.money_account_deposit',
@@ -38,21 +33,14 @@ const TITLE_KEYS: Partial<Record<TransactionType, string>> = {
 function getTitle(tx: TransactionMeta | undefined): string {
   const type =
     tx?.type === TransactionType.batch
-      ? (tx.nestedTransactions?.find((n) => n.type && n.type in TITLE_KEYS)
-          ?.type as TransactionType | undefined) ?? tx.type
+      ? ((tx.nestedTransactions?.find((n) => n.type && n.type in TITLE_KEYS)
+          ?.type as TransactionType | undefined) ?? tx.type)
       : tx?.type;
   return strings(
     (type && TITLE_KEYS[type]) ?? 'transaction_details.title.default',
   );
 }
 
-/**
- * Renders the transaction details screen as a full-screen bottom sheet modal
- * inside the Money modal stack. Because this component is registered as a
- * navigation screen in MoneyModalStack, useTransactionDetails() (and any other
- * hook that calls useRoute/useParams internally) automatically picks up
- * { transactionId } from this screen's route params.
- */
 const MoneyTransactionDetailsSheet = () => {
   const sheetRef = useRef<BottomSheetRef>(null);
   const navigation = useNavigation();

app/components/UI/Money/constants/activityStyles.ts

@@ -4,7 +4,7 @@ import {
 } from '@metamask/transaction-controller';
 import I18n from '../../../../../locales/i18n';
 import { getIntlNumberFormatter } from '../../../../util/intl';
-import { fromTokenMinimalUnit } from '../../../../util/number';
+import { fromTokenMinimalUnit } from '../../../../util/number/bigint';
 
 function formatNumber(num: number): string {
   return getIntlNumberFormatter(I18n.locale, {
@@ -62,8 +62,7 @@ export function isIncomingMoneyTransactionMeta(tx: TransactionMeta): boolean {
   const t = tx.type;
   if (
     t === EvmTransactionType.incoming ||
-    t === EvmTransactionType.moneyAccountDeposit ||
-    t === EvmTransactionType.musdConversion
+    t === EvmTransactionType.moneyAccountDeposit
   ) {
     return true;
   }

app/components/UI/Money/constants/moneyActivityFilters.ts

@@ -7,17 +7,14 @@ export function isMoneyActivityDeposit(tx: TransactionMeta): boolean {
   const t = tx.type;
   if (
     t === TransactionType.incoming ||
-    t === TransactionType.moneyAccountDeposit ||
-    t === TransactionType.musdConversion
+    t === TransactionType.moneyAccountDeposit
   ) {
     return true;
   }
   // EIP-7702 batch deposits: moneyAccountDeposit sits in nestedTransactions
   return (
     tx.nestedTransactions?.some(
-      (nested) =>
-        nested.type === TransactionType.moneyAccountDeposit ||
-        nested.type === TransactionType.musdConversion,
+      (nested) => nested.type === TransactionType.moneyAccountDeposit,
     ) ?? false
   );
 }