chore: remove tokensChainsCache from assets selectors, transactions utils, and test fixtures (#28925)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
Removes all usages of the deprecated `tokensChainsCache` field from
`TokenListController` across the codebase.

This includes:
- Deleting `app/selectors/tokenListController.ts` which exposed
`selectTokenList`, `selectERC20TokensByChain`, and
`selectERC20TokensByChainInternal` — all deprecated selectors that read
from `tokensChainsCache`
- Refactoring `selectAsset` and `assetToToken` in `assets-list.ts` to
source `aggregators` directly from the token stored in `allTokens` (via
`TokensController`) instead of looking it up in `tokensChainsCache`
- Removing the early-return shortcut in `isSmartContractAddress` that
checked `tokensChainsCache` before querying the network
- Removing the `TokenListController.tokensChainsCache` mask from the
Sentry state filter
- Cleaning up all test fixtures and mocks that referenced
`tokensChainsCache`

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: remove tokensChainsCache from assets selectors,
transactions utils, and test fixtures

## **Related issues**

Fixes: https://consensyssoftware.atlassian.net/browse/ASSETS-3058

## **Manual testing steps**

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I've included tests if applicable
- [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

#### Performance checks (if applicable)

- [ ] I've tested on Android
  - Ideally on a mid-range device; emulator is acceptable
- [ ] I've tested with a power user scenario
- Use these [power-user
SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93)
to import wallets with many accounts and tokens
- [ ] I've instrumented key operations with Sentry traces for production
performance metrics
- See [`trace()`](/app/util/trace.ts) for usage and
[`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274)
for an example

For performance guidelines and tooling, see the [Performance
Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers).

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Touches asset-to-token mapping and contract-address detection
behavior; mistakes could cause missing token metadata (e.g.,
`aggregators`) or extra network calls/perf regressions from removing the
cache short-circuit.
> 
> **Overview**
> Removes the deprecated `TokenListController` selectors
(`selectTokenList`, `selectERC20TokensByChain`) and updates
callers/tests to no longer mock or depend on them.
> 
> Updates `selectAsset` in `assets-list` to stop reading
`TokenListController.tokensChainsCache`; `aggregators` (and `rwaData`)
are now sourced from `TokensController.allTokens`, and related state
fixtures/tests are adjusted accordingly.
> 
> Simplifies `isSmartContractAddress` in `util/transactions` by dropping
the mainnet token-cache short-circuit, and cleans up Sentry state
masking to no longer reference `TokenListController.tokensChainsCache`.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
016a367. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Author: juanmigdr

app/components/UI/AssetOverview/TokenDetails/TokenDetails.test.tsx

@@ -9,7 +9,6 @@ import {
   selectEvmTicker,
   selectProviderConfig,
 } from '../../../../selectors/networkController';
-import { selectTokenList } from '../../../../selectors/tokenListController';
 import { selectContractExchangeRates } from '../../../../selectors/tokenRatesController';
 import { backgroundState } from '../../../../util/test/initial-root-state';
 import renderWithProvider from '../../../../util/test/renderWithProvider';
@@ -80,9 +79,6 @@ const mockDAI = {
   hasBalanceError: false,
   chainId: '0x1',
 };
-const mockAssets = {
-  '0x6b175474e89094c44da98b954eedeac495271d0f': mockDAI,
-};
 const mockExchangeRate = 2712.15;
 const mockCurrentCurrency = 'usd';
 const mockContractExchangeRates = {
@@ -172,8 +168,6 @@ describe('TokenDetails', () => {
       }
 
       switch (selectorOrCallback) {
-        case selectTokenList:
-          return mockAssets;
         case selectContractExchangeRates:
           return {};
         case selectConversionRate:
@@ -249,8 +243,6 @@ describe('TokenDetails', () => {
       }
 
       switch (selectorOrCallback) {
-        case selectTokenList:
-          return mockAssets;
         case selectContractExchangeRates:
           return {};
         case selectConversionRate:

app/components/Views/TradeWalletActions/TradeWalletActions.test.tsx

@@ -147,10 +147,6 @@ jest.mock('../../../core/redux/slices/bridge', () => ({
   selectEnabledSourceChains: jest.fn().mockReturnValue([]),
 }));
 
-jest.mock('../../../selectors/tokenListController', () => ({
-  selectTokenList: jest.fn().mockReturnValue([]),
-}));
-
 jest.mock('../../UI/Stake/hooks/useStakingEligibility', () => ({
   __esModule: true,
   default: jest.fn(),

app/components/Views/WalletActions/WalletActions.test.tsx

@@ -132,10 +132,6 @@ jest.mock('../../../core/redux/slices/bridge', () => ({
   selectIsSwapsEnabled: jest.fn().mockReturnValue(true),
 }));
 
-jest.mock('../../../selectors/tokenListController', () => ({
-  selectTokenList: jest.fn().mockReturnValue([]),
-}));
-
 jest.mock('../../UI/Stake/hooks/useStakingEligibility', () => ({
   __esModule: true,
   default: jest.fn(),

app/selectors/assets/assets-list.test.ts

@@ -151,6 +151,7 @@ const mockState = ({
                   decimals: 18,
                   symbol: 'stETH',
                   name: 'Lido Staked Ether',
+                  aggregators: ['UniswapLabs', 'Metamask', 'Aave'],
                   image:
                     'https://static.cx.metamask.io/api/v1/tokenIcons/10/0xae7ab96520de3a18e5e111b5eaab095312d7fe84.png',
                 },
@@ -227,19 +228,6 @@ const mockState = ({
             },
           },
         },
-        TokenListController: {
-          tokensChainsCache: {
-            '0x1': {
-              data: {
-                '0xae7ab96520de3a18e5e111b5eaab095312d7fe84': {
-                  address: '0xae7ab96520de3a18e5e111b5eaab095312d7fe84',
-                  symbol: 'stETH',
-                  aggregators: ['UniswapLabs', 'Metamask', 'Aave'],
-                },
-              },
-            },
-          },
-        },
         MultichainAssetsController: {
           accountsAssets: {
             '2d89e6a0-b4e6-45a8-a707-f10cef143b42': [

app/selectors/assets/assets-list.ts

@@ -496,8 +496,6 @@ export const selectAsset = createSelector(
   [
     selectAssetsBySelectedAccountGroup,
     selectStakedAssets,
-    (state: RootState) =>
-      state.engine.backgroundState.TokenListController.tokensChainsCache,
     selectAllTokens,
     selectSelectedInternalAccountAddress,
     selectSelectedInternalAccountByScope,
@@ -517,7 +515,6 @@ export const selectAsset = createSelector(
   (
     assets,
     stakedAssets,
-    tokensChainsCache,
     allTokens,
     selectedAddress,
     getAccountByScope,
@@ -549,16 +546,17 @@ export const selectAsset = createSelector(
           );
         });
 
-    // Look up rwaData from the original token in allTokens
+    // Look up aggregators and rwaData from the original token in allTokens
     const originalToken = selectedAddress
       ? allTokens?.[chainId as Hex]?.[selectedAddress]?.find(
           (token) => token.address.toLowerCase() === address.toLowerCase(),
         )
       : undefined;
 
+    const aggregators = originalToken?.aggregators;
     const rwaData = (originalToken as TokenI | undefined)?.rwaData;
 
-    return asset ? assetToToken(asset, tokensChainsCache, rwaData) : undefined;
+    return asset ? assetToToken(asset, aggregators, rwaData) : undefined;
   },
 );
 
@@ -568,15 +566,12 @@ const oneHundredths = 0.01;
 // BIP44 MAINTENANCE: Review what fields are really needed
 function assetToToken(
   asset: Asset & { isStaked?: boolean },
-  tokensChainsCache: TokenListState['tokensChainsCache'],
+  aggregators?: string[],
   rwaData?: TokenI['rwaData'],
 ): TokenI {
   return {
     address: asset.assetId,
-    aggregators:
-      ('address' in asset &&
-        tokensChainsCache[asset.chainId]?.data[asset.address]?.aggregators) ||
-      [],
+    aggregators: aggregators ?? [],
     decimals: asset.decimals,
     image: asset.image,
     name: asset.name,

app/selectors/tokenListController.ts

@@ -160,11 +160,6 @@ export const sentryStateMask = {
       SubjectMetadataController: {
         [AllProperties]: false,
       },
-      TokenListController: {
-        tokensChainsCache: {
-          [AllProperties]: false,
-        },
-      },
       TokenRatesController: {
         [AllProperties]: false,
       },

app/util/sentry/utils.ts

@@ -34,7 +34,6 @@ import {
   toTokenMinimalUnit,
 } from '../number';
 import AppConstants from '../../core/AppConstants';
-import { isMainnetByChainId } from '../networks';
 import FIRST_PARTY_CONTRACT_NAMES from '../../constants/first-party-contracts';
 import {
   UINT256_BN_MAX_VALUE,
@@ -512,15 +511,6 @@ export async function isSmartContractAddress(
 
   address = toChecksumAddress(address);
 
-  // If in contract map we don't need to cache it
-  if (
-    isMainnetByChainId(chainId) &&
-    Engine.context.TokenListController.state.tokensChainsCache?.[chainId]
-      ?.data?.[address]
-  ) {
-    return Promise.resolve(true);
-  }
-
   const { NetworkController } = Engine.context;
   const finalNetworkClientId =
     networkClientId ?? NetworkController.findNetworkClientIdByChainId(chainId);

app/util/transactions/index.js

@@ -175,15 +175,6 @@ ENGINE_MOCK.context = {
       provider: {} as Provider,
     }),
   },
-  TokenListController: {
-    state: {
-      tokensChainsCache: {
-        '0x1': {
-          data: [],
-        },
-      },
-    },
-  },
 };
 
 const spyOnQueryMethod = (returnValue: string | undefined) =>
@@ -2638,31 +2629,9 @@ describe('Transactions utils :: isSmartContractAddress', () => {
     expect(result).toBe(false);
   });
 
-  it('returns true when address is in token cache for mainnet', async () => {
-    const address = '0x1234567890123456789012345678901234567890';
-
-    // Mock the Engine context for mainnet with cached token
-    ENGINE_MOCK.context.TokenListController.state.tokensChainsCache = {
-      '0x1': {
-        data: {
-          [address]: { symbol: 'TEST' },
-        },
-      },
-    };
-
-    const result = await isSmartContractAddress(address, '0x1');
-    expect(result).toBe(true);
-  });
-
   it('returns true when contract code is found', async () => {
     const address = '0x1234567890123456789012345678901234567890';
 
-    // Clear token cache
-    ENGINE_MOCK.context.TokenListController.state.tokensChainsCache = {
-      '0x5': { data: {} },
-    };
-
-    // Mock contract code
     spyOnQueryMethod('0x608060405234801561001057600080fd5b50');
 
     const result = await isSmartContractAddress(address, '0x5');
@@ -2672,12 +2641,6 @@ describe('Transactions utils :: isSmartContractAddress', () => {
   it('returns false when no contract code is found', async () => {
     const address = '0x1234567890123456789012345678901234567890';
 
-    // Clear token cache
-    ENGINE_MOCK.context.TokenListController.state.tokensChainsCache = {
-      '0x5': { data: {} },
-    };
-
-    // Mock empty contract code
     spyOnQueryMethod('0x');
 
     const result = await isSmartContractAddress(address, '0x5');
@@ -2688,10 +2651,6 @@ describe('Transactions utils :: isSmartContractAddress', () => {
     const address = '0x1234567890123456789012345678901234567890';
     const customNetworkClientId = 'custom-network';
 
-    ENGINE_MOCK.context.TokenListController.state.tokensChainsCache = {
-      '0x5': { data: {} },
-    };
-
     spyOnQueryMethod('0x608060405234801561001057600080fd5b50');
 
     const result = await isSmartContractAddress(