Skip to content

Commit cadb9d9

Browse files
FrederikBoldingjoaoloureirop
authored andcommitted
fix: Fix Snaps E2E after browser UX changes (#24729)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Fix Snaps E2Es which are currently blocking main due to not being run on an earlier PR which introduced new UX that the E2Es aren't designed for. ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Updates Snap management E2E tests to align with new browser UX. > > - Adds `BrowserView` import and calls `BrowserView.tapCloseBrowserButton()` before navigating to `Settings` in the disable/enable/remove Snap tests to ensure the browser view is closed prior to settings navigation > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit bf0d93d. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent 530b4ce commit cadb9d9

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

e2e/specs/snaps/test-snap-management.spec.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import TestSnaps from '../../pages/Browser/TestSnaps';
77
import SettingsView from '../../pages/Settings/SettingsView';
88
import SnapSettingsView from '../../pages/Settings/SnapSettingsView';
99
import { Assertions } from '../../framework';
10+
import BrowserView from '../../pages/Browser/BrowserView';
1011

1112
jest.setTimeout(150_000);
1213

@@ -35,6 +36,7 @@ describe(FlaskBuildTests('Snap Management Tests'), () => {
3536
skipReactNativeReload: true,
3637
},
3738
async () => {
39+
await BrowserView.tapCloseBrowserButton();
3840
await TabBarComponent.tapSettings();
3941
await SettingsView.tapSnaps();
4042

@@ -64,6 +66,7 @@ describe(FlaskBuildTests('Snap Management Tests'), () => {
6466
skipReactNativeReload: true,
6567
},
6668
async () => {
69+
await BrowserView.tapCloseBrowserButton();
6770
await TabBarComponent.tapSettings();
6871
await SettingsView.tapSnaps();
6972

@@ -94,6 +97,7 @@ describe(FlaskBuildTests('Snap Management Tests'), () => {
9497
skipReactNativeReload: true,
9598
},
9699
async () => {
100+
await BrowserView.tapCloseBrowserButton();
97101
await TabBarComponent.tapSettings();
98102
await SettingsView.tapSnaps();
99103

0 commit comments

Comments
 (0)