Skip to content

Commit ccc1f2d

Browse files
authored
ci: grant contents write permission to expo dev build workflow (#27653)
## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> The `expo-dev-build.yml` workflow was failing validation because it declared `contents: read` while the reusable `build.yml` workflow it calls has a nested job (`update-build-version`) that requests `contents: write`. GitHub Actions validates permissions statically at parse time, so even though the job is skipped when `skip_version_bump: true`, the caller must grant at least the same permission level. This PR upgrades the caller's permission from `contents: read` to `contents: write` to satisfy the static validation. ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Fixes: ## **Manual testing steps** N/A ## **Screenshots/Recordings** ### **Before** N/A ### **After** N/A ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- Generated with the help of the pr-description AI skill --> Made with [Cursor](https://cursor.com) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Moderate risk because it broadens `GITHUB_TOKEN` permissions for the workflow from read to write, though scoped to CI and intended to satisfy reusable workflow permission requirements. > > **Overview** > Updates the `Expo Dev Build` GitHub Actions workflow to request `contents: write` (instead of `contents: read`) so it can call the reusable `build.yml` workflow without failing static permission validation when nested jobs require write access. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 13bc986. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent e7719ba commit ccc1f2d

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

.github/workflows/expo-dev-build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ on:
2020
workflow_dispatch:
2121

2222
permissions:
23-
contents: read
23+
contents: write
2424
id-token: write
2525

2626
jobs:

0 commit comments

Comments
 (0)