chore(ramp): trim headless buy diff

Author: saustrie-consensys

app/components/UI/Ramp/Views/Checkout/Checkout.test.tsx

@@ -725,34 +725,12 @@ describe('Checkout', () => {
         reason: 'completed',
       });
       expect(mockParentPop).toHaveBeenCalled();
-      expect(mockNavigation.reset).not.toHaveBeenCalled();
-      expect(showV2OrderToastMock).not.toHaveBeenCalled();
-    });
-
-    it('still adds the order to Redux and dispatches protect-wallet when headless', async () => {
-      mockGetSession.mockReturnValue({
-        id: 'hs-1',
-        status: 'continued',
-        callbacks: {
-          onOrderCreated: jest.fn(),
-          onError: jest.fn(),
-          onClose: jest.fn(),
-        },
-      });
-      mockUseParams.mockReturnValue(callbackFlowParams);
-
-      const { getByTestId } = renderWithProvider(<Checkout />, {}, true, false);
-
-      await act(async () => {
-        fireEvent.press(getByTestId('trigger-callback-navigation'));
-      });
-
-      await waitFor(() => {
-        expect(mockAddOrder).toHaveBeenCalledWith(mockOrder);
-      });
+      expect(mockAddOrder).toHaveBeenCalledWith(mockOrder);
       expect(mockDispatch).toHaveBeenCalledWith({
         type: 'PROTECT_WALLET_MODAL_VISIBLE',
       });
+      expect(mockNavigation.reset).not.toHaveBeenCalled();
+      expect(showV2OrderToastMock).not.toHaveBeenCalled();
     });
 
     it('swallows consumer onOrderCreated errors and still closes + pops', async () => {

app/components/UI/Ramp/Views/Checkout/Checkout.tsx

@@ -513,9 +513,7 @@ const Checkout = () => {
   const fireClosedRef = useRef<() => void>(() => {
     /* no-op until initialized */
   });
-  const closeHeadlessOnUnmountRef = useRef<() => void>(() => {
-    /* no-op until initialized */
-  });
+  const closeHeadlessOnUnmountRef = useRef<() => void>(() => undefined);
   closeHeadlessOnUnmountRef.current = () => {
     if (!headlessSessionId || hasTerminatedHeadlessSessionRef.current) {
       return;

app/components/UI/Ramp/Views/HeadlessHost/HeadlessHost.styles.ts

@@ -1,16 +1,25 @@
-/* eslint-disable react-native/no-color-literals -- Phase 9.5: Host renders
- * no visible chrome. The container fills the screen so React Navigation has
- * a stack base for resets, but is fully transparent so the consumer's
- * loading UI renders underneath. There is no theme token for "transparent",
- * and the consumer paints the visible surface — the color literal is
- * intentional and does not need a theme equivalent. */
 import { StyleSheet } from 'react-native';
 
 const styleSheet = () =>
   StyleSheet.create({
     container: {
       flex: 1,
-      backgroundColor: 'transparent',
+    },
+    body: {
+      flex: 1,
+      alignItems: 'center',
+      justifyContent: 'center',
+      paddingHorizontal: 24,
+      gap: 16,
+    },
+    spinner: {
+      marginBottom: 8,
+    },
+    text: {
+      textAlign: 'center',
+    },
+    cancelRow: {
+      paddingTop: 12,
     },
   });
 

app/components/UI/Ramp/Views/HeadlessHost/HeadlessHost.test.tsx

@@ -33,18 +33,11 @@ const mockContinueWithQuote = jest.fn();
 const mockUseContinueWithQuoteOptions = jest.fn();
 let mockIsFocused = true;
 
-// Holds the most recent 'beforeRemove' listener registered against the
-// mocked navigation object. Tests fire it directly to exercise the
-// production beforeRemove path without spinning up a real navigator.
-// The listener now reads `e.data.action.type` so it can ignore RESET
-// stack-rebuilds; tests pass an event arg accordingly.
 interface BeforeRemoveEvent {
   data: { action: { type: string } };
 }
 let registeredBeforeRemoveListener: ((e?: BeforeRemoveEvent) => void) | null =
   null;
-// Default event passed when a test wants to simulate a user back/swipe — any
-// non-RESET action type triggers the close path.
 const DEFAULT_GO_BACK_EVENT: BeforeRemoveEvent = {
   data: { action: { type: 'GO_BACK' } },
 };
@@ -214,8 +207,6 @@ describe('HeadlessHost', () => {
     });
 
     it('renders only a transparent container — no header, spinner, or buttons after Phase 9.5', () => {
-      // The Phase 9.5 contract: the consumer (TPC / MMPay) renders all
-      // user-visible loading UI. The Host is a stack base only.
       const session = seedSession(buildAggregatorQuote());
       renderHost({ headlessSessionId: session.id });
       expect(
@@ -225,7 +216,6 @@ describe('HeadlessHost', () => {
         'pointerEvents',
         'none',
       );
-      // No legacy chrome should be present.
       expect(screen.queryByText(/Cancel/i)).not.toBeOnTheScreen();
       expect(screen.queryByText(/Preparing/i)).not.toBeOnTheScreen();
       expect(screen.queryByText(/no longer active/i)).not.toBeOnTheScreen();
@@ -238,8 +228,6 @@ describe('HeadlessHost', () => {
     });
 
     it('renders the transparent container even with no session — no UI affordances surface to the user', () => {
-      // Pre-Phase 9.5 this rendered a "no session" message; the consumer
-      // now owns that surface.
       renderHost({ headlessSessionId: 'headless-buy-not-real' });
       expect(
         screen.getByTestId(HEADLESS_HOST_CONTAINER_TEST_ID),
@@ -342,12 +330,8 @@ describe('HeadlessHost', () => {
     it('skips orchestration when the session has already been cancelled', async () => {
       const quote = buildAggregatorQuote();
       const session = seedSession(quote);
-      // Mark the session terminal *before* the screen mounts: the focus
-      // effect must respect that and avoid a stale re-trigger.
       closeSession(session.id, { reason: 'consumer_cancelled' });
       renderHost({ headlessSessionId: session.id });
-      // No session left → orchestration short-circuits. The consumer
-      // already received onClose from the closeSession call above.
       expect(mockContinueWithQuote).not.toHaveBeenCalled();
     });
   });
@@ -421,13 +405,6 @@ describe('HeadlessHost', () => {
         expect(mockContinueWithQuote).toHaveBeenCalledTimes(1),
       );
       unmount();
-      // Phase 8: unmount fires the dismissal close because the session
-      // had not reached a terminal status. After unmount the session is
-      // gone from the registry, so the .catch's live-session re-read
-      // short-circuits and does not produce a second onClose or an
-      // onError. (The .catch's `cancelled` flag is independent React
-      // unmount-state protection; this test does not exercise it
-      // directly.)
       expect(callbacks.onClose).toHaveBeenCalledTimes(1);
       expect(callbacks.onClose).toHaveBeenCalledWith({
         reason: 'user_dismissed',
@@ -454,8 +431,6 @@ describe('HeadlessHost', () => {
       });
       expect(callbacks.onClose).toHaveBeenCalledWith({ reason: 'unknown' });
       expect(getSession(session.id)).toBeUndefined();
-      // The auth-error path also short-circuits the continue-on-focus effect
-      // — we never want to push EnterEmail again on top of the error message.
       expect(mockContinueWithQuote).not.toHaveBeenCalled();
     });
 
@@ -477,17 +452,12 @@ describe('HeadlessHost', () => {
         },
       );
       renderHost({ headlessSessionId: session.id });
-      // Even though onError throws, the close path still runs and the
-      // session is gone from the registry.
       await waitFor(() => expect(getSession(session.id)).toBeUndefined());
     });
   });
 
   describe('Dismissal (Phase 8 + 9.5)', () => {
     it('registers a beforeRemove listener that synchronously closes the session with user_dismissed', () => {
-      // Phase 9.5 replaces the old visible Cancel/Back buttons with a
-      // navigation listener so the synchronous close still fires when the
-      // user backs out — even with no chrome to render.
       const quote = buildAggregatorQuote();
       const session = seedSession(quote);
       const callbacks = session.callbacks;
@@ -498,7 +468,6 @@ describe('HeadlessHost', () => {
       );
       expect(typeof registeredBeforeRemoveListener).toBe('function');
 
-      // Fire the listener like React Navigation would on a back gesture.
       registeredBeforeRemoveListener?.(DEFAULT_GO_BACK_EVENT);
 
       expect(callbacks.onClose).toHaveBeenCalledTimes(1);
@@ -509,12 +478,6 @@ describe('HeadlessHost', () => {
     });
 
     it('does NOT close the session when beforeRemove fires for a RESET action (stack rebuild guard)', () => {
-      // Cursor Bugbot — useTransakRouting calls navigation.reset() to
-      // re-pin HEADLESS_HOST at the base when moving to VerifyIdentity /
-      // BasicInfo / Checkout / KycWebview. The reset fires beforeRemove on
-      // the OLD instance, but the session is still in flight; closing it
-      // here would prematurely fire onClose({ reason: 'user_dismissed' })
-      // and break the flow.
       const quote = buildAggregatorQuote();
       const session = seedSession(quote);
       const callbacks = session.callbacks;
@@ -526,9 +489,6 @@ describe('HeadlessHost', () => {
       });
 
       expect(callbacks.onClose).not.toHaveBeenCalled();
-      // The session is still live so useTransakRouting's reset can complete
-      // and re-pin the new HEADLESS_HOST without losing the consumer's
-      // callbacks.
       expect(getSession(session.id)).toBeDefined();
     });
 
@@ -565,15 +525,10 @@ describe('HeadlessHost', () => {
         expect(mockContinueWithQuote).toHaveBeenCalledTimes(1),
       );
 
-      // Simulate Phase 6: useTransakRouting / Checkout fires
-      // closeSession({ reason: 'completed' }) after onOrderCreated.
       closeSession(session.id, { reason: 'completed' });
       expect(callbacks.onClose).toHaveBeenCalledTimes(1);
       expect(callbacks.onClose).toHaveBeenCalledWith({ reason: 'completed' });
 
-      // beforeRemove fires too (React Navigation always fires it on screen
-      // removal), then unmount cleanup runs. Both find the session gone and
-      // no-op.
       registeredBeforeRemoveListener?.(DEFAULT_GO_BACK_EVENT);
       unmount();
 
@@ -589,24 +544,19 @@ describe('HeadlessHost', () => {
         nativeFlowError: 'OTP rejected',
       });
 
-      // Phase 7: nativeFlowError handler funnels through failSession →
-      // closeSession({ reason: 'unknown' }, { terminalStatus: 'failed' }).
       expect(callbacks.onClose).toHaveBeenCalledTimes(1);
       expect(callbacks.onClose).toHaveBeenCalledWith({ reason: 'unknown' });
 
       registeredBeforeRemoveListener?.(DEFAULT_GO_BACK_EVENT);
       unmount();
 
-      // Both follow-up paths re-read, see nothing, no-op.
       expect(callbacks.onClose).toHaveBeenCalledTimes(1);
     });
 
     it('no-ops on unmount when the host mounted against an already-terminated session', () => {
       const quote = buildAggregatorQuote();
       const session = seedSession(quote);
       const callbacks = session.callbacks;
-      // Cancel before the screen mounts; the Phase 8 dismissal cleanup must
-      // not produce a spurious second onClose.
       closeSession(session.id, { reason: 'consumer_cancelled' });
       expect(callbacks.onClose).toHaveBeenCalledTimes(1);
       expect(callbacks.onClose).toHaveBeenCalledWith({

app/components/UI/Ramp/Views/HeadlessHost/HeadlessHost.tsx

@@ -36,11 +36,6 @@ import { getQuoteProviderName } from '../../types';
 
 import styleSheet from './HeadlessHost.styles';
 
-/**
- * Test-only anchor for the Host's transparent placeholder. The Host renders
- * no user-visible chrome after Phase 9.5 — every loading / error / cancel
- * surface is owned by the consumer (MetaMask Pay's `TransactionPayController`).
- */
 export const HEADLESS_HOST_CONTAINER_TEST_ID = 'headless-host-container';
 
 export interface HeadlessHostParams {
@@ -63,26 +58,6 @@ export interface HeadlessHostParams {
 export const createHeadlessHostNavDetails =
   createNavigationDetails<HeadlessHostParams>(Routes.RAMP.HEADLESS_HOST);
 
-/**
- * Headless Host screen.
- *
- * After Phase 9.5 the Host is intentionally **invisible** — it renders a
- * transparent placeholder so React Navigation has a stack base for resets,
- * but the consumer (TPC / MMPay) renders the only user-visible loading UI
- * for a headless buy. The Host still picks up the live session by
- * `headlessSessionId` and calls `useContinueWithQuote().continueWithQuote(...)`
- * exactly once on mount (status guard prevents re-entry on the post-OTP auth
- * loop), surfaces `nativeFlowError` (set by OtpCode on routing failure) as
- * `onError('AUTH_FAILED', ...)` and closes the session, and fires
- * `onClose({ reason: 'user_dismissed' })` from two paths.
- *
- * Dismissal: `navigation.addListener('beforeRemove', ...)` catches synchronous
- * user-driven pops of the Host itself (hardware back / iOS swipe-back when the
- * Host is the focused screen, or a programmatic pop targeting it).
- * `useHeadlessSessionDismissal` (Phase 8) catches any other unmount path:
- * stack resets that bypass `beforeRemove`, hot reloads, parent navigator
- * pops, etc. `closeSession` is idempotent so the two are safe to coexist.
- */
 function HeadlessHost() {
   const navigation = useNavigation();
   const isFocused = useIsFocused();
@@ -99,32 +74,8 @@ function HeadlessHost() {
     };
   }, [navigation, isFocused]);
 
-  // Phase 8: defense-in-depth dismissal. The `beforeRemove` listener below
-  // fires the synchronous close on every user-driven exit, so this hook's
-  // unmount cleanup is effectively a no-op in production. Kept because some
-  // flows (hot reload, programmatic stack reset) skip `beforeRemove`.
   useHeadlessSessionDismissal(headlessSessionId);
 
-  // Phase 9.5: replace the old visible Cancel/Back-button handlers with a
-  // navigation listener. `beforeRemove` only fires when *this* screen is
-  // being popped (the listener is per-screen). It catches the common case:
-  // hardware back / iOS swipe-back while the Host is focused, or a
-  // programmatic pop targeting the Host. Other unmount paths
-  // (stack reset, parent pop while a child screen has focus, hot reload)
-  // are caught by `useHeadlessSessionDismissal`'s unmount cleanup above.
-  // closeSession is idempotent: Phase 6 success and Phase 7 errors clear
-  // the session before `beforeRemove` and turn this into a no-op.
-  //
-  // Stack-rebuild guard (Cursor Bugbot): `useTransakRouting` calls
-  // `navigation.reset()` to re-pin HEADLESS_HOST at the base of the stack
-  // when navigating to VerifyIdentity / BasicInfo / Checkout / KycWebview.
-  // The reset action fires `beforeRemove` on the OLD HEADLESS_HOST instance
-  // before re-pinning the new one, but the session is still in flight —
-  // closing it here would prematurely fire `onClose({ reason: 'user_dismissed' })`
-  // and break the flow. Skip the close when the action is a RESET; the
-  // legitimate unmount cases (stack reset that does NOT re-pin the Host,
-  // hot reload) are caught by `useHeadlessSessionDismissal`'s unmount path
-  // with `isHeadlessHostStillInNavigator`.
   useEffect(() => {
     const unsubscribe = navigation.addListener('beforeRemove', (e) => {
       if (e.data.action.type === 'RESET') {
@@ -294,14 +245,6 @@ function HeadlessHost() {
     continueWithQuote,
   ]);
 
-  // The View is intentionally empty — Phase 9.5 hands all visible UI to the
-  // consumer. It must also be touch-transparent: the navigation route exists
-  // only as an orchestration base, so the empty placeholder should not eat
-  // taps/scrolls intended for the consumer surface below.
-  //
-  // We do NOT set `accessibilityElementsHidden` here because there are no
-  // descendants to hide; it would only confuse screen readers about an
-  // already-empty stack base.
   return (
     <View
       testID={HEADLESS_HOST_CONTAINER_TEST_ID}