fix: add user onboarded version [TO-597] (#27573)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

Add onboarding version in onboarding state which track the app version
user used when they created the wallet
It will helps in sentry debugging knowing which version build the wallet
is created




## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: null

## **Related issues**

Fixes:

## **Manual testing steps**

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I've included tests if applicable
- [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.


<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Medium risk because it changes the `setAccountType` action shape and
extends persisted onboarding Redux state, which could break any
unupdated dispatchers/selectors or state rehydration expectations.
> 
> **Overview**
> Adds `onboardingVersion` (e.g., `"7.0.0 (1234)"`) to onboarding Redux
state and wires it into `SET_ACCOUNT_TYPE`/`CLEAR_ACCOUNT_TYPE` so the
app records which build a wallet was created/imported on.
> 
> Updates the onboarding screen to compute the version from
`react-native-device-info` and include it when dispatching
`setAccountType` for create/import/social-login flows, with tests
adjusted/added to assert the new field is stored and cleared.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
ce15ac5. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Author: ieow

app/actions/onboarding/index.test.ts

@@ -46,16 +46,32 @@ describe('Onboarding actions', () => {
 
   describe('setAccountType', () => {
     it('creates an action to set accountType', () => {
-      expect(setAccountType(AccountType.Metamask)).toEqual({
+      const onboardingVersion = '7.0.0 (1234)';
+
+      expect(
+        setAccountType({
+          accountType: AccountType.Metamask,
+          onboardingVersion,
+        }),
+      ).toEqual({
         type: SET_ACCOUNT_TYPE,
         accountType: AccountType.Metamask,
+        onboardingVersion,
       });
     });
 
     it('creates an action with social login account type', () => {
-      expect(setAccountType(AccountType.MetamaskGoogle)).toEqual({
+      const onboardingVersion = '7.0.0 (1234)';
+
+      expect(
+        setAccountType({
+          accountType: AccountType.MetamaskGoogle,
+          onboardingVersion,
+        }),
+      ).toEqual({
         type: SET_ACCOUNT_TYPE,
         accountType: AccountType.MetamaskGoogle,
+        onboardingVersion,
       });
     });
   });

app/actions/onboarding/index.ts

@@ -24,6 +24,7 @@ export interface SetCompletedOnboardingAction {
 interface SetAccountTypeAction {
   type: typeof SET_ACCOUNT_TYPE;
   accountType: AccountType;
+  onboardingVersion: string;
 }
 
 interface ClearAccountTypeAction {
@@ -61,10 +62,14 @@ export function setCompletedOnboarding(
   };
 }
 
-export function setAccountType(accountType: AccountType): SetAccountTypeAction {
+export function setAccountType(params: {
+  accountType: AccountType;
+  onboardingVersion: string;
+}): SetAccountTypeAction {
   return {
     type: SET_ACCOUNT_TYPE,
-    accountType,
+    accountType: params.accountType,
+    onboardingVersion: params.onboardingVersion,
   };
 }
 

app/components/Views/Onboarding/index.test.tsx

@@ -41,6 +41,15 @@ jest.mock('react-native-elevated-view', () => ({
   default: jest.requireActual('react-native').View,
 }));
 
+const MOCK_APP_VERSION = '7.0.0';
+const MOCK_BUILD_NUMBER = '1234';
+const MOCK_ONBOARDING_VERSION = `${MOCK_APP_VERSION} (${MOCK_BUILD_NUMBER})`;
+
+jest.mock('react-native-device-info', () => ({
+  getVersion: jest.fn(() => MOCK_APP_VERSION),
+  getBuildNumber: jest.fn(() => MOCK_BUILD_NUMBER),
+}));
+
 import React from 'react';
 import {
   InteractionManager,
@@ -65,6 +74,7 @@ import { OAuthError, OAuthErrorType } from '../../../core/OAuthService/error';
 import { captureException } from '@sentry/react-native';
 import Logger from '../../../util/Logger';
 import { MIGRATION_ERROR_HAPPENED } from '../../../constants/storage';
+import { AccountType } from '../../../constants/onboarding';
 
 // Mock netinfo - using existing mock
 jest.mock('@react-native-community/netinfo');
@@ -636,6 +646,38 @@ describe('Onboarding', () => {
       );
     });
 
+    it('stores the onboarding version on the first create wallet press', async () => {
+      mockSeedlessOnboardingEnabled.mockReturnValue(false);
+      (StorageWrapper.getItem as jest.Mock).mockResolvedValue(null);
+
+      const { getByTestId, store } = renderScreen(
+        Onboarding,
+        { name: 'Onboarding' },
+        {
+          state: mockInitialState,
+        },
+      );
+
+      const createWalletButton = getByTestId(
+        OnboardingSelectorIDs.NEW_WALLET_BUTTON,
+      );
+
+      await act(async () => {
+        fireEvent.press(createWalletButton);
+        await flushPromises();
+        await flushPromises();
+      });
+
+      await waitFor(() => {
+        expect(store.getState().onboarding).toEqual(
+          expect.objectContaining({
+            accountType: AccountType.Metamask,
+            onboardingVersion: MOCK_ONBOARDING_VERSION,
+          }),
+        );
+      });
+    });
+
     it('navigates to offline error sheet when there is no internet', async () => {
       mockSeedlessOnboardingEnabled.mockReturnValue(true);
       (StorageWrapper.getItem as jest.Mock).mockResolvedValue(null);

app/components/Views/Onboarding/index.tsx

@@ -1,6 +1,7 @@
 import React, {
   useState,
   useEffect,
+  useMemo,
   useRef,
   useCallback,
   useContext,
@@ -104,6 +105,7 @@ import {
 } from '@metamask/design-system-react-native';
 import { useTailwind } from '@metamask/design-system-twrnc-preset';
 
+import { getBuildNumber, getVersion } from 'react-native-device-info';
 interface OnboardingState {
   warningModalVisible: boolean;
   loading: boolean;
@@ -132,6 +134,11 @@ interface OnboardingRouteParams {
 
 const Onboarding = () => {
   const navigation = useNavigation();
+  const onboardingVersion = useMemo(
+    () => `${getVersion()} (${getBuildNumber()})`,
+    [],
+  );
+
   const route =
     useRoute<RouteProp<{ params: OnboardingRouteParams }, 'params'>>();
   const dispatch = useDispatch();
@@ -357,15 +364,27 @@ const Onboarding = () => {
         [PREVIOUS_SCREEN]: ONBOARDING,
         onboardingTraceCtx: onboardingTraceCtx.current,
       });
-      dispatch(setAccountType(AccountType.Metamask));
+      dispatch(
+        setAccountType({
+          accountType: AccountType.Metamask,
+          onboardingVersion,
+        }),
+      );
       track(MetaMetricsEvents.WALLET_SETUP_STARTED, {
         account_type: AccountType.Metamask,
       });
     };
 
     handleExistingUser(action);
     endTrace({ name: TraceName.OnboardingCreateWallet });
-  }, [metrics, navigation, track, handleExistingUser, dispatch]);
+  }, [
+    metrics,
+    navigation,
+    track,
+    handleExistingUser,
+    dispatch,
+    onboardingVersion,
+  ]);
 
   const onPressImport = useCallback(async (): Promise<void> => {
     if (SEEDLESS_ONBOARDING_ENABLED) {
@@ -392,13 +411,25 @@ const Onboarding = () => {
           onboardingTraceCtx: onboardingTraceCtx.current,
         },
       );
-      dispatch(setAccountType(AccountType.Imported));
+      dispatch(
+        setAccountType({
+          accountType: AccountType.Imported,
+          onboardingVersion,
+        }),
+      );
       track(MetaMetricsEvents.WALLET_IMPORT_STARTED, {
         account_type: AccountType.Imported,
       });
     };
     handleExistingUser(action);
-  }, [metrics, navigation, track, handleExistingUser, dispatch]);
+  }, [
+    metrics,
+    navigation,
+    track,
+    handleExistingUser,
+    dispatch,
+    onboardingVersion,
+  ]);
 
   const handlePostSocialLogin = useCallback(
     (
@@ -421,7 +452,7 @@ const Onboarding = () => {
       }
 
       const accountType = getSocialAccountType(provider, result.existingUser);
-      dispatch(setAccountType(accountType));
+      dispatch(setAccountType({ accountType, onboardingVersion }));
 
       track(MetaMetricsEvents.SOCIAL_LOGIN_COMPLETED, {
         account_type: accountType,
@@ -493,7 +524,7 @@ const Onboarding = () => {
         });
       }
     },
-    [navigation, track, dispatch],
+    [navigation, track, dispatch, onboardingVersion],
   );
 
   const handleOAuthLoginError = useCallback(

app/reducers/onboarding/index.test.ts

@@ -47,21 +47,33 @@ describe('onboardingReducer', () => {
   });
 
   it('handles the SET_ACCOUNT_TYPE action', () => {
+    const onboardingVersion = '7.0.0 (1234)';
+
     const action = {
       type: SET_ACCOUNT_TYPE,
       accountType: AccountType.MetamaskGoogle,
+      onboardingVersion,
     } as const;
+
     const state = onboardingReducer(initialState, action);
+
     expect(state.accountType).toBe(AccountType.MetamaskGoogle);
+    expect(state.onboardingVersion).toBe(onboardingVersion);
   });
 
   it('handles the CLEAR_ACCOUNT_TYPE action', () => {
+    const onboardingVersion = '7.0.0 (1234)';
+
     const stateWithAccountType = {
       ...initialState,
       accountType: AccountType.MetamaskGoogle,
+      onboardingVersion,
     };
+
     const action = { type: CLEAR_ACCOUNT_TYPE } as const;
     const state = onboardingReducer(stateWithAccountType, action);
+
     expect(state.accountType).toBeUndefined();
+    expect(state.onboardingVersion).toBeUndefined();
   });
 });

app/reducers/onboarding/index.ts

@@ -15,6 +15,7 @@ export interface OnboardingState {
   events: [ITrackingEvent][];
   completedOnboarding: boolean;
   accountType?: AccountType;
+  onboardingVersion?: string;
 }
 
 export const initialOnboardingState: OnboardingState = {
@@ -51,11 +52,13 @@ const onboardingReducer = (
       return {
         ...state,
         accountType: action.accountType,
+        onboardingVersion: action.onboardingVersion,
       };
     case CLEAR_ACCOUNT_TYPE:
       return {
         ...state,
         accountType: undefined,
+        onboardingVersion: undefined,
       };
     default:
       return state;