refactor(rewards): make outcome toast hook zero-arg, self-contain campaign lookup, guard on opted-in

Co-authored-by: VGR-GIT <vangulckrik@gmail.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: VGR-GIT

app/components/UI/Rewards/RewardsNavigator.tsx

@@ -19,15 +19,12 @@ import CampaignTourStepView from './Views/CampaignTourStepView';
 import { useDispatch, useSelector } from 'react-redux';
 import { selectRewardsSubscriptionId } from '../../../selectors/rewards';
 import {
-  selectCampaigns,
   selectIsRewardsVersionBlocked,
   selectPendingDeeplink,
 } from '../../../reducers/rewards/selectors';
 import { setPendingDeeplink } from '../../../reducers/rewards';
 import { useCandidateSubscriptionId } from './hooks/useCandidateSubscriptionId';
 import { useOndoCampaignEndedOutcomeToast } from './hooks/useOndoCampaignEndedOutcomeToast';
-import { getCampaignStatus } from './components/Campaigns/CampaignTile.utils';
-import { CampaignType } from '../../../core/Engine/controllers/rewards-controller/types';
 import { useNavigation } from '@react-navigation/native';
 import { useTheme } from '../../../util/theme';
 import useRewardsVersionGuard from './hooks/useRewardsVersionGuard';
@@ -40,15 +37,6 @@ const RewardsNavigator: React.FC = () => {
   const subscriptionId = useSelector(selectRewardsSubscriptionId);
   const isVersionBlocked = useSelector(selectIsRewardsVersionBlocked);
   const pendingDeeplink = useSelector(selectPendingDeeplink);
-  const campaigns = useSelector(selectCampaigns);
-  const completeOndoCampaign =
-    subscriptionId && campaigns
-      ? (campaigns.find(
-          (c) =>
-            c.type === CampaignType.ONDO_HOLDING &&
-            getCampaignStatus(c) === 'complete',
-        ) ?? null)
-      : null;
   const dispatch = useDispatch();
   const navigation = useNavigation();
   const { colors } = useTheme();
@@ -68,10 +56,7 @@ const RewardsNavigator: React.FC = () => {
   // Set candidate subscription ID in Redux state when component mounts and account changes
   useCandidateSubscriptionId();
 
-  useOndoCampaignEndedOutcomeToast(
-    completeOndoCampaign?.id ?? undefined,
-    completeOndoCampaign,
-  );
+  useOndoCampaignEndedOutcomeToast();
 
   // Determine initial route - always start with onboarding intro step initially
   const getInitialRoute = () => {

app/components/UI/Rewards/hooks/useOndoCampaignEndedOutcomeToast.ts

@@ -11,34 +11,49 @@ import { IconName } from '../../../../component-library/components/Icons/Icon';
 import { useAppThemeFromContext } from '../../../../util/theme';
 import { strings } from '../../../../../locales/i18n';
 import Routes from '../../../../constants/navigation/Routes';
-import {
-  CampaignType,
-  CampaignDto,
-} from '../../../../core/Engine/controllers/rewards-controller/types';
+import { CampaignType } from '../../../../core/Engine/controllers/rewards-controller/types';
 import { getCampaignStatus } from '../components/Campaigns/CampaignTile.utils';
 import { selectRewardsSubscriptionId } from '../../../../selectors/rewards';
-import { selectIsCampaignOutcomeToastDismissed } from '../../../../reducers/rewards/selectors';
+import {
+  selectCampaigns,
+  selectCampaignParticipantStatusById,
+  selectIsCampaignOutcomeToastDismissed,
+} from '../../../../reducers/rewards/selectors';
 import { dismissCampaignOutcomeToast } from '../../../../reducers/rewards';
 import useRewardsToast from './useRewardsToast';
 import { useOndoCampaignParticipantOutcome } from './useOndoCampaignParticipantOutcome';
 
-export function useOndoCampaignEndedOutcomeToast(
-  campaignId: string | undefined,
-  campaign: CampaignDto | null,
-): void {
+export function useOndoCampaignEndedOutcomeToast(): void {
   const dispatch = useDispatch();
   const navigation = useNavigation();
   const theme = useAppThemeFromContext();
   const { toastRef } = useContext(ToastContext);
   const { showToast } = useRewardsToast();
 
   const subscriptionId = useSelector(selectRewardsSubscriptionId);
+  const campaigns = useSelector(selectCampaigns);
+
+  const campaign =
+    subscriptionId && campaigns
+      ? (campaigns
+          .filter(
+            (c) =>
+              c.type === CampaignType.ONDO_HOLDING &&
+              getCampaignStatus(c) === 'complete',
+          )
+          .sort(
+            (a, b) =>
+              new Date(b.endDate).getTime() - new Date(a.endDate).getTime(),
+          )[0] ?? null)
+      : null;
+
+  const campaignId = campaign?.id;
+  const isOptedIn =
+    useSelector(selectCampaignParticipantStatusById(campaignId))?.optedIn ===
+    true;
 
   const isEligible =
-    campaign?.type === CampaignType.ONDO_HOLDING &&
-    getCampaignStatus(campaign) === 'complete' &&
-    Boolean(subscriptionId) &&
-    Boolean(campaignId);
+    Boolean(subscriptionId) && Boolean(campaignId) && isOptedIn;
 
   const { outcome } = useOndoCampaignParticipantOutcome(
     isEligible ? campaignId : undefined,

app/components/UI/Rewards/hooks/useOndoCampaignParticipantOutcome.ts

@@ -2,7 +2,10 @@ import { useCallback, useEffect, useState } from 'react';
 import { useDispatch, useSelector } from 'react-redux';
 import Engine from '../../../../core/Engine';
 import { selectRewardsSubscriptionId } from '../../../../selectors/rewards';
-import { selectOndoCampaignParticipantOutcomeById } from '../../../../reducers/rewards/selectors';
+import {
+  selectOndoCampaignParticipantOutcomeById,
+  selectCampaignParticipantStatusById,
+} from '../../../../reducers/rewards/selectors';
 import { setOndoCampaignParticipantOutcome } from '../../../../reducers/rewards';
 import type { OndoGmCampaignParticipantOutcomeDto } from '../../../../core/Engine/controllers/rewards-controller/types';
 
@@ -17,6 +20,9 @@ export function useOndoCampaignParticipantOutcome(
 ): UseOndoCampaignParticipantOutcomeResult {
   const dispatch = useDispatch();
   const subscriptionId = useSelector(selectRewardsSubscriptionId);
+  const isOptedIn =
+    useSelector(selectCampaignParticipantStatusById(campaignId))?.optedIn ===
+    true;
   const outcome = useSelector(
     selectOndoCampaignParticipantOutcomeById(
       subscriptionId ?? undefined,
@@ -27,7 +33,7 @@ export function useOndoCampaignParticipantOutcome(
   const [hasError, setHasError] = useState(false);
 
   const fetchOutcome = useCallback(async (): Promise<void> => {
-    if (!subscriptionId || !campaignId) {
+    if (!subscriptionId || !campaignId || !isOptedIn) {
       setIsLoading(false);
       setHasError(false);
       return;
@@ -54,7 +60,7 @@ export function useOndoCampaignParticipantOutcome(
     } finally {
       setIsLoading(false);
     }
-  }, [dispatch, campaignId, subscriptionId]);
+  }, [dispatch, campaignId, subscriptionId, isOptedIn]);
 
   useEffect(() => {
     fetchOutcome();