fix: sonar warnings

Author: grvgoel81

app/components/UI/OptinMetrics/OptinMetrics.navigation.test.tsx

@@ -510,7 +510,7 @@ describe('OptinMetrics — interest questionnaire navigation branching', () => {
               feature: 'qr-sync',
               surface: 'import',
               operation: 'provision_from_metadata',
-              source: 'OptinMetrics',
+              source: 'finalizeOnboardingCompletion',
               syncFlow: 'new_user',
             }),
           }),

app/core/QrSync/completeExistingUserQrSyncImport.ts

@@ -5,10 +5,10 @@ import { showImportFailedSheet } from '../../components/Views/AddDeviceToWallet/
 import Engine from '../Engine';
 import type { AppNavigationProp } from '../NavigationService/types';
 import { isDuplicateMnemonicError } from './duplicateMnemonicError';
+import { QrSyncSyncFlows } from './constants';
 import {
   QrSyncOperations,
   QrSyncSurfaces,
-  QrSyncSyncFlows,
   QrSyncTelemetrySources,
   reportQrSyncFailure,
 } from './qrSyncTelemetry';

app/core/QrSync/qrSyncTelemetry.ts

@@ -8,7 +8,7 @@
 import { addBreadcrumb } from '@sentry/react-native';
 
 import Logger, { type LoggerErrorOptions } from '../../util/Logger';
-import { QrSyncSyncFlows, type QrSyncSyncFlow } from './constants';
+import type { QrSyncSyncFlow } from './constants';
 import type { QrSyncErrorCode, QrSyncPhase } from './types';
 
 /** Sentry tag value for QR sync errors. Query: `feature:qr-sync`. */
@@ -58,13 +58,12 @@ export const QrSyncTelemetrySources = {
   CONTROLLER_IMPORT_REMAINING: 'QrSyncController.importRemainingSecrets',
   CONTROLLER_ENRICH_PRIMARY: 'QrSyncController.enrichPrimaryProvisioningEntry',
   CONTROLLER: 'QrSyncController',
+  FINALIZE_ONBOARDING: 'finalizeOnboardingCompletion',
 } as const;
 
 export type QrSyncTelemetrySource =
   (typeof QrSyncTelemetrySources)[keyof typeof QrSyncTelemetrySources];
 
-export { QrSyncSyncFlows, type QrSyncSyncFlow };
-
 const SENSITIVE_KEY_PATTERN =
   /^(otp|mnemonic|seed|seedPhrase|privateKey|pendingSecretImports|value|p|payload|scannedQr|qrPayload|sessionRequest)$/i;
 
@@ -88,7 +87,7 @@ export interface ReportQrSyncFailureOptions {
   operation: QrSyncOperation;
   errorCode?: QrSyncErrorCode;
   phase?: QrSyncPhase;
-  source?: QrSyncTelemetrySource | string;
+  source?: QrSyncTelemetrySource;
   syncFlow?: QrSyncSyncFlow;
   /** Extra display-only fields — scrubbed before send. */
   extras?: Record<string, unknown>;

app/core/QrSync/services/qr-sync-provisioning-service.ts

@@ -40,7 +40,11 @@ import type {
   QrSyncControllerGetStateAction,
   QrSyncControllerMarkProvisioningFailedAction,
 } from '../controller-types';
-import { QrSyncProvisioningStatuses, QrSyncSecretTypes } from '../constants';
+import {
+  QrSyncProvisioningStatuses,
+  QrSyncSecretTypes,
+  type QrSyncSyncFlow,
+} from '../constants';
 import type {
   QrSyncAccountGroup,
   QrSyncProvisioningMetadata,
@@ -54,7 +58,6 @@ import {
   QrSyncSurfaces,
   QrSyncTelemetrySources,
   reportQrSyncFailure,
-  type QrSyncSyncFlow,
 } from '../qrSyncTelemetry';
 
 const SERVICE_NAME = 'QrSyncProvisioningService' as const;
@@ -133,50 +136,65 @@ export class QrSyncProvisioningService {
   ): Promise<void> {
     for (const secret of secrets) {
       try {
-        if (secret.type === QrSyncSecretTypes.MNEMONIC) {
-          const entropySource = await this.#importMnemonicToVault(secret.value);
-          this.#messenger.call(
-            'QrSyncController:enrichProvisioningEntry',
-            secret.index,
-            { entropySource },
-          );
-        } else if (secret.type === QrSyncSecretTypes.PRIVATE_KEY) {
-          const accountAddress = await this.#importPrivateKeyToVault(
-            secret.value,
-          );
-
-          if (accountAddress) {
-            this.#messenger.call(
-              'QrSyncController:enrichProvisioningEntry',
-              secret.index,
-              { accountAddress },
-            );
-          }
-        } else {
-          const syncFlow = this.#getSessionSyncFlow();
-          reportQrSyncFailure(
-            new Error('QrSyncProvisioningService: Unknown secret type'),
-            {
-              surface: QrSyncSurfaces.IMPORT,
-              operation: QrSyncOperations.IMPORT_SECRETS_UNKNOWN_TYPE,
-              source: QrSyncTelemetrySources.PROVISIONING_IMPORT_SECRETS,
-              ...(syncFlow ? { syncFlow } : {}),
-              extras: { secretType: String(secret.type) },
-            },
-          );
-        }
+        await this.#importSingleSecretToVault(secret);
       } catch (error) {
-        const syncFlow = this.#getSessionSyncFlow();
-        reportQrSyncFailure(error, {
-          surface: QrSyncSurfaces.IMPORT,
-          operation: QrSyncOperations.IMPORT_SECRETS_TO_VAULT,
-          source: QrSyncTelemetrySources.PROVISIONING_IMPORT_SECRETS,
-          ...(syncFlow ? { syncFlow } : {}),
-        });
+        this.#reportImportSecretsFailure(
+          error,
+          QrSyncOperations.IMPORT_SECRETS_TO_VAULT,
+        );
       }
     }
   }
 
+  async #importSingleSecretToVault(
+    secret: QrSyncSecretImportEntry,
+  ): Promise<void> {
+    if (secret.type === QrSyncSecretTypes.MNEMONIC) {
+      const entropySource = await this.#importMnemonicToVault(secret.value);
+      this.#messenger.call(
+        'QrSyncController:enrichProvisioningEntry',
+        secret.index,
+        { entropySource },
+      );
+      return;
+    }
+
+    if (secret.type === QrSyncSecretTypes.PRIVATE_KEY) {
+      const accountAddress = await this.#importPrivateKeyToVault(secret.value);
+      if (accountAddress) {
+        this.#messenger.call(
+          'QrSyncController:enrichProvisioningEntry',
+          secret.index,
+          { accountAddress },
+        );
+      }
+      return;
+    }
+
+    this.#reportImportSecretsFailure(
+      new Error('QrSyncProvisioningService: Unknown secret type'),
+      QrSyncOperations.IMPORT_SECRETS_UNKNOWN_TYPE,
+      { secretType: String(secret.type) },
+    );
+  }
+
+  #reportImportSecretsFailure(
+    error: unknown,
+    operation:
+      | typeof QrSyncOperations.IMPORT_SECRETS_TO_VAULT
+      | typeof QrSyncOperations.IMPORT_SECRETS_UNKNOWN_TYPE,
+    extras?: Record<string, unknown>,
+  ): void {
+    const syncFlow = this.#getSessionSyncFlow();
+    reportQrSyncFailure(error, {
+      surface: QrSyncSurfaces.IMPORT,
+      operation,
+      source: QrSyncTelemetrySources.PROVISIONING_IMPORT_SECRETS,
+      ...(syncFlow ? { syncFlow } : {}),
+      ...(extras ? { extras } : {}),
+    });
+  }
+
   async #importMnemonicToVault(seed: string): Promise<EntropySourceId> {
     const mnemonic = mnemonicPhraseToBytes(seed);
 

app/core/QrSync/useQrSyncImportNavigation.ts

@@ -10,7 +10,7 @@ import {
 } from '../../selectors/qrSyncController';
 import type { AppNavigationProp } from '../NavigationService/types';
 import Engine from '../Engine';
-import { QrSyncSecretTypes } from './constants';
+import { QrSyncSecretTypes, QrSyncSyncFlows } from './constants';
 import { completeExistingUserQrSyncImport } from './completeExistingUserQrSyncImport';
 import { navigateToQrSyncImport } from './navigateToQrSyncImport';
 import { showAlreadySyncedSheet } from '../../components/Views/AddDeviceToWallet/showAlreadySyncedSheet';
@@ -19,7 +19,6 @@ import type { QrSyncSecretImportEntry } from './types';
 import {
   QrSyncOperations,
   QrSyncSurfaces,
-  QrSyncSyncFlows,
   QrSyncTelemetrySources,
   reportQrSyncFailure,
 } from './qrSyncTelemetry';

app/util/onboarding/finalizeOnboardingCompletion.test.ts

@@ -152,7 +152,7 @@ describe('finalizeOnboardingCompletion', () => {
           feature: 'qr-sync',
           surface: 'import',
           operation: 'provision_from_metadata',
-          source: 'TestContext',
+          source: 'finalizeOnboardingCompletion',
           syncFlow: 'new_user',
         }),
       }),

app/util/onboarding/finalizeOnboardingCompletion.ts

@@ -10,10 +10,10 @@ import { getOnboardingCompletedAnalyticsPropsFromSuccessFlow } from '../analytic
 import type { WalletSetupCompletedAttributionAnalyticsPayload } from '../analytics/walletSetupCompletedAttribution';
 import { analytics } from '../analytics/analytics';
 import Logger from '../Logger';
+import { QrSyncSyncFlows } from '../../core/QrSync/constants';
 import {
   QrSyncOperations,
   QrSyncSurfaces,
-  QrSyncSyncFlows,
   QrSyncTelemetrySources,
   reportQrSyncFailure,
 } from '../../core/QrSync/qrSyncTelemetry';
@@ -84,7 +84,7 @@ export function finalizeOnboardingCompletion({
           reportQrSyncFailure(error, {
             surface: QrSyncSurfaces.IMPORT,
             operation: QrSyncOperations.PROVISION_FROM_METADATA,
-            source: discoverAccountsLogContext,
+            source: QrSyncTelemetrySources.FINALIZE_ONBOARDING,
             syncFlow: QrSyncSyncFlows.NEW_USER,
           });
         },