Commit ddb1e5f
authored
chore(runway): cherry-pick fix: cp-7.47.0 fix QR account can't be imported and scan QR code without response (#15886)
- fix: cp-7.47.0 fix QR account can't be imported and scan QR code
without response (#15793)
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->
## **Description**
This PR provide the fix to issue #15685,
The main cause of this issue is because old declaration file
`ur-decode.ts` file override the real implementation inside
`node_modules` @keystonehq/ur-decoder` library. and because the
ur-decode.ts receivePart() method is empty, so AnimatedQRScanner
component unable to get the decoded qr content to complete the
operation.
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->
## **Related issues**
Fixes: #15685
## **Manual testing steps**
1. Click Add account or hardware wallet on android device
2. Click Hardware wallet
3. Select QR-based
4. Click continue
5. Scan the QR code
6. QR account should be listed.
7
## **Screenshots/Recordings**
<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->
### **Before**
<!-- [screenshots/recordings] -->
### **After**
<!-- [screenshots/recordings] -->
## **Pre-merge author checklist**
- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
## **Pre-merge reviewer checklist**
- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
[b488a3c](b488a3c)2 files changed
Lines changed: 1 addition & 1 deletion
File renamed without changes.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
42 | | - | |
| 42 | + | |
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
| |||
0 commit comments