fix: disable CTA swap button for Tron when no network fees retrieved (#32717)

Battambang · web-flow · commit de2614598344 · 2026-07-08T08:10:46.000Z
## **Description**   This pull request updates the logic for determining if a network fee is unavailable for bridge quotes, specifically adding support for Tron chain IDs in addition to Bitcoin. It also expands the test coverage to ensure correct behavior for various Tron-related scenarios. **Logic updates for network fee availability:** * Updated `isQuoteNetworkFeeUnavailable` in `index.ts` to consider both Bitcoin and Tron chain IDs, returning `true` for Tron quotes with missing, zero, or negative network fees. **Test coverage improvements:** * Added multiple test cases in `index.test.ts` to verify that the function correctly handles Tron quotes with zero, negative, missing, and positive network fees, ensuring the new logic is thoroughly tested. * Updated the description of an existing test to clarify that it applies to non-BTC/non-Tron quotes with zero network fee. ## **Changelog**   CHANGELOG entry: disable CTA swap button for Tron when no network fees retrieved ## **Related issues**  Fixes: submit Tron swaps without network fees ## **Manual testing steps**  ```gherkin Go to swap page Try a quote pair for Tron network Make the compute fees from the Tron snap failed or throw in the bridge-status controller. When the network fees are not returned, a 0$ network fees is displayed and the CTA button of the quote should not be enabled with the message "insufficient funds" ``` ## **Screenshots/Recordings**   ### **Before**  n/a ### **After**  <img width="300" height="600" alt="tron-fees" src="https://github.com/user-attachments/assets/d12d1b74-aeb5-4f52-8fc5-71b402e0f6d9" /> ## **Pre-merge author checklist**   - [X] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I've included tests if applicable - [X] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. #### Performance checks (if applicable) - [X] I've tested on Android - Ideally on a mid-range device; emulator is acceptable - [X] I've tested with a power user scenario - Use these [power-user SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93) to import wallets with many accounts and tokens - [X] I've instrumented key operations with Sentry traces for production performance metrics - See [`trace()`](/app/util/trace.ts) for usage and [`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274) for an example For performance guidelines and tooling, see the [Performance Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers). ## **Pre-merge reviewer checklist**  - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.  --- > [!NOTE] > **Medium Risk** > Changes swap submission gating for Tron bridge flows; incorrect fee detection could block valid swaps or still allow bad ones, though behavior mirrors existing Bitcoin safeguards. > > **Overview** > Tron bridge quotes are now treated like Bitcoin when **network fees are missing or invalid**, so users cannot confirm a swap while fees show as $0 after a failed fee fetch. > > `isQuoteNetworkFeeUnavailable` applies the existing BTC rules (missing, zero, or non-positive `totalNetworkFee`) to **Tron source chains** via `isTronChainId`, which keeps the swap CTA disabled in `BridgeView` and `SwapsConfirmButton` instead of allowing submission with bogus fees. Unit tests cover Tron zero, negative, missing, and valid fee cases. > > `@metamask/tron-wallet-snap` is bumped **1.28.0 → 1.29.0** in lockfile alongside the logic change. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 3859859. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup>
diff --git a/app/components/UI/Bridge/hooks/useIsNetworkFeeUnavailable/index.test.ts b/app/components/UI/Bridge/hooks/useIsNetworkFeeUnavailable/index.test.ts
@@ -67,7 +67,7 @@ describe('isQuoteNetworkFeeUnavailable', () => {
     expect(isQuoteNetworkFeeUnavailable(createQuote())).toBe(false);
   });
 
-  it('returns false for a non-BTC quote with zero network fee', () => {
+  it('returns false for a non-BTC/non-Tron quote with zero network fee', () => {
     expect(
       isQuoteNetworkFeeUnavailable(
         createQuote({
@@ -84,6 +84,70 @@ describe('isQuoteNetworkFeeUnavailable', () => {
     ).toBe(false);
   });
 
+  it('returns true for a Tron quote with zero network fee', () => {
+    expect(
+      isQuoteNetworkFeeUnavailable(
+        createQuote({
+          quote: {
+            ...mockQuoteWithMetadata.quote,
+            srcChainId: ChainId.TRON,
+          },
+          totalNetworkFee: {
+            ...mockQuoteWithMetadata.totalNetworkFee,
+            amount: '0',
+          },
+        }),
+      ),
+    ).toBe(true);
+  });
+
+  it('returns true for a Tron quote with negative network fee', () => {
+    expect(
+      isQuoteNetworkFeeUnavailable(
+        createQuote({
+          quote: {
+            ...mockQuoteWithMetadata.quote,
+            srcChainId: ChainId.TRON,
+          },
+          totalNetworkFee: {
+            ...mockQuoteWithMetadata.totalNetworkFee,
+            amount: '-1',
+          },
+        }),
+      ),
+    ).toBe(true);
+  });
+
+  it('returns true for a Tron quote with missing network fee amount', () => {
+    expect(
+      isQuoteNetworkFeeUnavailable(
+        createQuote({
+          quote: {
+            ...mockQuoteWithMetadata.quote,
+            srcChainId: ChainId.TRON,
+          },
+          totalNetworkFee: {
+            ...mockQuoteWithMetadata.totalNetworkFee,
+            amount: undefined,
+          } as unknown as NonNullable<ActiveQuote>['totalNetworkFee'],
+        }),
+      ),
+    ).toBe(true);
+  });
+
+  it('returns false for a Tron quote with positive network fee', () => {
+    expect(
+      isQuoteNetworkFeeUnavailable(
+        createQuote({
+          quote: {
+            ...mockQuoteWithMetadata.quote,
+            srcChainId: ChainId.TRON,
+          },
+        }),
+      ),
+    ).toBe(false);
+  });
+
   it('returns false when the quote has no source chain', () => {
     expect(
       isQuoteNetworkFeeUnavailable(
diff --git a/app/components/UI/Bridge/hooks/useIsNetworkFeeUnavailable/index.ts b/app/components/UI/Bridge/hooks/useIsNetworkFeeUnavailable/index.ts
@@ -1,6 +1,6 @@
 import { useMemo } from 'react';
 import { BigNumber } from 'bignumber.js';
-import { isBitcoinChainId } from '@metamask/bridge-controller';
+import { isBitcoinChainId, isTronChainId } from '@metamask/bridge-controller';
 import { useBridgeQuoteData } from '../useBridgeQuoteData';
 
 type ActiveQuote = ReturnType<typeof useBridgeQuoteData>['activeQuote'];
@@ -10,7 +10,10 @@ export const isQuoteNetworkFeeUnavailable = (
 ): boolean => {
   const sourceChainId = activeQuote?.quote?.srcChainId;
 
-  if (!sourceChainId || !isBitcoinChainId(sourceChainId)) {
+  if (
+    !sourceChainId ||
+    (!isBitcoinChainId(sourceChainId) && !isTronChainId(sourceChainId))
+  ) {
     return false;
   }
 
diff --git a/package.json b/package.json
@@ -356,7 +356,7 @@
     "@metamask/swappable-obj-proxy": "^2.1.0",
     "@metamask/transaction-controller": "^68.2.0",
     "@metamask/transaction-pay-controller": "^23.17.4",
-    "@metamask/tron-wallet-snap": "^1.28.0",
+    "@metamask/tron-wallet-snap": "^1.29.0",
     "@metamask/utils": "^11.11.0",
     "@metamask/wallet": "^6.0.0",
     "@myx-trade/sdk": "^0.1.265",
diff --git a/yarn.lock b/yarn.lock
@@ -10545,10 +10545,10 @@ __metadata:
   languageName: node
   linkType: hard
 
-"@metamask/tron-wallet-snap@npm:^1.28.0":
-  version: 1.28.0
-  resolution: "@metamask/tron-wallet-snap@npm:1.28.0"
-  checksum: 10/e8fe563735e0fca306cd1caa2cde45b193d0f09f7a3da545be24eee55a64f1ff239a7460ad9c4a0c6b67552a1423ef18328350a4b76a2409a1fbe609f69b8769
+"@metamask/tron-wallet-snap@npm:^1.29.0":
+  version: 1.29.0
+  resolution: "@metamask/tron-wallet-snap@npm:1.29.0"
+  checksum: 10/8afc50c84215f63ae1d8ab985ff682f2a5d3b16cf15bb50f12c7d1d95df8e60d29881dbe13858941655e2163410dccba6b609307a4a3fb85458c042f799a6bb8
   languageName: node
   linkType: hard
 
@@ -35617,7 +35617,7 @@ __metadata:
     "@metamask/test-dapp-solana": "npm:^0.3.0"
     "@metamask/transaction-controller": "npm:^68.2.0"
     "@metamask/transaction-pay-controller": "npm:^23.17.4"
-    "@metamask/tron-wallet-snap": "npm:^1.28.0"
+    "@metamask/tron-wallet-snap": "npm:^1.29.0"
     "@metamask/utils": "npm:^11.11.0"
     "@metamask/wallet": "npm:^6.0.0"
     "@myx-trade/sdk": "npm:^0.1.265"
