fix: for postquote payments payment token for MM Pay transaction should not be reset when accountOverride is changed (#30094)

<!--
Please submit this PR as a draft initially.

Do not mark it as "Ready for review" until this PR meets the canonical
Definition of Ready For Review in `docs/readme/ready-for-review.md`.

In short: the template must be materially complete (not just section
titles
present), all status checks must be currently passing, and the only
expected
follow-up commits must be reviewer-driven.
-->

## **Description**

Money account withdraw, selected token should not be reset when account
selection is changed.

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry:

## **Related issues**

Related to: https://consensyssoftware.atlassian.net/browse/CONF-1381

## **Manual testing steps**

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**
TODO

## **Pre-merge author checklist**

<!--
Every checklist item must be consciously assessed before marking this PR
as
"Ready for review". A checked box means you deliberately considered that
responsibility, not that you literally performed every action listed.

Unchecked boxes are ambiguous: they are not an implicit "N/A" and they
are not
a silent "skip". See `docs/readme/ready-for-review.md` for the full
checklist
semantics.
-->

- [X] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [X] I've completed the PR template to the best of my ability
- [X] I've included tests if applicable
- [X] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [X] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

#### Performance checks (if applicable)

- [ ] I've tested on Android
  - Ideally on a mid-range device; emulator is acceptable
- [ ] I've tested with a power user scenario
- Use these [power-user
SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93)
to import wallets with many accounts and tokens
- [ ] I've instrumented key operations with Sentry traces for production
performance metrics
- See [`trace()`](/app/util/trace.ts) for usage and
[`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274)
for an example

For performance guidelines and tooling, see the [Performance
Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers).

## **Pre-merge reviewer checklist**

<!--
Reviewer checklist items follow the same semantics as the author
checklist: an
unchecked box is ambiguous, a checked box means the reviewer consciously
assessed that responsibility. See `docs/readme/ready-for-review.md`.
-->

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Changes pay-token auto-selection behavior for post-quote withdraw
transaction types, which can affect what asset is used in
payment/withdraw flows if the gating condition is wrong. Scope is
limited and covered by updated unit tests.
> 
> **Overview**
> Prevents `useAutomaticTransactionPayToken` from re-selecting/resetting
the payment token when `accountOverride` or `from` changes for
*post-quote* withdraw transaction types, preserving the
user/quote-selected token.
> 
> Simplifies `PayWithRow` by removing `useMoneyAccountPayToken`-driven
display/disabled states and deletes the `useMoneyAccountPayToken` hook
and its tests. Refactors the money-account override event handler to use
the shared `hasTransactionType` utility, and updates/extends tests to
cover the new post-quote no-reselect behavior.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
d8212c9. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Author: jpuri

app/components/Views/confirmations/components/rows/pay-with-row/pay-with-row.test.tsx

@@ -5,7 +5,6 @@ import { useTransactionPayToken } from '../../../hooks/pay/useTransactionPayToke
 import { useTransactionPayWithdraw } from '../../../hooks/pay/useTransactionPayWithdraw';
 import { useTransactionPayRequiredTokens } from '../../../hooks/pay/useTransactionPayData';
 import { useTransactionPaySelectedFiatPaymentMethod } from '../../../hooks/pay/useTransactionPaySelectedFiatPaymentMethod';
-import { useMoneyAccountPayToken } from '../../../hooks/pay/useMoneyAccountPayToken';
 import { type PaymentMethod } from '@metamask/ramps-controller';
 import { useNavigation } from '@react-navigation/native';
 import { act, fireEvent } from '@testing-library/react-native';
@@ -29,7 +28,6 @@ jest.mock('../../../hooks/pay/useTransactionPayToken');
 jest.mock('../../../hooks/pay/useTransactionPayWithdraw');
 jest.mock('../../../hooks/pay/useTransactionPayData');
 jest.mock('../../../hooks/pay/useTransactionPaySelectedFiatPaymentMethod');
-jest.mock('../../../hooks/pay/useMoneyAccountPayToken');
 jest.mock('../../../../../../util/address');
 jest.mock('../../../hooks/metrics/useConfirmationMetricEvents');
 jest.mock('@react-navigation/native', () => ({
@@ -87,10 +85,6 @@ describe('PayWithRow', () => {
   const useTransactionPayRequiredTokensMock = jest.mocked(
     useTransactionPayRequiredTokens,
   );
-  const useTransactionMetadataRequestMock = jest.mocked(
-    useTransactionMetadataRequest,
-  );
-  const useMoneyAccountPayTokenMock = jest.mocked(useMoneyAccountPayToken);
   const useParamsMock = jest.mocked(useParams);
   const mockSetConfirmationMetric = jest.fn();
 
@@ -110,13 +104,6 @@ describe('PayWithRow', () => {
 
     useTransactionPayRequiredTokensMock.mockReturnValue(undefined as never);
 
-    useMoneyAccountPayTokenMock.mockReturnValue({
-      displayToken: undefined,
-      isAwaitingAccountSelection: false,
-      isMoneyAccountDeposit: false,
-      isMoneyAccountWithdraw: false,
-    });
-
     jest
       .mocked(useTransactionPaySelectedFiatPaymentMethod)
       .mockReturnValue(undefined);
@@ -140,13 +127,6 @@ describe('PayWithRow', () => {
     } as never);
 
     isHardwareAccountMock.mockReturnValue(false);
-
-    useMoneyAccountPayTokenMock.mockReturnValue({
-      displayToken: undefined,
-      isAwaitingAccountSelection: false,
-      isMoneyAccountDeposit: false,
-      isMoneyAccountWithdraw: false,
-    });
   });
 
   it('renders selected pay token', async () => {

app/components/Views/confirmations/components/rows/pay-with-row/pay-with-row.tsx

@@ -1,10 +1,4 @@
-import React, {
-  useCallback,
-  useEffect,
-  useMemo,
-  useRef,
-  useState,
-} from 'react';
+import React, { useCallback, useMemo } from 'react';
 import { useNavigation } from '@react-navigation/native';
 import { PaymentType } from '@consensys/on-ramp-sdk';
 import Routes from '../../../../../../constants/navigation/Routes';
@@ -46,7 +40,6 @@ import {
 } from '../../../ConfirmationView.testIds';
 import { useConfirmationMetricEvents } from '../../../hooks/metrics/useConfirmationMetricEvents';
 import { type PaymentMethod } from '@metamask/ramps-controller';
-import { useMoneyAccountPayToken } from '../../../hooks/pay/useMoneyAccountPayToken';
 import { useParams } from '../../../../../../util/navigation/navUtils';
 import { SetPayTokenRequest } from '../../../hooks/pay/useAutomaticTransactionPayToken';
 import { useConfirmationContext } from '../../../context/confirmation-context';
@@ -59,8 +52,6 @@ interface PayWithRouteParams {
 export function PayWithRow() {
   const navigation = useNavigation();
   const { payToken } = useTransactionPayToken();
-  const { displayToken: moneyAccountDisplayToken, isAwaitingAccountSelection } =
-    useMoneyAccountPayToken();
   const { isWithdraw } = useTransactionPayWithdraw();
   const requiredTokens = useTransactionPayRequiredTokens();
   const selectedFiatPaymentMethod =
@@ -116,14 +107,11 @@ export function PayWithRow() {
     (token) => !token.skipIfBalance && !token.allowUnderMinimum,
   );
   const displayToken = useMemo(() => {
-    if (moneyAccountDisplayToken) {
-      return moneyAccountDisplayToken;
-    }
     if (isWithdraw) {
       return payToken ?? defaultWithdrawToken ?? null;
     }
     return payToken ?? null;
-  }, [isWithdraw, payToken, defaultWithdrawToken, moneyAccountDisplayToken]);
+  }, [isWithdraw, payToken, defaultWithdrawToken]);
 
   // For deposits, show the user's balance of the selected pay token
   const balanceUsdFormatted = useMemo(
@@ -143,30 +131,6 @@ export function PayWithRow() {
     );
   }
 
-  if (isAwaitingAccountSelection) {
-    return (
-      <Box
-        flexDirection={FlexDirection.Row}
-        alignItems={AlignItems.center}
-        justifyContent={JustifyContent.spaceBetween}
-        style={[styles.container, styles.disabled]}
-        testID={ConfirmationRowComponentIDs.PAY_WITH}
-      >
-        <Text variant={TextVariant.BodyMd} color={TextColor.TextAlternative}>
-          {label}
-        </Text>
-        <Text
-          variant={TextVariant.BodyMd}
-          fontWeight={FontWeight.Medium}
-          color={TextColor.TextAlternative}
-          testID={TransactionPayComponentIDs.PAY_WITH_SYMBOL}
-        >
-          {strings('confirm.label.payment_method')}
-        </Text>
-      </Box>
-    );
-  }
-
   if (!displayToken) {
     return <PayWithRowSkeleton />;
   }

app/components/Views/confirmations/hooks/pay/useAutomaticTransactionPayToken.test.ts

@@ -964,7 +964,45 @@ describe('useAutomaticTransactionPayToken', () => {
     });
   });
 
-  it('re-selects pay token when accountOverride changes', () => {
+  it('does not re-select pay token when accountOverride changes for post-quote withdraws', () => {
+    useTransactionPayAvailableTokensMock.mockReturnValue({
+      availableTokens: [
+        {
+          address: TOKEN_ADDRESS_1_MOCK,
+          chainId: CHAIN_ID_1_MOCK,
+        },
+        {
+          address: PREFERRED_TOKEN_ADDRESS_MOCK,
+          chainId: PREFERRED_CHAIN_ID_MOCK,
+        },
+      ] as AssetType[],
+      hasTokens: true,
+    });
+
+    useTransactionMetadataRequestMock.mockReturnValue({
+      id: transactionIdMock,
+      type: TransactionType.moneyAccountWithdraw,
+      txParams: { from: '0xAddress1' },
+    } as never);
+
+    const { rerender } = runHook({
+      preferredToken: {
+        address: PREFERRED_TOKEN_ADDRESS_MOCK as Hex,
+        chainId: PREFERRED_CHAIN_ID_MOCK as Hex,
+      },
+    });
+
+    expect(setPayTokenMock).toHaveBeenCalledTimes(1);
+    setPayTokenMock.mockClear();
+
+    useTransactionAccountOverrideMock.mockReturnValue('0xOverrideA' as Hex);
+
+    rerender(undefined);
+
+    expect(setPayTokenMock).not.toHaveBeenCalled();
+  });
+
+  it('does not re-select pay token on from change for post-quote withdraws', () => {
     useTransactionPayAvailableTokensMock.mockReturnValue({
       availableTokens: [
         {
@@ -979,25 +1017,33 @@ describe('useAutomaticTransactionPayToken', () => {
       hasTokens: true,
     });
 
+    useTransactionPayTokenMock.mockReturnValue({
+      payToken: {
+        address: TOKEN_ADDRESS_1_MOCK,
+        chainId: CHAIN_ID_1_MOCK,
+      } as unknown as ReturnType<typeof useTransactionPayToken>['payToken'],
+      setPayToken: setPayTokenMock,
+    });
+
     useTransactionMetadataRequestMock.mockReturnValue({
       id: transactionIdMock,
-      type: TransactionType.moneyAccountDeposit,
+      type: TransactionType.predictWithdraw,
       txParams: { from: '0xAddress1' },
     } as never);
 
     const { rerender } = runHook();
 
-    expect(setPayTokenMock).toHaveBeenCalledTimes(1);
-    setPayTokenMock.mockClear();
+    expect(setPayTokenMock).not.toHaveBeenCalled();
 
-    useTransactionAccountOverrideMock.mockReturnValue('0xOverrideA' as Hex);
+    useTransactionMetadataRequestMock.mockReturnValue({
+      id: transactionIdMock,
+      type: TransactionType.predictWithdraw,
+      txParams: { from: '0xAddress2' },
+    } as never);
 
     rerender(undefined);
 
-    expect(setPayTokenMock).toHaveBeenCalledWith({
-      address: TOKEN_ADDRESS_2_MOCK,
-      chainId: CHAIN_ID_2_MOCK,
-    });
+    expect(setPayTokenMock).not.toHaveBeenCalled();
   });
 
   it('does not re-select on from change when disabled', () => {

app/components/Views/confirmations/hooks/pay/useAutomaticTransactionPayToken.ts

@@ -177,7 +177,12 @@ export function useAutomaticTransactionPayToken({
   const prevAccountKeyRef = useRef(`${from ?? ''}:${accountOverride ?? ''}`);
   useEffect(() => {
     const accountKey = `${from ?? ''}:${accountOverride ?? ''}`;
-    if (disable || !from || prevAccountKeyRef.current === accountKey) {
+    if (
+      disable ||
+      !from ||
+      prevAccountKeyRef.current === accountKey ||
+      postQuoteTransactionType
+    ) {
       return;
     }
     prevAccountKeyRef.current = accountKey;
@@ -189,7 +194,14 @@ export function useAutomaticTransactionPayToken({
       });
       log('Re-selected pay token after account change', automaticToken);
     }
-  }, [accountOverride, automaticToken, disable, from, setPayToken]);
+  }, [
+    accountOverride,
+    automaticToken,
+    disable,
+    from,
+    postQuoteTransactionType,
+    setPayToken,
+  ]);
 
   return automaticToken;
 }