Skip to content

Commit e256c8c

Browse files
authored
chore: resolution for qs package (#24235)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** * Resolution for qs package * Remove qs package dependency <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: ## **Related issues** Fixes: ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Ensures a single, consistent `qs` version across the project. > > - Adds `resolutions` entry for `qs` at `6.14.1` in `package.json` > - Updates `dependencies` `qs` from `6.12.1` to `6.14.1` > - Regenerates `yarn.lock` to use `qs@6.14.1` and drop previous `qs` versions (`6.12.1`, `6.13.0`, `6.14.0`) > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit f02c580. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent adcb2c2 commit e256c8c

2 files changed

Lines changed: 8 additions & 25 deletions

File tree

package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,8 @@
176176
"@ethereumjs/util@npm:^9.0.2": "patch:@ethereumjs/util@npm%3A9.1.0#~/.yarn/patches/@ethereumjs-util-npm-9.1.0-7e85509408.patch",
177177
"@metamask/key-tree@npm:^10.1.1": "patch:@metamask/key-tree@npm%3A10.1.1#~/.yarn/patches/@metamask-key-tree-npm-10.1.1-0bfab435ac.patch",
178178
"@metamask/key-tree@npm:^10.0.2": "patch:@metamask/key-tree@npm%3A10.1.1#~/.yarn/patches/@metamask-key-tree-npm-10.1.1-0bfab435ac.patch",
179-
"@metamask/transaction-controller@npm:^62.7.0": "patch:@metamask/transaction-controller@npm%3A62.7.0#~/.yarn/patches/@metamask-transaction-controller-npm-61.0.0-cccac388c7.patch"
179+
"@metamask/transaction-controller@npm:^62.7.0": "patch:@metamask/transaction-controller@npm%3A62.7.0#~/.yarn/patches/@metamask-transaction-controller-npm-61.0.0-cccac388c7.patch",
180+
"qs": "6.14.1"
180181
},
181182
"dependencies": {
182183
"@config-plugins/detox": "^9.0.0",
@@ -398,7 +399,7 @@
398399
"prop-types": "15.7.2",
399400
"pump": "3.0.0",
400401
"punycode": "^2.1.1",
401-
"qs": "6.12.1",
402+
"qs": "6.14.1",
402403
"query-string": "^6.12.1",
403404
"randomfill": "^1.0.4",
404405
"react": "18.3.1",

yarn.lock

Lines changed: 5 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -34456,7 +34456,7 @@ __metadata:
3445634456
prop-types: "npm:15.7.2"
3445734457
pump: "npm:3.0.0"
3445834458
punycode: "npm:^2.1.1"
34459-
qs: "npm:6.12.1"
34459+
qs: "npm:6.14.1"
3446034460
query-string: "npm:^6.12.1"
3446134461
randomfill: "npm:^1.0.4"
3446234462
react: "npm:18.3.1"
@@ -38233,30 +38233,12 @@ __metadata:
3823338233
languageName: node
3823438234
linkType: hard
3823538235

38236-
"qs@npm:6.12.1":
38237-
version: 6.12.1
38238-
resolution: "qs@npm:6.12.1"
38239-
dependencies:
38240-
side-channel: "npm:^1.0.6"
38241-
checksum: 10/035bcad2a1ab0175bac7a74c904c15913bdac252834149ccff988c93a51de02642fe7be10e43058ba4dc4094bb28ce9b59d12b9e91d40997f445cfde3ecc1c29
38242-
languageName: node
38243-
linkType: hard
38244-
38245-
"qs@npm:6.13.0":
38246-
version: 6.13.0
38247-
resolution: "qs@npm:6.13.0"
38248-
dependencies:
38249-
side-channel: "npm:^1.0.6"
38250-
checksum: 10/f548b376e685553d12e461409f0d6e5c59ec7c7d76f308e2a888fd9db3e0c5e89902bedd0754db3a9038eda5f27da2331a6f019c8517dc5e0a16b3c9a6e9cef8
38251-
languageName: node
38252-
linkType: hard
38253-
38254-
"qs@npm:^6.10.0, qs@npm:^6.12.3, qs@npm:^6.5.2":
38255-
version: 6.14.0
38256-
resolution: "qs@npm:6.14.0"
38236+
"qs@npm:6.14.1":
38237+
version: 6.14.1
38238+
resolution: "qs@npm:6.14.1"
3825738239
dependencies:
3825838240
side-channel: "npm:^1.1.0"
38259-
checksum: 10/a60e49bbd51c935a8a4759e7505677b122e23bf392d6535b8fc31c1e447acba2c901235ecb192764013cd2781723dc1f61978b5fdd93cc31d7043d31cdc01974
38241+
checksum: 10/34b5ab00a910df432d55180ef39c1d1375e550f098b5ec153b41787f1a6a6d7e5f9495593c3b112b77dbc6709d0ae18e55b82847a4c2bbbb0de1e8ccbb1794c5
3826038242
languageName: node
3826138243
linkType: hard
3826238244

0 commit comments

Comments
 (0)